You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by am...@apache.org on 2021/02/23 12:30:25 UTC

[superset] branch chore/handle_save_dash_error created (now 63e7c7c)

This is an automated email from the ASF dual-hosted git repository.

amitmiran pushed a change to branch chore/handle_save_dash_error
in repository https://gitbox.apache.org/repos/asf/superset.git.


      at 63e7c7c  fix: project None value

This branch includes the following new commits:

     new 63e7c7c  fix: project None value

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 01/01: fix: project None value

Posted by am...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

amitmiran pushed a commit to branch chore/handle_save_dash_error
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 63e7c7c5f997a28d54ee79100f434ea1dd796b6f
Author: amitmiran137 <am...@nielsen.com>
AuthorDate: Tue Feb 23 14:29:21 2021 +0200

    fix: project None value
---
 superset/views/core.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 155555e..db58239 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1178,7 +1178,7 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
         # the dashboard was open. it was use to avoid mid-air collision.
         remote_last_modified_time = data.get("last_modified_time")
         current_last_modified_time = dash.changed_on.replace(microsecond=0).timestamp()
-        if remote_last_modified_time < current_last_modified_time:
+        if remote_last_modified_time and remote_last_modified_time < current_last_modified_time:
             return json_error_response(
                 __(
                     "This dashboard was changed recently. "