You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Thiruvalluvan M. G. (Jira)" <ji...@apache.org> on 2021/03/07 13:54:00 UTC

[jira] [Resolved] (AVRO-2933) avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS

     [ https://issues.apache.org/jira/browse/AVRO-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. resolved AVRO-2933.
---------------------------------------
    Fix Version/s: 1.11.0
       Resolution: Fixed

Merged the pull request. Thank you [~tbarbier]. I'm very sorry about extraordinary delay in merging this.

> avro c++ CMakeList enforces a specific version of C++ instead of letting user CXXFLAGS
> --------------------------------------------------------------------------------------
>
>                 Key: AVRO-2933
>                 URL: https://issues.apache.org/jira/browse/AVRO-2933
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.10.0, 1.9.2
>            Reporter: Thomas Barbier
>            Assignee: Thomas Barbier
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> Hello,
> I have an issue with Avro C++: 
> The CMakeList enforces the use of C++11 (https://github.com/apache/avro/blob/master/lang/c%2B%2B/CMakeLists.txt#L57)
> {code:java}
> add_definitions(-std=c++11 -fPIC)
> {code}
> In local, I need to build with c++20 and therefore removed this line from my CMakeList (the std== parameters is in my CXXFLAGS).
>  
> As I don't know what is the best practice to let users choose their C++ version I create the issue to open the discussion and will submit a PR in case you agree with it.
>  
> Best Regards
> Thomas
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)