You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by ry...@apache.org on 2008/12/16 20:13:14 UTC

svn commit: r727122 - in /lucene/solr/trunk/src/java/org/apache/solr/core: CloseHook.java SolrCore.java

Author: ryan
Date: Tue Dec 16 11:13:13 2008
New Revision: 727122

URL: http://svn.apache.org/viewvc?rev=727122&view=rev
Log:
SOLR-915 - adding docs to CloseHook and making the list a Collection

Modified:
    lucene/solr/trunk/src/java/org/apache/solr/core/CloseHook.java
    lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/core/CloseHook.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/core/CloseHook.java?rev=727122&r1=727121&r2=727122&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/core/CloseHook.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/core/CloseHook.java Tue Dec 16 11:13:13 2008
@@ -29,5 +29,16 @@
   */
 
  public interface CloseHook {
+   
+   /**
+    * Method called when the given SolrCore object is closing / shutting down.
+    * <br />
+    *  <b>Important:</b> Keep the method implementation as short as possible. If it were to use any heavy i/o , network connections -
+    *   it might be a better idea to launch in a separate Thread so as to not to block the process of 
+    *   shutting down a given SolrCore instance.   
+    *   
+    * 
+    * @param core SolrCore object that is shutting down / closing
+    */
    void close( SolrCore core );
  }

Modified: lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java?rev=727122&r1=727121&r2=727122&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/core/SolrCore.java Tue Dec 16 11:13:13 2008
@@ -740,7 +740,7 @@
     }
   }
 
-  private List<CloseHook> closeHooks = null;
+  private Collection<CloseHook> closeHooks = null;
 
    /**
     * Add a close callback hook