You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/04/23 15:16:34 UTC
[GitHub] [arrow-datafusion-python] andygrove opened a new issue, #336: Add GitHub action to publish wheels to PyPi / TestPyPi
andygrove opened a new issue, #336:
URL: https://github.com/apache/arrow-datafusion-python/issues/336
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
We already have a GitHub workflow that builds wheels when the repo is tagged with a release tag or rc tag. Hoever, we have to manually download these files and upload them to PyPi and TestPyPi.
**Describe the solution you'd like**
I would like this automated.
**Describe alternatives you've considered**
Keep doing it manually
**Additional context**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on issue #336: Add GitHub action to publish wheels to PyPi / TestPyPi
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #336:
URL: https://github.com/apache/arrow-datafusion-python/issues/336#issuecomment-1519151666
> Are you looking for help on this? If so, we can help out.
Yes, that would be fantastic. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] ayushdg commented on issue #336: Add GitHub action to publish wheels to PyPi / TestPyPi
Posted by "ayushdg (via GitHub)" <gi...@apache.org>.
ayushdg commented on issue #336:
URL: https://github.com/apache/arrow-datafusion-python/issues/336#issuecomment-1526088486
pypi uses the `rcN` part of the tag to identify that a package is a release candidate and usually marks it as such. So if the wheel version has the rc tag, it doesn't overwrite them but instead creates a new entry. There's more info in [pep440](https://peps.python.org/pep-0440/) and here's an example of how it shows up on pypi for a project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on issue #336: Add GitHub action to publish wheels to PyPi / TestPyPi
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #336:
URL: https://github.com/apache/arrow-datafusion-python/issues/336#issuecomment-1519151512
@kylebrooks-8451 yes, we want to publish when certain tags are pushed to the repo (similar to how we currently build the wheels when rc tags are pushed.
For example, pushing `23.0.0-rc1` should trigger an upload to TestPyPi. Since we already run `maturin build` on rc tags, maybe we just need to update this to `maturin pubilsh` instead? We will need to store an authentication token as a GitHub secret.
For the final release, I think we can just have a script that downloads the wheels from TestPyPi and uploads them to PyPi. No need to build new artifacts. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on issue #336: Add GitHub action to publish wheels to PyPi / TestPyPi
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on issue #336:
URL: https://github.com/apache/arrow-datafusion-python/issues/336#issuecomment-1520239851
One challenge is how we handle the case where we have multiple release candidates, such as 23.0.0-rc1 followed by 23.0.0-rc2. I doin't know if we can re-upload wheels and overwrite them since the wheel version would still just be 23.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] kylebrooks-8451 commented on issue #336: Add GitHub action to publish wheels to PyPi / TestPyPi
Posted by "kylebrooks-8451 (via GitHub)" <gi...@apache.org>.
kylebrooks-8451 commented on issue #336:
URL: https://github.com/apache/arrow-datafusion-python/issues/336#issuecomment-1519145109
Do we only want an upload to PyPi to occur if there is a manual approval? If so, we could make a Github environment that requires an approval and add it to the commented out workflow code that uploads to PyPi to ensure releases still have a vote. Maybe `pypi` is a good name for the env. Are you looking for help on this? If so, we can help out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org