You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/14 11:33:58 UTC
[GitHub] [flink] Airblader opened a new pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Airblader opened a new pull request #17481:
URL: https://github.com/apache/flink/pull/17481
## What is the purpose of the change
This adds a new `JSON_STRING` function which serializes its arguments into a JSON string.
## Verifying this change
This change added tests and can be verified as follows:
- `JsonFunctionsITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs + JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r728893668
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ SqlTypeTransforms.LEAST_NULLABLE),
Review comment:
Calcite's `TO_NULLABLE` actually has a (to me) surprising behavior that breaks tests: for structured types – like `ROW` – it also checks the nullability of all of the inner fields. This means that `ROW<r0 STRING> NOT NULL` would be considered nullable. Big "wat?" moment to me, and curious to have someone explain to me why that makes sense.
In any case, `LEAST_NULLABLE` does not have this behavior, and otherwise does the same thing in our case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
}, {
"hash" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099)
* c2942d9182b4efe3d07680f7c4624b77646359d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r728913694
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ FlinkReturnTypes.TO_NULLABLE_SHALLOW),
Review comment:
Calcite's `TO_NULLABLE` actually has a (to me) surprising behavior that breaks tests: for structured types – like `ROW` – it also checks the nullability of all of the inner fields. This means that `ROW<r0 STRING> NOT NULL` would be considered nullable. Big "wat?" moment to me, and curious to have someone explain to me why that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r728909194
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ SqlTypeTransforms.LEAST_NULLABLE),
Review comment:
Ah, actually `LEAST_NULLABLE` doesn't work when `NULL` is passed…
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ SqlTypeTransforms.LEAST_NULLABLE),
Review comment:
Calcite's `TO_NULLABLE` actually has a (to me) surprising behavior that breaks tests: for structured types – like `ROW` – it also checks the nullability of all of the inner fields. This means that `ROW<r0 STRING> NOT NULL` would be considered nullable. Big "wat?" moment to me, and curious to have someone explain to me why that makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r728909194
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ SqlTypeTransforms.LEAST_NULLABLE),
Review comment:
Ah, actually `LEAST_NULLABLE` doesn't work when `NULL` is passed…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273212
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 (Thu Oct 14 11:36:30 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
}, {
"hash" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201",
"triggerID" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"triggerType" : "PUSH"
}, {
"hash" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099)
* c2942d9182b4efe3d07680f7c4624b77646359d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201)
* dfc2e33dcf2153909ba96a0f3cc712ac694fc158 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
}, {
"hash" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201",
"triggerID" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099)
* c2942d9182b4efe3d07680f7c4624b77646359d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
}, {
"hash" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201",
"triggerID" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"triggerType" : "PUSH"
}, {
"hash" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25204",
"triggerID" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfc2e33dcf2153909ba96a0f3cc712ac694fc158 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25204)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
}, {
"hash" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201",
"triggerID" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"triggerType" : "PUSH"
}, {
"hash" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25204",
"triggerID" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c2942d9182b4efe3d07680f7c4624b77646359d2 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201)
* dfc2e33dcf2153909ba96a0f3cc712ac694fc158 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25204)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r731567311
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
Review comment:
I've opened https://issues.apache.org/jira/browse/FLINK-24586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r731595272
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/DirectConvertRule.java
##########
@@ -210,10 +210,6 @@
DEFINITION_OPERATOR_MAP.put(
BuiltInFunctionDefinitions.STREAM_RECORD_TIMESTAMP,
FlinkSqlOperatorTable.STREAMRECORD_TIMESTAMP);
-
- // JSON
- DEFINITION_OPERATOR_MAP.put(
- BuiltInFunctionDefinitions.JSON_STRING, FlinkSqlOperatorTable.JSON_STRING);
Review comment:
can we also remove `FlinkSqlOperatorTable.JSON_STRING` and `TO_NULLABLE_SHALLOW` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r731112769
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/converter/DirectConvertRule.java
##########
@@ -210,6 +210,10 @@
DEFINITION_OPERATOR_MAP.put(
BuiltInFunctionDefinitions.STREAM_RECORD_TIMESTAMP,
FlinkSqlOperatorTable.STREAMRECORD_TIMESTAMP);
+
+ // JSON
+ DEFINITION_OPERATOR_MAP.put(
Review comment:
in theory, we could use bridging function instead (for the planning) but with code gen for runtime implementation. is there a reason why we should have a Calcite function here?
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
Review comment:
side comment: let's overwrite the `VARCHAR(2000)` for the other JSON functions, it will cause issues in the future otherwise. we are discussing having it more strict in the future. see FLINK-24413.
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ FlinkReturnTypes.TO_NULLABLE_SHALLOW),
Review comment:
This is known behavior. The inner nullability depends on the outer nullability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r731542432
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
Review comment:
FWIW, there are a bunch of functions like CHR, REVERSE, etc., that are also typed to `VARCHAR(2000)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r731548152
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ FlinkReturnTypes.TO_NULLABLE_SHALLOW),
Review comment:
But isn't it the other way around here, i.e. the outer nullability depends on the inner nullability?
Also, just to make sure, you're not saying I should change this, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17481:
URL: https://github.com/apache/flink/pull/17481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25057",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
}, {
"hash" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099",
"triggerID" : "9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57",
"triggerType" : "PUSH"
}, {
"hash" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201",
"triggerID" : "c2942d9182b4efe3d07680f7c4624b77646359d2",
"triggerType" : "PUSH"
}, {
"hash" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25204",
"triggerID" : "dfc2e33dcf2153909ba96a0f3cc712ac694fc158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f452d38c5cc26fb1388e4e96ef0acc2d3e50b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25099)
* c2942d9182b4efe3d07680f7c4624b77646359d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25201)
* dfc2e33dcf2153909ba96a0f3cc712ac694fc158 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25204)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r728896329
##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/JsonStringCallGen.scala
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen.calls
+
+import org.apache.flink.table.planner.codegen.CodeGenUtils.{BINARY_STRING, className, newName, primitiveTypeTermForType}
+import org.apache.flink.table.planner.codegen.JsonGenerateUtils.createNodeTerm
+import org.apache.flink.table.planner.codegen.{CodeGeneratorContext, GeneratedExpression}
+import org.apache.flink.table.runtime.functions.SqlJsonUtils
+import org.apache.flink.table.types.logical.LogicalType
+
+import org.apache.calcite.rex.RexCall
+
+/** [[CallGenerator]] for `JSON_STRING`. */
+class JsonStringCallGen(call: RexCall) extends CallGenerator {
+ private def jsonUtils = className[SqlJsonUtils]
+
+ override def generate(
+ ctx: CodeGeneratorContext,
+ operands: Seq[GeneratedExpression],
+ returnType: LogicalType): GeneratedExpression = {
+
+ val valueTerm = createNodeTerm(ctx, operands.head, call.operands.get(0))
Review comment:
I reckon that once (and if) we rewrite `JSON_OBJECT`, `JSON_ARRAY` to use the same trick that we're planning for `JSON_OBJECTAGG` and `JSON_ARRAYAGG`, we can convert `JSON_STRING` from a code-generated function into a nice little Java class. But for the moment we should re-use the existing code generation we have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17481:
URL: https://github.com/apache/flink/pull/17481#discussion_r728893668
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -1145,6 +1145,16 @@ public boolean isDeterministic() {
public static final SqlFunction JSON_EXISTS = SqlStdOperatorTable.JSON_EXISTS;
public static final SqlFunction JSON_VALUE = SqlStdOperatorTable.JSON_VALUE;
public static final SqlFunction JSON_QUERY = SqlStdOperatorTable.JSON_QUERY;
+ public static final SqlFunction JSON_STRING =
+ new SqlFunction(
+ "JSON_STRING",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.cascade(
+ ReturnTypes.explicit(SqlTypeName.VARCHAR),
+ SqlTypeTransforms.LEAST_NULLABLE),
Review comment:
Calcite's `TO_NULLABLE` actually has a (to me) surprising behavior that breaks tests: for structured types – like `ROW` – it also checks the nullability of all of the inner fields. This means that `ROW<r0 STRING> NOT NULL` would be considered nullable. Big "wat?" moment to me, and anxious to have someone explain to me why that makes sense.
In any case, `LEAST_NULLABLE` does not have this behavior, and otherwise does the same thing in our case here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
}, {
"hash" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37ac25e77251b0665bffb3c0e5640dd58c9f4176",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
* 37ac25e77251b0665bffb3c0e5640dd58c9f4176 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17481: [FLINK-24387][table-planner] Support JSON_STRING.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17481:
URL: https://github.com/apache/flink/pull/17481#issuecomment-943273916
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052",
"triggerID" : "e0c506d88d78c9ce851b2fd080e55ad5e4d879a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0c506d88d78c9ce851b2fd080e55ad5e4d879a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org