[GitHub] [helix] jiajunwang edited a comment on pull request #1580: Update the internal fields of the Data Providr when overriding the data through set methods.

[GitBox <gi...@apache.org>]

jiajunwang edited a comment on pull request #1580:
URL: https://github.com/apache/helix/pull/1580#issuecomment-742966189


   > Change looks fine to me. Can you elaborate more we do this from external input? Why we cannot set cluster config and call these functions
   
   That's also a possible way. But the target refresh method is a private one. And I don't think we want to break the OO design here.
   So as a result you cannot set and then trigger a partial refresh from outside. So either you set to override one list, but the corresponding derived fields have old values. Or you call full refresh but your set data will be covered by the ZK data source.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org