You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by max3163 <gi...@git.apache.org> on 2017/01/26 11:08:17 UTC

[GitHub] jmeter pull request #258: BZ60590

GitHub user max3163 opened a pull request:

    https://github.com/apache/jmeter/pull/258

    BZ60590

    This PR has 3 new changes for the Backend Listener : 
    
    - Start the scheduler for the InfluxdbListener immediately to send start annotation even if the test take less than 5 sec.
    - Add a new parameter in the Influxdb Backend to put tags. ( i.e  Tags are separated by spaces in grafana )
    Tags is put as Influxdb Tag for better query performance on it
    - Add new option in jmeter.properties to ignore BackendListener when validating the thread group of plan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/max3163/jmeter BZ60590

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #258
    
----
commit cb929d22e586e6c2cc5197d36931a794bc07542f
Author: Maxime Chassagneux <ma...@gmail.com>
Date:   2017-01-26T08:54:48Z

    Influxdb : Start immediately the scheduler

commit 3ee2464cd58d7cf5f164bb4922ea891af3db70d0
Author: Maxime Chassagneux <ma...@gmail.com>
Date:   2017-01-26T10:05:08Z

    Add Tags parameter for annotation events

commit 79c5312871fb95c20ea5850b9eb318d1b0d99935
Author: Maxime Chassagneux <ma...@gmail.com>
Date:   2017-01-26T10:06:14Z

    Ignore BackendListener when validating the thread group of plan

commit 335d7df7192b146650c800841d9c536aa4766cbf
Author: Chassagneux Maxime <41...@airfrance.fr>
Date:   2017-01-26T10:52:57Z

    Revert "Ignore BackendListener when validating the thread group of plan"
    
    This reverts commit 79c5312871fb95c20ea5850b9eb318d1b0d99935.

commit 2a59e5fe78b54508cb6c710e758d94544f425802
Author: Maxime Chassagneux <ma...@gmail.com>
Date:   2017-01-26T11:00:12Z

    Ignore Backend Listener when validating the thread group of plan

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    I tried the patch and I don't see annotations displayed.
    I tried with:
    eventTags = TestTag
    And 
    eventTags = Test tag for release version=1.2.3
    
    [
    <img width="789" alt="screen shot 2017-01-26 at 15 13 04" src="https://cloud.githubusercontent.com/assets/3127467/22334124/cd99ecce-e3d9-11e6-903a-19f18532a3c3.png">
    <img width="352" alt="screen shot 2017-01-26 at 15 12 45" src="https://cloud.githubusercontent.com/assets/3127467/22334125/cdba8268-e3d9-11e6-8fe4-be27fd0502ad.png">
    
    ](url)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    Hello, 
    
    Yes it's exactly to avoid sending data to InfluxDB or Graphite when you just validate one thread group.
    Sorry for merging this commits in the PR, next time I will split.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #258: BZ60590

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/258


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    This is explained by:
    - https://bz.apache.org/bugzilla/show_bug.cgi?id=60650


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    Hi,
    You were right.
    I have a second possible issue.
    Here is what the meanAT shows. It does not look ok to me .
    <img width="1418" alt="screen shot 2017-01-26 at 15 51 03" src="https://cloud.githubusercontent.com/assets/3127467/22335641/c6c20a2a-e3df-11e6-9540-626affe26f89.png">
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    Strange ... could you try with a Group By function in your query like this : 
    
    ![image](https://cloud.githubusercontent.com/assets/13835366/22335958/f1df01bc-e3e0-11e6-8bef-fe53be1b5c6c.png)
    
    You have to put a time equal or above the polling time scheduler of JMeter


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    In my opinion, you events measurement in Influxdb is "corrupted" by old test and looks like this 
    
    ![image](https://cloud.githubusercontent.com/assets/13835366/22334617/b8b603cc-e3db-11e6-9a38-468fbfb624de.png)
    
    
    You have the same entry name as Field and as Tag. 
    Pls could you test with a clean events measurement ? => " drop measurement events "



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #258: BZ60590

Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/258
  
    Hello,
    Thanks for PR.
    I'll look into merging it but what exactly is the 3rd point ?  Is it to avoid sending to INflux the Validation results ?
    Usually it's better to split PR in this case.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---