You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/02 05:55:50 UTC

[GitHub] codecov-io commented on issue #4728: [sql_lab]Disabled run query button if sql query editor is empty

codecov-io commented on issue #4728: [sql_lab]Disabled run query button if sql query editor is empty
URL: https://github.com/apache/incubator-superset/pull/4728#issuecomment-377861570
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=h1) Report
   > Merging [#4728](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/069d61c53f03608f05a0684572b9a2bb545fd9a6?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4728/graphs/tree.svg?src=pr&token=KsB0fHcx6l&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4728   +/-   ##
   =======================================
     Coverage   72.22%   72.22%           
   =======================================
     Files         204      204           
     Lines       15323    15323           
     Branches     1180     1180           
   =======================================
     Hits        11067    11067           
     Misses       4253     4253           
     Partials        3        3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `77.88% <ø> (ø)` | :arrow_up: |
   | [...scripts/SqlLab/components/RunQueryActionButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLmpzeA==) | `88% <ø> (ø)` | :arrow_up: |
   | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <0%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=footer). Last update [069d61c...a337e60](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services