You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2016/09/14 01:46:13 UTC
[Toolchain-CR] Add support for Kudu 1.0 RC and build additional OSes
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4410
Change subject: Add support for Kudu 1.0 RC and build additional OSes
......................................................................
Add support for Kudu 1.0 RC and build additional OSes
Relaxes the requirements on the OSes that can be used to
build Kudu. This now allows building on Ubuntu 12,
Debian 7, and Debian 8. RHEL5, Debian 6, and SLES still fail
to build so the stub is produced.
Also removes some unnecessary kudu utilities (cfile-dump and
log-dump) that were being copied out of the build directory
because they have been removed at version 1.0. They were
never being used by Impala nor are related to building, so
it shouldn't matter.
Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
---
M buildall.sh
M source/kudu/build.sh
2 files changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/10/4410/1
--
To view, visit http://gerrit.cloudera.org:8080/4410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
[Toolchain-CR] Add support for Kudu 1.0 RC and build additional OSes
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has submitted this change and it was merged.
Change subject: Add support for Kudu 1.0 RC and build additional OSes
......................................................................
Add support for Kudu 1.0 RC and build additional OSes
Relaxes the requirements on the OSes that can be used to
build Kudu. This now allows building on Ubuntu 12,
Debian 7, and Debian 8. RHEL5, Debian 6, and SLES still fail
to build so the stub is produced.
Also removes some unnecessary kudu utilities (cfile-dump and
log-dump) that were being copied out of the build directory
because they have been removed at version 1.0. They were
never being used by Impala nor are related to building, so
it shouldn't matter.
Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
---
M buildall.sh
M source/kudu/build.sh
2 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, approved; Verified
Alex Behm: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] Add support for Kudu 1.0 RC and build additional OSes
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Add support for Kudu 1.0 RC and build additional OSes
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4410/1/buildall.sh
File buildall.sh:
Line 218: for KUDU_VERSION in 0.8.0-RC1 0.9.0-RC1 0.10.0-RC1 1.0.0-RC1
I think fairly soon we're going to have to deal with the increasing build times, especially with all the Kudu versions having their own toolchains.
--
To view, visit http://gerrit.cloudera.org:8080/4410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] Add support for Kudu 1.0 RC and build additional OSes
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Add support for Kudu 1.0 RC and build additional OSes
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Tim, can you also take a look and sign off if good? Thanks!
http://gerrit.cloudera.org:8080/#/c/4410/1//COMMIT_MSG
Commit Message:
Line 10: build Kudu. This now allows building on Ubuntu 12,
Yay! Ubuntu 12 :)
--
To view, visit http://gerrit.cloudera.org:8080/4410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] Add support for Kudu 1.0 RC and build additional OSes
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: Add support for Kudu 1.0 RC and build additional OSes
......................................................................
Patch Set 1: Code-Review+2 Verified+1
(1 comment)
Thanks
http://gerrit.cloudera.org:8080/#/c/4410/1/buildall.sh
File buildall.sh:
Line 218: for KUDU_VERSION in 0.8.0-RC1 0.9.0-RC1 0.10.0-RC1 1.0.0-RC1
> I think fairly soon we're going to have to deal with the increasing build t
Agreed. Not for right now but I was thinking that:
1) it would probably be worth archiving old builds from s3 and then having this only build the latest versions of various packages.
2) useful to create a related toolchain job that allows building a particular package(s) (tricky when there are dependencies)
--
To view, visit http://gerrit.cloudera.org:8080/4410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68c32b474464ccd7531b5c5bf163017cbb6f6f9b
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes