[jira] [Commented] (CB-6970) Share win project files manipulation code between cordova and plugman

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035664#comment-14035664 ] 

ASF GitHub Bot commented on CB-6970:
------------------------------------

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-lib/pull/32

    CB-6970 Share win project files manipulation code between cordova and plugman

    https://issues.apache.org/jira/browse/CB-6970
    
    1. Shared csproj and jsproj classes
    2. Updated code to use those classes instead of manual manipulation
    3. Updated removeSourceFile method to support regexp as parameter (ability to remove batch files or all files from specific folder).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-6970

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 09759f285e698e16746304f1f6d074a4cc019008
Author: sgrebnov <v-...@microsoft.com>
Date:   2014-06-18T12:58:20Z

    CB-6970 Share win project files manipulation code between cordova and plugman

----


> Share win project files manipulation code between cordova and plugman
> ---------------------------------------------------------------------
>
>                 Key: CB-6970
>                 URL: https://issues.apache.org/jira/browse/CB-6970
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaLib, Windows 8, WP8
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-lib, windows8, wp8
>
> Both cordova and plugman use own logic to parse and modify jsproj and csproj files, for example (cordova) windows8_parser/update_jsproj and (plugman) w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and update jsproj files. 
> It is better to remove duplicate code and have special shared classes to work with project files. Cordova and plugman should rely on those classes instead of using own implementation. 
> We should also remove manual project files manipulation logic from general cordova/plugman classes, like below. 
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83
> Implementation layer should be hidden from them, they just need to rely on special well named methods provided by newly introduced classes (see above).



--
This message was sent by Atlassian JIRA
(v6.2#6252)