You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2009/02/07 14:26:13 UTC
svn commit: r741890 - in /httpcomponents/httpcore/trunk:
module-main/src/main/java/org/apache/http/params/BasicHttpParams.java
module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java
src/docbkx/fundamentals.xml
Author: olegk
Date: Sat Feb 7 13:26:13 2009
New Revision: 741890
URL: http://svn.apache.org/viewvc?rev=741890&view=rev
Log:
Added notes about thread-unsafely of BasicHttpParams and BasicHttpProcessor to javadocs and tutorial
Modified:
httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/params/BasicHttpParams.java
httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java
httpcomponents/httpcore/trunk/src/docbkx/fundamentals.xml
Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/params/BasicHttpParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/params/BasicHttpParams.java?rev=741890&r1=741889&r2=741890&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/params/BasicHttpParams.java (original)
+++ httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/params/BasicHttpParams.java Sat Feb 7 13:26:13 2009
@@ -41,8 +41,8 @@
/**
* Default implementation of {@link HttpParams} interface.
* <p>
- * Please note methods of this class are not synchronized and therefore may
- * be threading unsafe.
+ * Please note access to the internal structures of this class is not
+ * synchronized and therefore this class may be thread-unsafe.
*
* @author <a href="mailto:oleg at ural.ru">Oleg Kalnichevski</a>
*
Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java?rev=741890&r1=741889&r2=741890&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java (original)
+++ httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java Sat Feb 7 13:26:13 2009
@@ -44,6 +44,9 @@
/**
* Default implementation of {@link HttpProcessor}.
+ * <p>
+ * Please note access to the internal structures of this class is not
+ * synchronized and therefore this class may be thread-unsafe.
*
* @author <a href="mailto:oleg at ural.ru">Oleg Kalnichevski</a>
* @author Andrea Selva
Modified: httpcomponents/httpcore/trunk/src/docbkx/fundamentals.xml
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/src/docbkx/fundamentals.xml?rev=741890&r1=741889&r2=741890&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/src/docbkx/fundamentals.xml (original)
+++ httpcomponents/httpcore/trunk/src/docbkx/fundamentals.xml Sat Feb 7 13:26:13 2009
@@ -865,6 +865,10 @@
<programlisting><![CDATA[
httpproc.process(response, context);
]]></programlisting>
+ <para>
+ Please note the <classname>BasicHttpProcessor</classname> class does not synchronize
+ access to its internal structures and therefore amy be thread-unsafe.
+ </para>
</section>
<section>
<title>HTTP context</title>
@@ -995,6 +999,10 @@
false
null
]]></programlisting>
+ <para>
+ Please note the <classname>BasicHttpParams</classname> class does not synchronize access to
+ its internal structures and therefore amy be thread-unsafe.
+ </para>
<section>
<title>HTTP parameter beans</title>
<para>