You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/11 03:42:34 UTC
[GitHub] [airflow] mik-laj opened a new pull request #12274: Fix test - TestImpersonation
mik-laj opened a new pull request #12274:
URL: https://github.com/apache/airflow/pull/12274
That test failed, and now I have the green "PASSED" text.
```
tests/core/test_impersonation_tests.py::TestImpersonationWithCustomPythonPath::test_impersonation_custom PASSED [100%]
===================================================================================== 1 passed, 4 deselected in 44.23s =====================================================================================
```
Thanks to @potiuk for creating the quarantine test list. This allowed me to see that the tests that had previously been only partially unstable. Now it was never successful.
https://github.com/apache/airflow/issues/10118
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12274: Fix test - TestImpersonation
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12274:
URL: https://github.com/apache/airflow/pull/12274#issuecomment-725438714
> Should we move it out of quarantine then ?
I don't know if this test is stable or not. For now, I would like it to continue to monitor its stability continues. I couldn't do that if this test didn't work. In next PR, I can try to fix it, but I need more information about its condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12274: Fix test - TestImpersonation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12274:
URL: https://github.com/apache/airflow/pull/12274#issuecomment-725570436
> I don't know if this test is stable or not. For now, I would like it to continue to monitor its stability continues. I couldn't do that if this test didn't work. In next PR, I can try to fix it, but I need more information about its condition.
Works for me :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12274: Fix test - TestImpersonation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12274:
URL: https://github.com/apache/airflow/pull/12274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org