You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2018/10/17 23:03:06 UTC
[2/3] kudu git commit: thrift operators: add more test coverage
thrift operators: add more test coverage
This is a follow-up to Adar's suggestions in
https://gerrit.cloudera.org/c/11693/.
Change-Id: Ifdba996a9c4e6e01f55c257bfd10fb3f74f0f894
Reviewed-on: http://gerrit.cloudera.org:8080/11713
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1e8ef0ea
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1e8ef0ea
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1e8ef0ea
Branch: refs/heads/master
Commit: 1e8ef0eac6d411a225bd3a4101a7e19346eb1048
Parents: 7607e23
Author: Dan Burkert <da...@apache.org>
Authored: Wed Oct 17 12:53:05 2018 -0700
Committer: Dan Burkert <da...@apache.org>
Committed: Wed Oct 17 23:02:28 2018 +0000
----------------------------------------------------------------------
src/kudu/sentry/thrift_operators-test.cc | 56 +++++++++++++++++----------
1 file changed, 36 insertions(+), 20 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/1e8ef0ea/src/kudu/sentry/thrift_operators-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/sentry/thrift_operators-test.cc b/src/kudu/sentry/thrift_operators-test.cc
index 4ef3873..d4aa070 100644
--- a/src/kudu/sentry/thrift_operators-test.cc
+++ b/src/kudu/sentry/thrift_operators-test.cc
@@ -65,32 +65,48 @@ TEST(ThriftOperatorsTest, TestOperatorLt) {
ASSERT_EQ(2, groups.size()) << groups;
// TSentryPrivilege::operator<
+ const string kServer = "server1";
+ const string kDatabase = "db1";
+
TSentryPrivilege db_priv;
- db_priv.__set_serverName("server1");
- db_priv.__set_dbName("db1");
+ db_priv.__set_serverName(kServer);
+ db_priv.__set_dbName(kDatabase);
- TSentryPrivilege tbl_priv;
- tbl_priv.__set_serverName("server1");
- tbl_priv.__set_dbName("db1");
- tbl_priv.__set_tableName("tbl1");
+ TSentryPrivilege tbl1_priv;
+ tbl1_priv.__set_serverName(kServer);
+ tbl1_priv.__set_dbName(kDatabase);
+ tbl1_priv.__set_tableName("tbl1");
- NO_FATALS(AssertCompareRequirements(db_priv, tbl_priv));
- set<TSentryPrivilege> privileges { db_priv, tbl_priv };
- ASSERT_EQ(2, privileges.size()) << privileges;
+ TSentryPrivilege tbl2_priv;
+ tbl2_priv.__set_serverName(kServer);
+ tbl2_priv.__set_dbName(kDatabase);
+ tbl2_priv.__set_tableName("tbl2");
+ NO_FATALS(AssertCompareRequirements(db_priv, tbl1_priv));
+ NO_FATALS(AssertCompareRequirements(db_priv, tbl2_priv));
+ NO_FATALS(AssertCompareRequirements(tbl1_priv, tbl2_priv));
+ set<TSentryPrivilege> privileges { db_priv, tbl1_priv, tbl2_priv };
+ ASSERT_EQ(3, privileges.size()) << privileges;
// TSentryAuthorizable::operator<
TSentryAuthorizable db_authorizable;
- db_authorizable.__set_server("server1");
- db_authorizable.__set_db("db1");
-
- TSentryAuthorizable tbl_authorizable;
- tbl_authorizable.__set_server("server1");
- tbl_authorizable.__set_db("db1");
- tbl_authorizable.__set_table("tbl1");
-
- NO_FATALS(AssertCompareRequirements(db_authorizable, tbl_authorizable));
- set<TSentryAuthorizable> authorizables { db_authorizable, tbl_authorizable };
- ASSERT_EQ(2, authorizables.size()) << authorizables;
+ db_authorizable.__set_server(kServer);
+ db_authorizable.__set_db(kDatabase);
+
+ TSentryAuthorizable tbl1_authorizable;
+ tbl1_authorizable.__set_server(kServer);
+ tbl1_authorizable.__set_db(kDatabase);
+ tbl1_authorizable.__set_table("tbl1");
+
+ TSentryAuthorizable tbl2_authorizable;
+ tbl2_authorizable.__set_server(kServer);
+ tbl2_authorizable.__set_db(kDatabase);
+ tbl2_authorizable.__set_table("tbl2");
+
+ NO_FATALS(AssertCompareRequirements(db_authorizable, tbl1_authorizable));
+ NO_FATALS(AssertCompareRequirements(db_authorizable, tbl2_authorizable));
+ NO_FATALS(AssertCompareRequirements(tbl1_authorizable, tbl2_authorizable));
+ set<TSentryAuthorizable> authorizables { db_authorizable, tbl1_authorizable, tbl2_authorizable };
+ ASSERT_EQ(3, authorizables.size()) << authorizables;
}
} // namespace sentry