You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/08/04 04:24:28 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1150: MINIFICPP-1611 Add #include in the patch

adamdebreceni commented on a change in pull request #1150:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1150#discussion_r682276097



##########
File path: cmake/BundledAwsSdkCpp.cmake
##########
@@ -16,7 +16,7 @@
 # under the License.
 
 function(use_bundled_libaws SOURCE_DIR BINARY_DIR)
-    set(PATCH_FILE "${SOURCE_DIR}/thirdparty/aws-sdk-cpp/core-wstr-fix.patch")
+    set(PATCH_FILE "${SOURCE_DIR}/thirdparty/aws-sdk-cpp/aws-sdk-cpp.patch")

Review comment:
       it would be better IMO, of the name of the patch file indicated its purpose (that it solves c++20 compilation problems)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org