You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/10/13 06:45:22 UTC
[kudu-CR] [client] robust handling of absent master address(es)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16589
Change subject: [client] robust handling of absent master address(es)
......................................................................
[client] robust handling of absent master address(es)
This patch updates Kudu C++ client with robust handling of the absence
of master addresses prior to connection attempt to a Kudu cluster.
Before to this patch, KuduClientBuilder::Build() would hang in
ConnectToCluster(). After this patch, KuduClientBuilder::Build()
instantly returns Status::InvalidArgument() if no master addresses
are provided.
This patch also contains a test for the new behavior.
Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-test.cc
2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/16589/1
--
To view, visit http://gerrit.cloudera.org:8080/16589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Gerrit-Change-Number: 16589
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client] robust handling of absent master address(es)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16589 )
Change subject: [client] robust handling of absent master address(es)
......................................................................
[client] robust handling of absent master address(es)
This patch updates Kudu C++ client with robust handling of the absence
of master addresses prior to connection attempt to a Kudu cluster.
Before to this patch, KuduClientBuilder::Build() would hang in
ConnectToCluster(). After this patch, KuduClientBuilder::Build()
instantly returns Status::InvalidArgument() if no master addresses
are provided.
This patch also contains a test for the new behavior.
Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Reviewed-on: http://gerrit.cloudera.org:8080/16589
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-test.cc
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Gerrit-Change-Number: 16589
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] robust handling of absent master address(es)
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16589 )
Change subject: [client] robust handling of absent master address(es)
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Gerrit-Change-Number: 16589
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 13 Oct 2020 16:20:53 +0000
Gerrit-HasComments: No
[kudu-CR] [client] robust handling of absent master address(es)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16589 )
Change subject: [client] robust handling of absent master address(es)
......................................................................
Patch Set 2:
Thank you for fast review, Grant!
--
To view, visit http://gerrit.cloudera.org:8080/16589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Gerrit-Change-Number: 16589
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 13 Oct 2020 16:18:55 +0000
Gerrit-HasComments: No
[kudu-CR] [client] robust handling of absent master address(es)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16589 )
Change subject: [client] robust handling of absent master address(es)
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Gerrit-Change-Number: 16589
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 13 Oct 2020 14:49:58 +0000
Gerrit-HasComments: No
[kudu-CR] [client] robust handling of absent master address(es)
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [client] robust handling of absent master address(es)
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4c7400d09298c01cd0b349cc2b9f481d1214f148
Gerrit-Change-Number: 16589
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)