[GitHub] [hadoop] jojochuang commented on a change in pull request #467: [HDFS-14208]fix bug that there is some a large number missingblocks after failove to active

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #467: [HDFS-14208]fix bug that there is some a large number missingblocks after failove to active
URL: https://github.com/apache/hadoop/pull/467#discussion_r315449101
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
 ##########
 @@ -2532,8 +2532,9 @@ public boolean processReport(final DatanodeID nodeID,
         return !node.hasStaleStorages();
       }
       if (context != null) {
-        if (!blockReportLeaseManager.checkLease(node, startTime,
-              context.getLeaseId())) {
+        if (!namesystem.isInStartupSafeMode()
 
 Review comment:
   I think this is a dup of HDFS-12914. In HDFS-12914, this part of code is moved to another place to fix the bug.
   
   This fix is essentially saying if namenode is in safe mode, don't check for lease.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org