You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/26 10:00:21 UTC

[GitHub] [flink] snuyanzin commented on a diff in pull request #18927: [FLINK-26390] Use try resourses for CliClient#executeFile

snuyanzin commented on code in PR #18927:
URL: https://github.com/apache/flink/pull/18927#discussion_r1005475075


##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java:
##########
@@ -702,14 +698,14 @@ private void closeTerminal() {
         }
     }
 
-    private LineReader createLineReader(Terminal terminal) {
+    private LineReader createLineReader(Terminal terminal, Completer completer) {

Review Comment:
   During rebase I realize that there was introduced a similar method with `boolean` withing this PR [1] a second arg telling if completer should be added or not... So this change is not actual anymore after that
   [1] https://github.com/apache/flink/pull/20182
   link to the method https://github.com/apache/flink/pull/20182/files#diff-d5511cf0b3c81a60ae476f8a36c37c723fd703eb2c44c556473cb0066502481aR681



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org