You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/01/22 20:31:59 UTC
[jira] Updated: (THRIFT-166) Java tests should be in
lib/java/test/...
[ https://issues.apache.org/jira/browse/THRIFT-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-166:
---------------------------------
Attachment: thrift-166.patch
Here's my shot at combining the java project into a single java dir. Everything compiles and the tests all pass. As a side effect, I solved the test classpath issue (THRIFT-221), so that fix will be rolled in with this commit.
Since the tests move, do I have to do something with the makefiles to keep make check working from the top level? I don't really know anything about make, so if someone else could chime in, it'd be super helpful.
> Java tests should be in lib/java/test/...
> -----------------------------------------
>
> Key: THRIFT-166
> URL: https://issues.apache.org/jira/browse/THRIFT-166
> Project: Thrift
> Issue Type: Test
> Components: Library (Java)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: thrift-166.patch
>
>
> It's confusing and inconvenient to have the code and tests in separate folders. If they were together, the build.xml could allow you to build and run the tests in one command without changing directories.
> Would anyone object to moving these tests into lib/java/test? At the same time, we could start doing proper packaging and JUnit naming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.