You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@juneau.apache.org by ja...@apache.org on 2026/09/13 13:16:55 UTC

(juneau) 17/29: Retire the .rm-table-scroll wrapper now that the views toolkit owns table-only horizontal scroll (TODO-445n).

This is an automated email from the ASF dual-hosted git repository.

jamesbognar pushed a commit to branch juneau-release-manager
in repository https://gitbox.apache.org/repos/asf/juneau.git

commit cf2da62bcb5ffa19d3907074a3ba1800863b799e
Author: James Bognar <ja...@apache.org>
AuthorDate: Wed Aug 26 10:10:42 2026 -0400

    Retire the .rm-table-scroll wrapper now that the views toolkit owns table-only horizontal scroll (TODO-445n).
    
    admin.ftlh and releases.ftlh each wrapped their pageTable/viewTable markup in a
    <div class="rm-table-scroll"> with its own overflow-x: auto, predating the toolkit having
    any scroll story of its own. Now that juneau-views.css owns table-only horizontal scroll
    (the flex .dt-layout-cell for DT2, the .juneau-view-table-scroll wrap for DT1), that outer
    wrapper is redundant and actively harmful: it sat between .jc-card and the paging-pill
    menu, clipping the menu (INV-2) and producing a second horizontal scrollbar alongside the
    toolkit's own. The CSS rule and both template usages are retired together rather than
    restyled; each panel's ViewTable wrapper now carries data-juneau-layout="wide" instead.
---
 src/main/resources/static/css/chrome.css   | 10 ++++------
 src/main/resources/templates/admin.ftlh    |  9 +++++----
 src/main/resources/templates/releases.ftlh | 11 +++++++----
 3 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/src/main/resources/static/css/chrome.css b/src/main/resources/static/css/chrome.css
index c0e98b27a0..6dbf511903 100644
--- a/src/main/resources/static/css/chrome.css
+++ b/src/main/resources/static/css/chrome.css
@@ -114,12 +114,10 @@
 
 .rm-table-search input { width: 200px; }
 
-/* Horizontal-scroll container so wide tables stay inside the card
-   instead of bleeding past its border on narrow viewports. */
-.rm-table-scroll {
-  overflow-x: auto;
-  -webkit-overflow-scrolling: touch;
-}
+/* TODO-445n: horizontal scroll is now owned by the toolkit (juneau-views.css — the flex .dt-layout-cell for
+   DT2, the .juneau-view-table-scroll wrap for DT1), so the .rm-table-scroll wrapper has been removed from
+   admin.ftlh / releases.ftlh. An outer overflow-x:auto here sat between .jc-card and the paging-pill menu and
+   clipped it (INV-2) / produced a second horizontal scrollbar. The rule is retired rather than restyled. */
 
 table.rm-table {
   width: 100%;
diff --git a/src/main/resources/templates/admin.ftlh b/src/main/resources/templates/admin.ftlh
index 8b8f174d55..0fba204ec6 100644
--- a/src/main/resources/templates/admin.ftlh
+++ b/src/main/resources/templates/admin.ftlh
@@ -26,10 +26,11 @@
              pre-serialized server-side and inserted as trusted markup: ?no_esc suppresses this .ftlh's HTML
              auto-escaping so the emitted [data-juneau-page]/<table data-juneau-view>/<script> markup is not
              double-escaped. juneau-pages.js hash-routes the tabs and lazy-inits each panel's DataTable on first
-             activation via juneau-views.js's initTable. -->
-        <div class="rm-table-scroll">
-            ${pageTable?no_esc}
-        </div>
+             activation via juneau-views.js's initTable.
+             TODO-445n: the toolkit now owns table-only horizontal scroll, so the old .rm-table-scroll wrapper is
+             removed — an outer overflow-x:auto here would clip the paging-pill menu (INV-2) and can produce two
+             horizontal scrollbars. Each panel's ViewTable wrapper carries data-juneau-layout="wide". -->
+        ${pageTable?no_esc}
     </div>
 </#macro>
 <#include "base.ftlh">
diff --git a/src/main/resources/templates/releases.ftlh b/src/main/resources/templates/releases.ftlh
index ae76387609..801f319ab3 100644
--- a/src/main/resources/templates/releases.ftlh
+++ b/src/main/resources/templates/releases.ftlh
@@ -25,10 +25,13 @@
         <#-- Rich-view toolkit table + JSON sidecar, pre-serialized server-side (ReleaseRest.page via
              ViewTable.of) and inserted as trusted markup: ?no_esc suppresses this .ftlh's HTML auto-escaping
              so the emitted <table data-juneau-view>/<script> markup is not double-escaped. juneau-views.js
-             hydrates it into a server-side DataTable + ribbon on DOMContentLoaded. -->
-        <div class="rm-table-scroll">
-            ${viewTable?no_esc}
-        </div>
+             hydrates it into a server-side DataTable + ribbon on DOMContentLoaded.
+             TODO-445n: the toolkit now owns table-only horizontal scroll (juneau-views.css / the flex
+             .dt-layout-cell), so the old .rm-table-scroll wrapper is removed — an outer overflow-x:auto here
+             would clip the paging-pill menu (INV-2) and can produce two horizontal scrollbars. The
+             ViewTable wrapper <div> now sits as a direct child of .jc-card and its data-juneau-layout="wide"
+             stamp widens the card to full content width. -->
+        ${viewTable?no_esc}
     </div>
 </#macro>
 <#include "base.ftlh">