You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/05/01 18:46:07 UTC

[commons-bcel] 04/08: Fix SpotBugs [ERROR] High: Found reliance on default encoding

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git

commit 94d31f8e85316329a13dd9a413ca284da502b09b
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun May 1 14:07:36 2022 -0400

    Fix SpotBugs [ERROR] High: Found reliance on default encoding
---
 src/main/java/org/apache/bcel/classfile/Signature.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/bcel/classfile/Signature.java b/src/main/java/org/apache/bcel/classfile/Signature.java
index a9157061..8dbda61a 100644
--- a/src/main/java/org/apache/bcel/classfile/Signature.java
+++ b/src/main/java/org/apache/bcel/classfile/Signature.java
@@ -21,6 +21,7 @@ import java.io.ByteArrayInputStream;
 import java.io.DataInput;
 import java.io.DataOutputStream;
 import java.io.IOException;
+import java.nio.charset.StandardCharsets;
 
 import org.apache.bcel.Const;
 
@@ -38,12 +39,12 @@ public final class Signature extends Attribute {
     private static final class MyByteArrayInputStream extends ByteArrayInputStream {
 
         MyByteArrayInputStream(final String data) {
-            super(data.getBytes());
+            super(data.getBytes(StandardCharsets.UTF_8));
         }
 
 
         String getData() {
-            return new String(buf);
+            return new String(buf, StandardCharsets.UTF_8);
         }