You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/16 15:40:26 UTC
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #36: feat: proemtheus fetcher draft
wu-sheng commented on a change in pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#discussion_r595292937
##########
File path: plugins/fetcher/prometheus/metric_family.go
##########
@@ -244,11 +248,10 @@ func getBoundary(metricType metricspb.MetricDescriptor_Type, labels labels.Label
func (mf *metricFamily) ToMetric() (*metricspb.Metric, int, int) {
timeseries := make([]*metricspb.TimeSeries, 0, len(mf.groups))
switch mf.mtype {
- // not supported currently
- // case metricspb.MetricDescriptor_GAUGE_DISTRIBUTION:
- // return nil
+ // only cumulative metrics will be processed here
Review comment:
I am not sure about this comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org