[GitHub] [couchdb] garrensmith commented on a change in pull request #3481: Validate ddoc uses couch_eval

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #3481:
URL: https://github.com/apache/couchdb/pull/3481#discussion_r604701498



##########
File path: src/couch_mrview/src/couch_mrview.erl
##########
@@ -203,22 +203,23 @@ validate(DbName, _IsDbPartitioned,  DDoc) ->
                 Msg = ["`", Bad, "` is not a supported reduce function."],
                 throw({invalid_design_doc, Msg});
             ({RedName, RedSrc}) ->
-                couch_query_servers:try_compile(Proc, reduce, RedName, RedSrc)
+                couch_eval:try_compile(Ctx, RedName, RedSrc)
         end, Reds)
     end,
     {ok, #mrst{
         language = Lang,
         views = Views
     }} = couch_mrview_util:ddoc_to_mrst(DbName, DDoc),
 
-    try Views =/= [] andalso couch_query_servers:get_os_process(Lang) of
+    try Views =/= [] andalso couch_eval:acquire_context(Lang) of

Review comment:
       I don't think so. I'm happy for that error to bubble up. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org