[GitHub] [cassandra] dcapwell commented on a diff in pull request #1993: When updating ThreadLocalRandom used the old sun.misc.Unsafe rather than jdk.internal.misc.Unsafe

[GitBox <gi...@apache.org>]

dcapwell commented on code in PR #1993:
URL: https://github.com/apache/cassandra/pull/1993#discussion_r1040173672


##########
.circleci/config-2_1.yml:
##########
@@ -1164,6 +1164,18 @@ j11_separate_jobs: &j11_separate_jobs
         requires:
           - start_j11_jvm_dtests_vnode_repeat
           - j11_build
+    - start_j11_simulator_dtests:

Review Comment:
   > But don't we need this also added in the pre-commit workflow, same as all other test suites?
   
   :sigh: this build is getting too complicated... ill add
   
   > we can skip j8 build with j11 runtime and directly go for j11 build with j17 
   
   for now, since we support 8/11 ill keep the build doing 8/11; when we drop 8 and add 17 we can switch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org