You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/04/22 01:17:36 UTC

Review Request 20539: Added rate limiting to Metrics endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20539/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995 
  3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8 

Diff: https://reviews.apache.org/r/20539/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 20539: Added rate limiting to Metrics endpoint.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20539/#review41005
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 21, 2014, 11:18 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20539/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 11:18 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995 
>   3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8 
> 
> Diff: https://reviews.apache.org/r/20539/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 20539: Added rate limiting to Metrics endpoint.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20539/#review40988
-----------------------------------------------------------


Patch looks great!

Reviews applied: [20539]

All tests passed.

- Mesos ReviewBot


On April 21, 2014, 11:18 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20539/
> -----------------------------------------------------------
> 
> (Updated April 21, 2014, 11:18 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995 
>   3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8 
> 
> Diff: https://reviews.apache.org/r/20539/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 20539: Added rate limiting to Metrics endpoint.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20539/
-----------------------------------------------------------

(Updated April 21, 2014, 4:18 p.m.)


Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995 
  3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8 

Diff: https://reviews.apache.org/r/20539/diff/


Testing
-------

make check


Thanks,

Dominic Hamon