[GitHub] [arrow] icexelloss commented on a diff in pull request #35364: GH-35363: [C++] Fix Substrait schema names and for segmented aggregation

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #35364:
URL: https://github.com/apache/arrow/pull/35364#discussion_r1180686957


##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -205,12 +205,17 @@ class DefaultExtensionProvider : public BaseExtensionProvider {
       ARROW_ASSIGN_OR_RAISE(auto aggregate, internal::ParseAggregateMeasure(
                                                 agg_measure, ext_set, conv_opts,
                                                 /*is_hash=*/!keys.empty(), input_schema));
+      aggregate.name = aggregate.function;
+      for (auto& field_ref : aggregate.target) {
+        ARROW_ASSIGN_OR_RAISE(auto field, field_ref.GetOne(*input_schema));
+        aggregate.name += "_" + field->name();

Review Comment:
   Does this replicate the logic for non-segmented aggregation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org