You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2012/10/16 02:48:01 UTC
Re: svn commit: r1398389 - in /subversion/trunk/subversion:
include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/
tests/libsvn_wc/
philip@apache.org wrote on Mon, Oct 15, 2012 at 17:09:02 -0000:
> Author: philip
> Date: Mon Oct 15 17:09:01 2012
> New Revision: 1398389
>
> URL: http://svn.apache.org/viewvc?rev=1398389&view=rev
> Log:
> Enable SQLite exclusive locking for the command line client as this is
>
> + "### Section for configuring working copies." NL
> + "[working-copy]" NL
> + "### Set to true to enable exclusive SQLite locking. Some clients" NL
> + "### may not support exclusive locking." NL
> + "# exclusive-locking = false" NL;
Change the comment to describe the failure mode for such clients?
(whether they would ignore the setting or raise an error)
Re: svn commit: r1398389 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/ tests/libsvn_wc/
Posted by Philip Martin <ph...@wandisco.com>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:
> philip@apache.org wrote on Mon, Oct 15, 2012 at 17:09:02 -0000:
>> Author: philip
>> Date: Mon Oct 15 17:09:01 2012
>> New Revision: 1398389
>>
>> URL: http://svn.apache.org/viewvc?rev=1398389&view=rev
>> Log:
>> Enable SQLite exclusive locking for the command line client as this is
>>
>> + "### Section for configuring working copies." NL
>> + "[working-copy]" NL
>> + "### Set to true to enable exclusive SQLite locking. Some clients" NL
>> + "### may not support exclusive locking." NL
>> + "# exclusive-locking = false" NL;
>
> Change the comment to describe the failure mode for such clients?
> (whether they would ignore the setting or raise an error)
I can tell you that the wc function will return an "already locked"
error after a timeout but I have no idea how a third party client will
handle that and in what way it will be visible to the user.
--
Join us this October at Subversion Live 2012
http://www.wandisco.com/svn-live-2012
Re: svn commit: r1398389 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/ tests/libsvn_wc/
Posted by Philip Martin <ph...@wandisco.com>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:
> philip@apache.org wrote on Mon, Oct 15, 2012 at 17:09:02 -0000:
>> Author: philip
>> Date: Mon Oct 15 17:09:01 2012
>> New Revision: 1398389
>>
>> URL: http://svn.apache.org/viewvc?rev=1398389&view=rev
>> Log:
>> Enable SQLite exclusive locking for the command line client as this is
>>
>> + "### Section for configuring working copies." NL
>> + "[working-copy]" NL
>> + "### Set to true to enable exclusive SQLite locking. Some clients" NL
>> + "### may not support exclusive locking." NL
>> + "# exclusive-locking = false" NL;
>
> Change the comment to describe the failure mode for such clients?
> (whether they would ignore the setting or raise an error)
I can tell you that the wc function will return an "already locked"
error after a timeout but I have no idea how a third party client will
handle that and in what way it will be visible to the user.
--
Join us this October at Subversion Live 2012
http://www.wandisco.com/svn-live-2012
Re: svn commit: r1398389 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_subr/ libsvn_wc/ svn/ tests/libsvn_wc/
Posted by Julian Foad <ju...@btopenworld.com>.
> URL: http://svn.apache.org/viewvc?rev=1398389&view=rev
> Log:
> Enable SQLite exclusive locking for the command line client as this is
[...]
This deprecates svn_client_config_create() and adds
/** Initialize a client context.
* Set @a *ctx to a client context object, allocated in @a pool, that
* represents a particular instance of an svn client.
*
* In order to avoid backwards compatibility problems, clients must
* use this function to initialize and allocate the
* #svn_client_ctx_t structure rather than doing so themselves, as
* the size of this structure may change in the future.
*
* The current implementation never returns error, but callers should
* still check for error, for compatibility with future versions.
*
* @since New in 1.8.
*/
svn_error_t *
svn_client_create_context2(svn_client_ctx_t **ctx,
apr_hash_t *cfg_hash,
apr_pool_t *pool);
but it doesn't seem to mention what the new 'cfg_hash' parameter is for.
- Julian