You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/27 11:12:17 UTC
[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL
Compatible Null Handling
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-408388509
> Aggrgator/BufferAggregator - Added a new method boolean isNull() which returns false by default. aggregators that support nullability can choose to override this and return true if the aggregated result is null.
This should be moved to #5278.
Removed it from this PR.
> Changes to Druid build-in SQL layer
NULL and empty strings are treated differently.
I haven't checked through the whole patch, so am wondering this is true only for the SQL layer or the entire Druid query processing system.
it applies to whole query processing. updated PR description to add a note.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org