You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Yongjun Zhang (JIRA)" <ji...@apache.org> on 2014/06/20 19:37:25 UTC
[jira] [Created] (HDFS-6578) add toString method to DatanodeStorage
etc for easier debugging
Yongjun Zhang created HDFS-6578:
-----------------------------------
Summary: add toString method to DatanodeStorage etc for easier debugging
Key: HDFS-6578
URL: https://issues.apache.org/jira/browse/HDFS-6578
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
It seems to be nice to add a toString() method for DatanodeStorage class, so we can print out its key info easier while doing debuging.
Another thing is, in the end of BlockManager#processReport, there is the following message,
{code}
blockLog.info("BLOCK* processReport: from storage " + storage.getStorageID()
+ " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
+ ", processing time: " + (endTime - startTime) + " msecs");
return !node.hasStaleStorages();
{code}
We could add node.hasStaleStorages() to the log, and possibly replace storage.getSorateID() with the suggested storage.toString().
Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)