[GitHub] [tvm] DzAvril commented on a diff in pull request #10801: [BYOC][ACL] Fix list is not supported as an input node

[GitBox <gi...@apache.org>]

DzAvril commented on code in PR #10801:
URL: https://github.com/apache/tvm/pull/10801#discussion_r849277323


##########
python/tvm/relay/op/contrib/arm_compute_lib.py:
##########
@@ -52,11 +56,15 @@ def partition_for_arm_compute_lib(mod, params=None, **opts):
         The module to run passes on.
     params : Optional[Dict[str, NDArray]]
         Constant input parameters.
+    offload_concat : Optional[bool]
+        Whether offload concatenate
 
     Returns
     -------
     ret : annotated and partitioned module.
     """
+    global offload_concat_

Review Comment:
   Updated, please review. I'm not sure it is what you want because it seems a little weird since `arm_compute_lib_pattern_table` aims to register fusing patterns for ops and registering op attr is out of it.
   BTW, this commit triggered a `Sanity Check` error:
   > python/tvm/relay/op/contrib/arm_compute_lib.py:274: [W0612(unused-variable), arm_compute_lib_pattern_table.concatenate] Unused variable 'concatenate'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org