[GitHub] [spark] LuciferYang commented on a diff in pull request #37610: [SPARK-38888][BUILD][CORE][YARN][DOCS] Add `RocksDB` support for shuffle state store

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #37610:
URL: https://github.com/apache/spark/pull/37610#discussion_r952100161


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -802,6 +802,7 @@ public void close() {
     if (db != null) {
       try {
         db.close();
+        db = null;

Review Comment:
   hmm... should we fix this issue in this pr? I think it looks more like a bug fix, so should we use an independent jira to tracking it? 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org