[GitHub] [incubator-doris] imay commented on a change in pull request #3277: [Doris on es] Support compound_and predicate push down to Elasticsearch

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3277: [Doris on es] Support compound_and predicate push down to Elasticsearch
URL: https://github.com/apache/incubator-doris/pull/3277#discussion_r405245915
 
 

 ##########
 File path: be/src/exec/es/es_predicate.h
 ##########
 @@ -85,6 +86,15 @@ struct ExtPredicate {
     TExprNodeType::type node_type;
 };
 
+// this used for placeholder for compound_and
+struct ExtCompAndPredicates : public ExtPredicate {
+    ExtCompAndPredicates(std::vector<EsPredicate*> conjuncts) : ExtPredicate(TExprNodeType::COMPOUND_PRED), op(TExprOpcode::COMPOUND_AND), conjuncts(conjuncts) {
 
 Review comment:
   ```suggestion
       ExtCompAndPredicates(const std::vector<EsPredicate*>& conjuncts) : ExtPredicate(TExprNodeType::COMPOUND_PRED), op(TExprOpcode::COMPOUND_AND), conjuncts(conjuncts) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org