You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Chris Morgan (JIRA)" <ji...@apache.org> on 2011/02/08 20:10:57 UTC

[jira] Created: (THRIFT-1056) python tests invoked by 'make check' appear broken

python tests invoked by 'make check' appear broken
--------------------------------------------------

                 Key: THRIFT-1056
                 URL: https://issues.apache.org/jira/browse/THRIFT-1056
             Project: Thrift
          Issue Type: Bug
          Components: Build Process
    Affects Versions: 0.7
            Reporter: Chris Morgan


Running 'make check' results in errors:

{code}
------------------------------------------
[...truncated 2420 lines...]
----------------------------------------------------------------------
Traceback (most recent call last):
 File "./TestClient.py", line 70, in setUp
   self.transport.open()
 File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TTransport.py", line 150, in open
   return self.__trans.open()
 File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TSocket.py", line 90, in open
   raise TTransportException(type=TTransportException.NOT_OPEN, message=message)
TTransportException: Could not connect to localhost:9090
...
{code}


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (THRIFT-1056) python tests invoked by 'make check' appear broken

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1056.
---------------------------------

    Resolution: Fixed
      Assignee: Roger Meier

Thanks Chris!

committed.

> python tests invoked by 'make check' appear broken
> --------------------------------------------------
>
>                 Key: THRIFT-1056
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1056
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>    Affects Versions: 0.7
>            Reporter: Chris Morgan
>            Assignee: Roger Meier
>         Attachments: fix_testserver_py.patch
>
>
> Running 'make check' results in errors:
> {code}
> ------------------------------------------
> [...truncated 2420 lines...]
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "./TestClient.py", line 70, in setUp
>    self.transport.open()
>  File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TTransport.py", line 150, in open
>    return self.__trans.open()
>  File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TSocket.py", line 90, in open
>    raise TTransportException(type=TTransportException.NOT_OPEN, message=message)
> TTransportException: Could not connect to localhost:9090
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1056) python tests invoked by 'make check' appear broken

Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Morgan updated THRIFT-1056:
---------------------------------

    Patch Info: [Patch Available]

> python tests invoked by 'make check' appear broken
> --------------------------------------------------
>
>                 Key: THRIFT-1056
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1056
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>    Affects Versions: 0.7
>            Reporter: Chris Morgan
>         Attachments: fix_testserver_py.patch
>
>
> Running 'make check' results in errors:
> {code}
> ------------------------------------------
> [...truncated 2420 lines...]
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "./TestClient.py", line 70, in setUp
>    self.transport.open()
>  File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TTransport.py", line 150, in open
>    return self.__trans.open()
>  File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TSocket.py", line 90, in open
>    raise TTransportException(type=TTransportException.NOT_OPEN, message=message)
> TTransportException: Could not connect to localhost:9090
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1056) python tests invoked by 'make check' appear broken

Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Morgan updated THRIFT-1056:
---------------------------------

    Attachment: fix_testserver_py.patch

TestServer.py was creating the TServerSocket() with a single parameter, the port number 9090. 

TServerSocket was altered to look like:

class TServerSocket(TSocketBase, TServerTransportBase):
  """Socket implementation of TServerTransport base."""

  def __init__(self, host=None, port=9090, unix_socket=None):

so the call in TestServer.py was passing 9090 as the 'host' argument. This was a side effect of http://svn.apache.org/viewvc?view=revision&revision=1063806 which changed the TServerSocket constructor.

Fix the issue by adding a host value of "None" to the constructor which shifts the port to the port argument of the constructor.

Tests run better after the change.


> python tests invoked by 'make check' appear broken
> --------------------------------------------------
>
>                 Key: THRIFT-1056
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1056
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>    Affects Versions: 0.7
>            Reporter: Chris Morgan
>         Attachments: fix_testserver_py.patch
>
>
> Running 'make check' results in errors:
> {code}
> ------------------------------------------
> [...truncated 2420 lines...]
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>  File "./TestClient.py", line 70, in setUp
>    self.transport.open()
>  File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TTransport.py", line 150, in open
>    return self.__trans.open()
>  File "../../lib/py/build/lib.linux-x86_64-2.6/thrift/transport/TSocket.py", line 90, in open
>    raise TTransportException(type=TTransportException.NOT_OPEN, message=message)
> TTransportException: Could not connect to localhost:9090
> ...
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira