You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/10/01 21:07:30 UTC

Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26242/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

Also, added a log line for executor launch to log its work directory.


Diffs
-----

  src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 

Diff: https://reviews.apache.org/r/26242/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26242/#review55760
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 1, 2014, 7:07 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26242/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 7:07 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Also, added a log line for executor launch to log its work directory.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 
> 
> Diff: https://reviews.apache.org/r/26242/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 26242: Changed checkpoint logging from LOG(INFO) to VLOG(1).

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26242/#review55126
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26242]

All tests passed.

- Mesos ReviewBot


On Oct. 1, 2014, 7:07 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26242/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 7:07 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Also, added a log line for executor launch to log its work directory.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 
> 
> Diff: https://reviews.apache.org/r/26242/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>