You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by cw...@apache.org on 2020/02/15 11:08:53 UTC

[druid] branch master updated: Remove references to Docker Machine (#9366)

This is an automated email from the ASF dual-hosted git repository.

cwylie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d52edd  Remove references to Docker Machine (#9366)
6d52edd is described below

commit 6d52edddab2fdc5e9ca897b576e83d0a95c5bccf
Author: sthetland <st...@imply.io>
AuthorDate: Sat Feb 15 03:08:43 2020 -0800

    Remove references to Docker Machine (#9366)
    
    * Remove references to Docker Machine
    
    Removing a broken link to an obsolete repo.
    
    While at it, removing references to Docker Machine, which was obsolete as of Docker v1.12 (avail. 2016). This version introduced Docker as native MacOS and Windows apps.
    
    * Update README.md
    
    Wording nit.
---
 integration-tests/README.md | 36 +++++++-----------------------------
 1 file changed, 7 insertions(+), 29 deletions(-)

diff --git a/integration-tests/README.md b/integration-tests/README.md
index 93ccfe5..47f7eb7 100644
--- a/integration-tests/README.md
+++ b/integration-tests/README.md
@@ -34,40 +34,18 @@ describing the cluster.
 Integration Testing Using Docker 
 -------------------
 
-For running integration tests using docker there are 2 approaches.
-If your platform supports docker natively, you can simply set `DOCKER_IP`
-environment variable to localhost and skip to [Running tests](#running-tests) section. Ensure that you have
-at least 4GiB of memory allocated to the docker engine (This can be set under Preferences > Advanced).
+Before starting, if you don't already have docker on your machine, install it as described on 
+[Docker installation instructions](https://docs.docker.com/install/). Ensure that you 
+have at least 4GB of memory allocated to the docker engine. (You can verify it 
+under Preferences > Advanced.)
 
-```
-export DOCKER_IP=127.0.0.1
-```
-
-The other approach is to use separate virtual machine to run docker
-containers with help of `docker-machine` tool.
-
-## Installing Docker Machine
-
-Please refer to instructions at [https://github.com/druid-io/docker-druid/blob/master/docker-install.md](https://github.com/druid-io/docker-druid/blob/master/docker-install.md).
-
-## Creating the Docker VM
+Also set the `DOCKER_IP`
+environment variable to localhost on your system, as follows:
 
-Create a new VM for integration tests with at least 6GB of memory.
-
-```
-docker-machine create --driver virtualbox --virtualbox-memory 6000 integration
 ```
-
-Set the docker environment:
-
-```
-eval "$(docker-machine env integration)"
-export DOCKER_IP=$(docker-machine ip integration)
-export DOCKER_MACHINE_IP=$(docker-machine inspect integration | jq -r .Driver[\"HostOnlyCIDR\"])
+export DOCKER_IP=127.0.0.1
 ```
 
-The final command uses the `jq` tool to read the Driver->HostOnlyCIDR field from the `docker-machine inspect` output. If you don't wish to install `jq`, you will need to set DOCKER_MACHINE_IP manually.
-
 ## Running tests
 
 To run all the tests using docker and mvn run the following command:


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org