You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Saqeeb Shaikh <sa...@freestoneinfotech.com> on 2019/09/05 12:36:51 UTC
Review Request 71439: Qualified name of term not being updated when
term name is updated.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3391
https://issues.apache.org/jira/browse/ATLAS-3391
Repository: atlas
Description
-------
When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
This patch also includes required UI side changes.
Diffs
-----
dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
Diff: https://reviews.apache.org/r/71439/diff/1/
Testing
-------
Manually tested by updating term and searching using the updated term qualified name.
Thanks,
Saqeeb Shaikh
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/#review217635
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Line 413 (original)
<https://reviews.apache.org/r/71439/#comment304925>
- instead of caller (i.e. UI in this case) to recompute the qualifiedName, I would suggest to recompute in GlossaryService.updateTerm(). Please refer to createTerm() for the details of computing qualifiedName.
- similar updates be needed to handle rename of category as well
- Madhan Neethiraj
On Sept. 6, 2019, 9:36 a.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71439/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2019, 9:36 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3391
> https://issues.apache.org/jira/browse/ATLAS-3391
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
>
> This patch also includes required UI side changes.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
>
>
> Diff: https://reviews.apache.org/r/71439/diff/2/
>
>
> Testing
> -------
>
> Manually tested by updating term and searching using the updated term qualified name.
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
> On Sept. 30, 2019, 4:36 a.m., Madhan Neethiraj wrote:
> > Server side changes look good. However, are the GUI changes necessary (now that 'qualifiedName' update is handled at the server side)?
Thanks for your feedback Madhan.
When we search using a term, the UI stores this term name in memory so that when we come back to the search tab we again get the same result. The UI change made in this patch is for handling the scenario when we search on a term and then update name of the same term.
- Saqeeb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/#review217980
-----------------------------------------------------------
On Sept. 23, 2019, 6:54 a.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71439/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2019, 6:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3391
> https://issues.apache.org/jira/browse/ATLAS-3391
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
>
> This patch also includes required UI side changes.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 85b1a96d
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
>
>
> Diff: https://reviews.apache.org/r/71439/diff/4/
>
>
> Testing
> -------
>
> Manually tested by updating term and searching using the updated term qualified name.
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/#review217980
-----------------------------------------------------------
Ship it!
Server side changes look good. However, are the GUI changes necessary (now that 'qualifiedName' update is handled at the server side)?
- Madhan Neethiraj
On Sept. 23, 2019, 6:54 a.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71439/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2019, 6:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3391
> https://issues.apache.org/jira/browse/ATLAS-3391
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
>
> This patch also includes required UI side changes.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 85b1a96d
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
>
>
> Diff: https://reviews.apache.org/r/71439/diff/4/
>
>
> Testing
> -------
>
> Manually tested by updating term and searching using the updated term qualified name.
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/
-----------------------------------------------------------
(Updated Sept. 23, 2019, 6:54 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Handled updating qualified name of glossary when glossary name is updated.
Bugs: ATLAS-3391
https://issues.apache.org/jira/browse/ATLAS-3391
Repository: atlas
Description
-------
When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
This patch also includes required UI side changes.
Diffs (updated)
-----
dashboardv2/public/js/utils/CommonViewFunction.js 85b1a96d
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
Diff: https://reviews.apache.org/r/71439/diff/4/
Changes: https://reviews.apache.org/r/71439/diff/3-4/
Testing
-------
Manually tested by updating term and searching using the updated term qualified name.
Thanks,
Saqeeb Shaikh
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/#review217651
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 9, 2019, 1:03 p.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71439/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2019, 1:03 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3391
> https://issues.apache.org/jira/browse/ATLAS-3391
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
>
> This patch also includes required UI side changes.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 85b1a96d
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
>
>
> Diff: https://reviews.apache.org/r/71439/diff/3/
>
>
> Testing
> -------
>
> Manually tested by updating term and searching using the updated term qualified name.
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/
-----------------------------------------------------------
(Updated Sept. 9, 2019, 1:03 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed review comments
Bugs: ATLAS-3391
https://issues.apache.org/jira/browse/ATLAS-3391
Repository: atlas
Description
-------
When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
This patch also includes required UI side changes.
Diffs (updated)
-----
dashboardv2/public/js/utils/CommonViewFunction.js 85b1a96d
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
Diff: https://reviews.apache.org/r/71439/diff/3/
Changes: https://reviews.apache.org/r/71439/diff/2-3/
Testing
-------
Manually tested by updating term and searching using the updated term qualified name.
Thanks,
Saqeeb Shaikh
Re: Review Request 71439: ATLAS-3391 : Qualified name of term not
being updated when term name is updated.
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/
-----------------------------------------------------------
(Updated Sept. 6, 2019, 9:36 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Summary (updated)
-----------------
ATLAS-3391 : Qualified name of term not being updated when term name is updated.
Bugs: ATLAS-3391
https://issues.apache.org/jira/browse/ATLAS-3391
Repository: atlas
Description
-------
When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
This patch also includes required UI side changes.
Diffs
-----
dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
Diff: https://reviews.apache.org/r/71439/diff/2/
Testing
-------
Manually tested by updating term and searching using the updated term qualified name.
Thanks,
Saqeeb Shaikh
Re: Review Request 71439: Qualified name of term not being updated
when term name is updated.
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/
-----------------------------------------------------------
(Updated Sept. 6, 2019, 9:32 a.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Adressed review comments.
Bugs: ATLAS-3391
https://issues.apache.org/jira/browse/ATLAS-3391
Repository: atlas
Description
-------
When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
This patch also includes required UI side changes.
Diffs (updated)
-----
dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
Diff: https://reviews.apache.org/r/71439/diff/2/
Changes: https://reviews.apache.org/r/71439/diff/1-2/
Testing
-------
Manually tested by updating term and searching using the updated term qualified name.
Thanks,
Saqeeb Shaikh
Re: Review Request 71439: Qualified name of term not being updated
when term name is updated.
Posted by Saqeeb Shaikh <sa...@freestoneinfotech.com>.
> On Sept. 5, 2019, 6:16 p.m., Ashutosh Mestry wrote:
> > dashboardv2/public/js/utils/CommonViewFunction.js
> > Lines 758 (patched)
> > <https://reviews.apache.org/r/71439/diff/1/?file=2164049#file2164049line758>
> >
> > Is there any central logic for creating qualifiedNames?
Extracted the logic into a function (getUpdatedQualifiedName()).
- Saqeeb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/#review217595
-----------------------------------------------------------
On Sept. 6, 2019, 9:32 a.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71439/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2019, 9:32 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3391
> https://issues.apache.org/jira/browse/ATLAS-3391
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
>
> This patch also includes required UI side changes.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
>
>
> Diff: https://reviews.apache.org/r/71439/diff/2/
>
>
> Testing
> -------
>
> Manually tested by updating term and searching using the updated term qualified name.
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>
Re: Review Request 71439: Qualified name of term not being updated
when term name is updated.
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71439/#review217595
-----------------------------------------------------------
dashboardv2/public/js/utils/CommonViewFunction.js
Line 19 (original), 19 (patched)
<https://reviews.apache.org/r/71439/#comment304866>
Get rid of trailing ','.
dashboardv2/public/js/utils/CommonViewFunction.js
Lines 758 (patched)
<https://reviews.apache.org/r/71439/#comment304867>
Is there any central logic for creating qualifiedNames?
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Line 413 (original), 413 (patched)
<https://reviews.apache.org/r/71439/#comment304865>
Remove commented code.
- Ashutosh Mestry
On Sept. 5, 2019, 12:36 p.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71439/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2019, 12:36 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3391
> https://issues.apache.org/jira/browse/ATLAS-3391
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When a term (with name T) belonging to glossary (G) is updated to (T1), its qualified name does not gets updated. Search by term displays qualified names of the terms, hence old name is seen there. The handling for updating qualified name was present but since we were copying the qualified name from the DB object, the handling code never got trigerred.
>
> This patch also includes required UI side changes.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 9cea1b8
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9229d2d
>
>
> Diff: https://reviews.apache.org/r/71439/diff/1/
>
>
> Testing
> -------
>
> Manually tested by updating term and searching using the updated term qualified name.
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>