You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by am...@apache.org on 2026/06/24 12:47:01 UTC
(superset) branch fix/106389-cell-selection created (now bae3a1cb902)
This is an automated email from the ASF dual-hosted git repository.
amaannawab923 pushed a change to branch fix/106389-cell-selection
in repository https://gitbox.apache.org/repos/asf/superset.git
at bae3a1cb902 fix(plugin-chart-ag-grid-table): select cell on click instead of its text (#106389)
This branch includes the following new commits:
new bae3a1cb902 fix(plugin-chart-ag-grid-table): select cell on click instead of its text (#106389)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: fix(plugin-chart-ag-grid-table): select cell on click instead of its text (#106389)
Posted by am...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
amaannawab923 pushed a commit to branch fix/106389-cell-selection
in repository https://gitbox.apache.org/repos/asf/superset.git
commit bae3a1cb9023a3c39da1ca5c2c9facab70129879
Author: amaannawab923 <am...@gmail.com>
AuthorDate: Wed Jun 24 18:16:50 2026 +0530
fix(plugin-chart-ag-grid-table): select cell on click instead of its text (#106389)
enableCellTextSelection forced browser text selection when clicking a cell,
which suppressed AG Grid's cell-focus (cell selection) behavior. Disable it so a
click selects/focuses the cell as users expect.
Note: full multi-cell range selection requires AG Grid Enterprise and is not
available in the Community build, so the multi-cell part of the acceptance
criteria cannot be satisfied without an Enterprise license.
---
.../plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
index ebb66b0db28..25a3ae8f660 100644
--- a/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
+++ b/superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
@@ -520,7 +520,12 @@ const AgGridDataTable: FunctionComponent<AgGridTableProps> = memo(
initialState={gridInitialState}
maintainColumnOrder
suppressAggFuncInHeader
- enableCellTextSelection
+ // Clicking a cell should select (focus) the cell rather than select
+ // its text content (#106389). enableCellTextSelection forces browser
+ // text selection on click, which suppresses the cell-focus behavior.
+ // Full multi-cell range selection requires AG Grid Enterprise and is
+ // not available in the Community build used here.
+ enableCellTextSelection={false}
quickFilterText={serverPagination ? '' : quickFilterText}
suppressMovableColumns={!allowRearrangeColumns}
pagination={pagination}