You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/06/22 05:26:07 UTC
[GitHub] storm pull request #2171: (1.x) STORM-2555 handle impersonation properly for...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2171
(1.x) STORM-2555 handle impersonation properly for HBase delegation token
Please refer [STORM-2555](http://issues.apache.org/jira/browse/STORM-2555) for more details.
There had been code block for handling impersonation, but actually it didn't work.
Please review and comment, thanks in advance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2555-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2171
----
commit c968739c4ce603bb5d84666797b763cffd6c2377
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-06-15T02:12:02Z
STORM-2555 handle impersonation properly for HBase delegation token
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2171: (1.x) STORM-2555 handle impersonation properly for HBase ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2171
@arunmahadevan
Thanks for reviewing. I addressed your review comment.
Could you please take a look again? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2171: (1.x) STORM-2555 handle impersonation properly for HBase ...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2171
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2171: (1.x) STORM-2555 handle impersonation properly for...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2171#discussion_r123425272
--- Diff: external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java ---
@@ -67,7 +67,7 @@ public static UserProvider login(Map conf, Configuration hbaseConfig) throws IOE
}
return legacyProvider;
} else {
- return UserProvider.instantiate(hbaseConfig);
+ return null;
--- End diff --
I think I just completely missed HBaseMapState. Will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2171: (1.x) STORM-2555 handle impersonation properly for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2171
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2171: (1.x) STORM-2555 handle impersonation properly for...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2171#discussion_r123424946
--- Diff: external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java ---
@@ -67,7 +67,7 @@ public static UserProvider login(Map conf, Configuration hbaseConfig) throws IOE
}
return legacyProvider;
} else {
- return UserProvider.instantiate(hbaseConfig);
+ return null;
--- End diff --
Wont this throw NPE in the caller ?
check: https://github.com/apache/storm/blob/1.x-branch/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseMapState.java#L84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2171: (1.x) STORM-2555 handle impersonation properly for...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2171#discussion_r123429439
--- Diff: external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java ---
@@ -67,7 +67,7 @@ public static UserProvider login(Map conf, Configuration hbaseConfig) throws IOE
}
return legacyProvider;
} else {
- return UserProvider.instantiate(hbaseConfig);
+ return null;
--- End diff --
Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---