You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Marco Collovati <mc...@gmail.com> on 2017/05/01 11:38:59 UTC
Re: [VOTE] Release Apache Camel 2.19.0 (Attempt #2)
-1
Got an issue with DefaultComponent change on doStart method:
the check for camel context is done via getter
```ObjectHelper.notNull(getCamelContext(), "camelContext");```
but the following logic access the `camelContext` field directly.
This leads to NPE when extending DefaultComponent as a decorator for
other components.
Maybe this is more an issue on my code but I think the camelContext
check should be consistent with the following code.
On 30/04/2017 17:32, Gregor Zurowski wrote:
> Hi Everyone:
>
> This is the second vote to release Apache Camel 2.19.0, a new minor
> release with over 670 new features, improvements and bug fixes. A
> summary of the changes is available in the Camel wiki [1]. The first
> vote was cancelled due to multiple issues found while testing the
> first release candidate [1].
>
> Release notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12337871&projectId=12311211
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachecamel-1075/
>
> Tarballs: https://repository.apache.org/content/repositories/orgapachecamel-1075/org/apache/camel/apache-camel/2.19.0/
>
> Tag: https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=0ae39c5223d4e58e1f3063e7e5f071be0e258e97
>
> Please test this release candidate and cast your vote.
> [ ] +1 Release the binary as Apache Camel 2.19.0
> [ ] -1 Veto the release (provide specific comments)
>
> The vote is open for at least 72 hours.
>
> Due to the many changes introduced with this new release, it would be
> beneficial if we could get as many Camel riders involved in testing
> this release candidate as possible.
>
> Thanks,
> Gregor
>
> [1] https://cwiki.apache.org/confluence/display/CAMEL/Camel+2.19+Release
> [2] http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
>
Re: [VOTE] Release Apache Camel 2.19.0 (Attempt #2)
Posted by Claus Ibsen <cl...@gmail.com>.
On Tue, May 2, 2017 at 2:48 PM, Marco Collovati <mc...@gmail.com> wrote:
> Ok, sorry.
>
Oh dont be, we value all feedback. What you have discovered is likely
something we can improve for the next release. You are welcome to dive
in the source code, and and we love contributions. PRs is welcome
http://camel.apache.org/contributing
And if you find that field vs getter is in more places then maybe post
on @dev so the other devs can take notice and we can take a bigger
look.
However if its only a few spots then a PR and a JIRA is fine IMHO.
> BTW, aside from my previous problem, I tested RC on some production project
> involving camel-jms, camel-cxf, camel-mail and
> camel-api-component-maven-plugin and all is working fine.
>
Ah great thanks for testing and the feedback.
>
>
> On 02/05/2017 20:39, Claus Ibsen wrote:
>>
>> Hi Marco
>>
>> You should likely post a new thread with more details what you are trying
>> to do.
>> Your use-case is not normal and therefore not considering a blocker.
>> There are likely other places where such check in doStart is checking
>> the field also.
>>
>> The RC testing is more focusing on existing applications being
>> migrated or ported to this versions to find regressions etc.
>>
>>
>> On Mon, May 1, 2017 at 7:38 AM, Marco Collovati <mc...@gmail.com>
>> wrote:
>>>
>>> -1
>>>
>>> Got an issue with DefaultComponent change on doStart method:
>>> the check for camel context is done via getter
>>> ```ObjectHelper.notNull(getCamelContext(), "camelContext");```
>>> but the following logic access the `camelContext` field directly.
>>>
>>> This leads to NPE when extending DefaultComponent as a decorator for
>>> other
>>> components.
>>>
>>> Maybe this is more an issue on my code but I think the camelContext check
>>> should be consistent with the following code.
>>>
>>>
>>>
>>> On 30/04/2017 17:32, Gregor Zurowski wrote:
>>>>
>>>>
>>>> Hi Everyone:
>>>>
>>>> This is the second vote to release Apache Camel 2.19.0, a new minor
>>>> release with over 670 new features, improvements and bug fixes. A
>>>> summary of the changes is available in the Camel wiki [1]. The first
>>>> vote was cancelled due to multiple issues found while testing the
>>>> first release candidate [1].
>>>>
>>>> Release notes:
>>>>
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12337871&projectId=12311211
>>>>
>>>> Staging repository:
>>>> https://repository.apache.org/content/repositories/orgapachecamel-1075/
>>>>
>>>> Tarballs:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachecamel-1075/org/apache/camel/apache-camel/2.19.0/
>>>>
>>>> Tag:
>>>>
>>>> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=0ae39c5223d4e58e1f3063e7e5f071be0e258e97
>>>>
>>>> Please test this release candidate and cast your vote.
>>>> [ ] +1 Release the binary as Apache Camel 2.19.0
>>>> [ ] -1 Veto the release (provide specific comments)
>>>>
>>>> The vote is open for at least 72 hours.
>>>>
>>>> Due to the many changes introduced with this new release, it would be
>>>> beneficial if we could get as many Camel riders involved in testing
>>>> this release candidate as possible.
>>>>
>>>> Thanks,
>>>> Gregor
>>>>
>>>> [1] https://cwiki.apache.org/confluence/display/CAMEL/Camel+2.19+Release
>>>> [2]
>>>>
>>>> http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
>>>>
>>>
>>
>>
>>
>
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: [VOTE] Release Apache Camel 2.19.0 (Attempt #2)
Posted by Marco Collovati <mc...@gmail.com>.
Ok, sorry.
BTW, aside from my previous problem, I tested RC on some production
project involving camel-jms, camel-cxf, camel-mail and
camel-api-component-maven-plugin and all is working fine.
On 02/05/2017 20:39, Claus Ibsen wrote:
> Hi Marco
>
> You should likely post a new thread with more details what you are trying to do.
> Your use-case is not normal and therefore not considering a blocker.
> There are likely other places where such check in doStart is checking
> the field also.
>
> The RC testing is more focusing on existing applications being
> migrated or ported to this versions to find regressions etc.
>
>
> On Mon, May 1, 2017 at 7:38 AM, Marco Collovati <mc...@gmail.com> wrote:
>> -1
>>
>> Got an issue with DefaultComponent change on doStart method:
>> the check for camel context is done via getter
>> ```ObjectHelper.notNull(getCamelContext(), "camelContext");```
>> but the following logic access the `camelContext` field directly.
>>
>> This leads to NPE when extending DefaultComponent as a decorator for other
>> components.
>>
>> Maybe this is more an issue on my code but I think the camelContext check
>> should be consistent with the following code.
>>
>>
>>
>> On 30/04/2017 17:32, Gregor Zurowski wrote:
>>>
>>> Hi Everyone:
>>>
>>> This is the second vote to release Apache Camel 2.19.0, a new minor
>>> release with over 670 new features, improvements and bug fixes. A
>>> summary of the changes is available in the Camel wiki [1]. The first
>>> vote was cancelled due to multiple issues found while testing the
>>> first release candidate [1].
>>>
>>> Release notes:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12337871&projectId=12311211
>>>
>>> Staging repository:
>>> https://repository.apache.org/content/repositories/orgapachecamel-1075/
>>>
>>> Tarballs:
>>> https://repository.apache.org/content/repositories/orgapachecamel-1075/org/apache/camel/apache-camel/2.19.0/
>>>
>>> Tag:
>>> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=0ae39c5223d4e58e1f3063e7e5f071be0e258e97
>>>
>>> Please test this release candidate and cast your vote.
>>> [ ] +1 Release the binary as Apache Camel 2.19.0
>>> [ ] -1 Veto the release (provide specific comments)
>>>
>>> The vote is open for at least 72 hours.
>>>
>>> Due to the many changes introduced with this new release, it would be
>>> beneficial if we could get as many Camel riders involved in testing
>>> this release candidate as possible.
>>>
>>> Thanks,
>>> Gregor
>>>
>>> [1] https://cwiki.apache.org/confluence/display/CAMEL/Camel+2.19+Release
>>> [2]
>>> http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
>>>
>>
>
>
>
Re: [VOTE] Release Apache Camel 2.19.0 (Attempt #2)
Posted by Claus Ibsen <cl...@gmail.com>.
Hi Marco
You should likely post a new thread with more details what you are trying to do.
Your use-case is not normal and therefore not considering a blocker.
There are likely other places where such check in doStart is checking
the field also.
The RC testing is more focusing on existing applications being
migrated or ported to this versions to find regressions etc.
On Mon, May 1, 2017 at 7:38 AM, Marco Collovati <mc...@gmail.com> wrote:
> -1
>
> Got an issue with DefaultComponent change on doStart method:
> the check for camel context is done via getter
> ```ObjectHelper.notNull(getCamelContext(), "camelContext");```
> but the following logic access the `camelContext` field directly.
>
> This leads to NPE when extending DefaultComponent as a decorator for other
> components.
>
> Maybe this is more an issue on my code but I think the camelContext check
> should be consistent with the following code.
>
>
>
> On 30/04/2017 17:32, Gregor Zurowski wrote:
>>
>> Hi Everyone:
>>
>> This is the second vote to release Apache Camel 2.19.0, a new minor
>> release with over 670 new features, improvements and bug fixes. A
>> summary of the changes is available in the Camel wiki [1]. The first
>> vote was cancelled due to multiple issues found while testing the
>> first release candidate [1].
>>
>> Release notes:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12337871&projectId=12311211
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachecamel-1075/
>>
>> Tarballs:
>> https://repository.apache.org/content/repositories/orgapachecamel-1075/org/apache/camel/apache-camel/2.19.0/
>>
>> Tag:
>> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=0ae39c5223d4e58e1f3063e7e5f071be0e258e97
>>
>> Please test this release candidate and cast your vote.
>> [ ] +1 Release the binary as Apache Camel 2.19.0
>> [ ] -1 Veto the release (provide specific comments)
>>
>> The vote is open for at least 72 hours.
>>
>> Due to the many changes introduced with this new release, it would be
>> beneficial if we could get as many Camel riders involved in testing
>> this release candidate as possible.
>>
>> Thanks,
>> Gregor
>>
>> [1] https://cwiki.apache.org/confluence/display/CAMEL/Camel+2.19+Release
>> [2]
>> http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
>>
>
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: [VOTE] Release Apache Camel 2.19.0 (Attempt #2)
Posted by Thomas Diesler <td...@redhat.com>.
+1
> On 1. May 2017, at 13:38, Marco Collovati <mc...@gmail.com> wrote:
>
> -1
>
> Got an issue with DefaultComponent change on doStart method:
> the check for camel context is done via getter
> ```ObjectHelper.notNull(getCamelContext(), "camelContext");```
> but the following logic access the `camelContext` field directly.
>
> This leads to NPE when extending DefaultComponent as a decorator for other components.
>
> Maybe this is more an issue on my code but I think the camelContext check should be consistent with the following code.
>
>
> On 30/04/2017 17:32, Gregor Zurowski wrote:
>> Hi Everyone:
>>
>> This is the second vote to release Apache Camel 2.19.0, a new minor
>> release with over 670 new features, improvements and bug fixes. A
>> summary of the changes is available in the Camel wiki [1]. The first
>> vote was cancelled due to multiple issues found while testing the
>> first release candidate [1].
>>
>> Release notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12337871&projectId=12311211
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachecamel-1075/
>>
>> Tarballs: https://repository.apache.org/content/repositories/orgapachecamel-1075/org/apache/camel/apache-camel/2.19.0/
>>
>> Tag: https://git-wip-us.apache.org/repos/asf?p=camel.git;a=tag;h=0ae39c5223d4e58e1f3063e7e5f071be0e258e97
>>
>> Please test this release candidate and cast your vote.
>> [ ] +1 Release the binary as Apache Camel 2.19.0
>> [ ] -1 Veto the release (provide specific comments)
>>
>> The vote is open for at least 72 hours.
>>
>> Due to the many changes introduced with this new release, it would be
>> beneficial if we could get as many Camel riders involved in testing
>> this release candidate as possible.
>>
>> Thanks,
>> Gregor
>>
>> [1] https://cwiki.apache.org/confluence/display/CAMEL/Camel+2.19+Release
>> [2] http://camel.465427.n5.nabble.com/VOTE-Release-Apache-Camel-2-19-0-td5798264.html
>>
>