You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by upthewaterspout <gi...@git.apache.org> on 2017/05/25 20:09:39 UTC

[GitHub] geode pull request #538: GEODE-2975: Change the location of the lucene xsd

GitHub user upthewaterspout opened a pull request:

    https://github.com/apache/geode/pull/538

    GEODE-2975: Change the location of the lucene xsd

    The lucene xsd was not in the right location on disk, which resulted in
    a failure to validate lucene elements in the xml file.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    - [X] Does `gradlew build` run cleanly?
    
    - [X] Have you written or updated unit tests to verify your changes?
    
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/geode feature/GEODE-2975

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #538
    
----
commit 313febd9eb1cc2b89ab790d00183010b9d5d27b2
Author: Dan Smith <up...@apache.org>
Date:   2017-05-25T20:05:23Z

    GEODE-2975: Change the location of the lucene xsd
    
    The lucene xsd was not in the right location on disk, which resulted in
    a failure to validate lucene elements in the xml file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:

    https://github.com/apache/geode/pull/538
  
    Does this also affect the xsd location on http://geode.apache.org?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/538
  
    @nabarunnag @boglesby


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/538
  
    @boglesby - Let me know what you think of the new changes. I added some validation to the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

Posted by boglesby <gi...@git.apache.org>.
Github user boglesby commented on the issue:

    https://github.com/apache/geode/pull/538
  
    This looks good for these xmls:
    ```
    <lucene:fieldxx name="Agency"/>
    ```
    ```
    <lucene:field namexx="Agency"/>
    ```
    it still throws a ClassCastException for this, though:
    ```
    <lucene:indexxx name="index">
    ```
    I'm not sure if thats a problem or if its ok.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/538
  
    @metatype - Yes, we'll need to update the website as well, the location of the xsd is also wrong on the website, but for different reasons.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #538: GEODE-2975: Change the location of the lucene xsd

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/538


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd

Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode/pull/538
  
    @boglesby - I see the problem with lucene:indexxx. It looks like in cache-1.0.xsd, which specify this in order to allow other schemas (like lucene.xsd) to extend region with additional elements:
    
    `
          <xsd:any namespace="##other" processContents="lax" minOccurs="0" maxOccurs="unbounded"/>
    `
    
    Unfortunately, using 'lax' instead of 'strict' here means that we don't validate the new xsd as strictly - additional elements are ignored, etc.
    
    I'm worried about the impact of changing this validation. I think the thing to do maybe is just to give a little better error message in our java code and call it a day.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---