You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Sachin Patel <sp...@gmail.com> on 2006/11/06 16:16:19 UTC
[VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Ok. Fair enough. Please revote on..
http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
plugin-1.2.0-v200611060915-deployable-RC2.zip
Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
My +1.
On Nov 6, 2006, at 9:49 AM, Kevan Miller wrote:
>
> On Nov 6, 2006, at 9:29 AM, Sachin Patel wrote:
>
>> +1: Sachin Patel
>> +0: None
>> -1: None
>
> Sachin,
> Sorry, but you don't have the required number of PMC votes (IIUC
> correctly you need 3). Plus, it's not clear that all of your source
> headers have been updated...
>
> --kevan
-sachin
Re: [VOTE] (Time Extended) Release Eclipse Plugin 1.2.0
Posted by Paul McMahan <pa...@gmail.com>.
I retested using RC6 and it looks great!
+1
Paul
On 11/9/06, Sachin Patel <sp...@gmail.com> wrote:
>
> Due to recent bug fixes and copyright changes that went in, I've spun a new
> RC and am extending the vote another 72 hours.
>
> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611090858-deployable-RC6.zip
>
> The vote will conclude on Sunday 9:00 AM EST.
>
> thx
>
> -sachin
Re: [VOTE RESULT] (Time Extended) Release Eclipse Plugin 1.2.0
Posted by Matt Hogstrom <ma...@hogstrom.org>.
Hi Sachin...I'm late I know but for the record I installed and tested
the monster and also looked at the release. You have my very tardy +1.
On Nov 13, 2006, at 9:10 AM, Sachin Patel wrote:
> +1: Sachin, Kevan Miller, Paul McMahan
>
> Vote passes.
>
> On Nov 9, 2006, at 9:08 AM, Sachin Patel wrote:
>
>> Due to recent bug fixes and copyright changes that went in, I've
>> spun a new RC and am extending the vote another 72 hours.
>>
>> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
>> plugin-1.2.0-v200611090858-deployable-RC6.zip
>>
>> The vote will conclude on Sunday 9:00 AM EST.
>>
>> thx
>>
>> -sachin
>
>
> -sachin
>
>
Matt Hogstrom
matt@hogstrom.org
[VOTE RESULT] (Time Extended) Release Eclipse Plugin 1.2.0
Posted by Sachin Patel <sp...@gmail.com>.
+1: Sachin, Kevan Miller, Paul McMahan
Vote passes.
On Nov 9, 2006, at 9:08 AM, Sachin Patel wrote:
> Due to recent bug fixes and copyright changes that went in, I've
> spun a new RC and am extending the vote another 72 hours.
>
> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
> plugin-1.2.0-v200611090858-deployable-RC6.zip
>
> The vote will conclude on Sunday 9:00 AM EST.
>
> thx
>
> -sachin
-sachin
[VOTE] (Time Extended) Release Eclipse Plugin 1.2.0
Posted by Sachin Patel <sp...@gmail.com>.
Due to recent bug fixes and copyright changes that went in, I've spun
a new RC and am extending the vote another 72 hours.
http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
plugin-1.2.0-v200611090858-deployable-RC6.zip
The vote will conclude on Sunday 9:00 AM EST.
thx
-sachin
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Sachin Patel <sp...@gmail.com>.
Continue vote on..
http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
plugin-1.2.0-v200611070107-deployable-RC4.zip
Additional copyrights were updated and a fix allowing server ping
thread to have modifiable parameters needed to be added.
On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
> Ok. Fair enough. Please revote on..
>
> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
> plugin-1.2.0-v200611060915-deployable-RC2.zip
>
> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>
> My +1.
>
> On Nov 6, 2006, at 9:49 AM, Kevan Miller wrote:
>
>>
>> On Nov 6, 2006, at 9:29 AM, Sachin Patel wrote:
>>
>>> +1: Sachin Patel
>>> +0: None
>>> -1: None
>>
>> Sachin,
>> Sorry, but you don't have the required number of PMC votes (IIUC
>> correctly you need 3). Plus, it's not clear that all of your
>> source headers have been updated...
>>
>> --kevan
>
>
> -sachin
>
>
-sachin
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Sachin Patel <sp...@gmail.com>.
thx.
Issues resolved in...
http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
plugin-1.2.0-v200611061236-deployable-RC3.zip
Please continue vote.
On Nov 6, 2006, at 12:18 PM, Paul McMahan wrote:
> +1 once the Bouncy Castle and source header issues Kevan identified
> are resolved.
>
> Paul
>
> On 11/6/06, Kevan Miller <ke...@gmail.com> wrote:
>>
>>
>> On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
>> Ok. Fair enough. Please revote on..
>>
>> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
>> plugin-1.2.0-v200611060915-deployable-RC2.zip
>>
>> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>>
>>
>> Sachin,
>> G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since
>> you are
>> including geronimo-util, they should be added to the your notice
>> and license
>> files, also. I don't know of a way to automatically aggregate this
>> LICENSE
>> and NOTICE information, but it would sure be nice...
>>
>> Minor, but it looks like NOTICE has a mix of DOS and UNIX line
>> endings.
>>
>> I tried out rat (release audit tool) from http://code.google.com/p/
>> arat/
>> Seems pretty useful. I'll point it at Geronimo 1.2, sometime this
>> week.
>>
>> It identified that the following source files were missing
>> appropriate
>> headers. Are .classpath, .project, and .option files really meant
>> to be
>> under svn control? There were 3 obvious source files that are missing
>> headers...
>>
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.common.deployment.model/.classpath)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.common.deployment.model/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.common.deployment.model.edit/.classpath)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.common.deployment.model.edit/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.deployment.model/.classpath)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.deployment.model/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.deployment.model.edit/.classpath)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.deployment.model.edit/.project)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.runtime.common/.project)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.runtime.v1/.project)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.runtime.v11/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.core/.classpath)
>> ==.options
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.core/.options)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.core/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.ui/.classpath)
>> ==.options
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.ui/.options)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.ui/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v1.core/.classpath)
>> ==.options
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v1.core/.options)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v1.core/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v1.ui/.classpath)
>> ==.options
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v1.ui/.options)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v1.ui/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.core/.classpath)
>> ==.options
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.core/.options)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.core/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.ui/.classpath)
>> ==.options
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.ui/.options)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.ui/.project)
>> ==Activator.java
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/
>> Activator.java)
>> ==Messages.java
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/
>> internal/Messages.java)
>> ==SecurityPage.java
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/
>> pages/SecurityPage.java)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.v11.deployment.model/.classpath)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.v11.deployment.model/.project)
>> ==.classpath
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.v11.deployment.model.edit/.classpath)
>> ==.project
>> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/
>> org.apache.geronimo.v11.deployment.model.edit/.project)
>>
>> I'm + 1 once the Bouncy Castle and source header issues are resolved.
>>
>> --kevan
-sachin
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Paul McMahan <pa...@gmail.com>.
+1 once the Bouncy Castle and source header issues Kevan identified
are resolved.
Paul
On 11/6/06, Kevan Miller <ke...@gmail.com> wrote:
>
>
> On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
> Ok. Fair enough. Please revote on..
>
> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-plugin-1.2.0-v200611060915-deployable-RC2.zip
>
> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>
>
> Sachin,
> G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since you are
> including geronimo-util, they should be added to the your notice and license
> files, also. I don't know of a way to automatically aggregate this LICENSE
> and NOTICE information, but it would sure be nice...
>
> Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.
>
> I tried out rat (release audit tool) from http://code.google.com/p/arat/
> Seems pretty useful. I'll point it at Geronimo 1.2, sometime this week.
>
> It identified that the following source files were missing appropriate
> headers. Are .classpath, .project, and .option files really meant to be
> under svn control? There were 3 obvious source files that are missing
> headers...
>
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.classpath)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.common.deployment.model.edit/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.classpath)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.classpath)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.deployment.model.edit/.project)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.common/.project)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v1/.project)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.runtime.v11/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.classpath)
> ==.options
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.options)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.classpath)
> ==.options
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.options)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.ui/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.classpath)
> ==.options
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.options)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.core/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.classpath)
> ==.options
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.options)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v1.ui/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.classpath)
> ==.options
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.options)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.core/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.classpath)
> ==.options
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.options)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/.project)
> ==Activator.java
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)
> ==Messages.java
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)
> ==SecurityPage.java
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/pages/SecurityPage.java)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.v11.deployment.model/.classpath)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.v11.deployment.model/.project)
> ==.classpath
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.v11.deployment.model.edit/.classpath)
> ==.project
> (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.v11.deployment.model.edit/.project)
>
> I'm + 1 once the Bouncy Castle and source header issues are resolved.
>
> --kevan
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Kevan Miller <ke...@gmail.com>.
On Nov 6, 2006, at 12:15 PM, Sachin Patel wrote:
> Actually since you have it up, can you go ahead and fix it?
Done.
--kevan
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Sachin Patel <sp...@gmail.com>.
Actually since you have it up, can you go ahead and fix it?
On Nov 6, 2006, at 12:02 PM, Kevan Miller wrote:
>
> On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
>
>> Ok. Fair enough. Please revote on..
>>
>> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
>> plugin-1.2.0-v200611060915-deployable-RC2.zip
>>
>> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>>
>
> Sachin,
> G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since
> you are including geronimo-util, they should be added to the your
> notice and license files, also. I don't know of a way to
> automatically aggregate this LICENSE and NOTICE information, but it
> would sure be nice...
>
> Minor, but it looks like NOTICE has a mix of DOS and UNIX line
> endings.
>
> I tried out rat (release audit tool) from http://code.google.com/p/
> arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime
> this week.
>
> It identified that the following source files were missing
> appropriate headers. Are .classpath, .project, and .option files
> really meant to be under svn control? There were 3 obvious source
> files that are missing headers...
>
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model.edit/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model.edit/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.runtime.common/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.runtime.v1/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.runtime.v11/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.ui/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.ui/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.ui/.project)
> ==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
> st/v11/ui/Activator.java)
> ==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
> st/v11/ui/internal/Messages.java)
> ==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
> st/v11/ui/pages/SecurityPage.java)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model.edit/.project)
>
> I'm + 1 once the Bouncy Castle and source header issues are resolved.
>
> --kevan
-sachin
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Sachin Patel <sp...@gmail.com>.
Yes the .option and .classpath files need to be under source
control. The maven eclipse plugin does not correctly generate these
for eclipse bundles. The .options file could be autogenerated with a
plugin, but have not done this yet.
I'll fix the LICENSE and NOTICE files for Bouncy Castle.
On Nov 6, 2006, at 12:02 PM, Kevan Miller wrote:
>
> On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
>
>> Ok. Fair enough. Please revote on..
>>
>> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
>> plugin-1.2.0-v200611060915-deployable-RC2.zip
>>
>> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>>
>
> Sachin,
> G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since
> you are including geronimo-util, they should be added to the your
> notice and license files, also. I don't know of a way to
> automatically aggregate this LICENSE and NOTICE information, but it
> would sure be nice...
>
> Minor, but it looks like NOTICE has a mix of DOS and UNIX line
> endings.
>
> I tried out rat (release audit tool) from http://code.google.com/p/
> arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime
> this week.
>
> It identified that the following source files were missing
> appropriate headers. Are .classpath, .project, and .option files
> really meant to be under svn control? There were 3 obvious source
> files that are missing headers...
>
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.common.deployment.model.edit/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.deployment.model.edit/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.runtime.common/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.runtime.v1/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.runtime.v11/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.ui/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v1.ui/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.st.v11.ui/.project)
> ==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
> st/v11/ui/Activator.java)
> ==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
> st/v11/ui/internal/Messages.java)
> ==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
> st/v11/ui/pages/SecurityPage.java)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
> plugins/org.apache.geronimo.v11.deployment.model.edit/.project)
>
> I'm + 1 once the Bouncy Castle and source header issues are resolved.
>
> --kevan
-sachin
Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Posted by Kevan Miller <ke...@gmail.com>.
On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
> Ok. Fair enough. Please revote on..
>
> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse-
> plugin-1.2.0-v200611060915-deployable-RC2.zip
>
> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>
Sachin,
G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since
you are including geronimo-util, they should be added to the your
notice and license files, also. I don't know of a way to
automatically aggregate this LICENSE and NOTICE information, but it
would sure be nice...
Minor, but it looks like NOTICE has a mix of DOS and UNIX line endings.
I tried out rat (release audit tool) from http://code.google.com/p/
arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime
this week.
It identified that the following source files were missing
appropriate headers. Are .classpath, .project, and .option files
really meant to be under svn control? There were 3 obvious source
files that are missing headers...
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.common.deployment.model/.classpath)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.common.deployment.model/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.common.deployment.model.edit/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.deployment.model/.classpath)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.deployment.model/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.deployment.model.edit/.classpath)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.deployment.model.edit/.project)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.runtime.common/.project)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.runtime.v1/.project)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.runtime.v11/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.core/.classpath)
==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.core/.options)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.core/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.ui/.classpath)
==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.ui/.options)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.ui/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v1.core/.classpath)
==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v1.core/.options)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v1.core/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v1.ui/.classpath)
==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v1.ui/.options)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v1.ui/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.core/.classpath)
==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.core/.options)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.core/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.ui/.classpath)
==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.ui/.options)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.ui/.project)
==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/
ui/Activator.java)
==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/st/v11/
ui/internal/Messages.java)
==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/
trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/
st/v11/ui/pages/SecurityPage.java)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.v11.deployment.model/.classpath)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.v11.deployment.model/.project)
==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.v11.deployment.model.edit/.classpath)
==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/
plugins/org.apache.geronimo.v11.deployment.model.edit/.project)
I'm + 1 once the Bouncy Castle and source header issues are resolved.
--kevan