You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/05/16 03:25:03 UTC

Review Request 21523: Make JS compliant with JSHint rules

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
-----------------------------------------------------------

Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.

Repository: aurora

Description
-------

Make JS compliant with JSHint rules

Add JSHint to our build.

Right now it does not break the build when JSHint fails.
Will fix the errors in a separate review.

Testing Done:
./gradlew clean build works.

Bugs closed: AURORA-228

Reviewed at https://reviews.apache.org/r/21407/

Add config grouping visualisation to job page

Replace the button to show/hide configs with a bar when there are multiple.
Tidied up the display of the configuration data.

Bugs closed: AURORA-378

Reviewed at https://reviews.apache.org/r/21247/

Diffs
-----

build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8
src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692

Diff: https://reviews.apache.org/r/21523/diff/

Testing
-------

Thanks,

David McLaughlin

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by David McLaughlin <da...@dmclaughlin.com>.


> On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 17
> > <https://reviews.apache.org/r/21523/diff/1/?file=582876#file582876line17>
> >
> >     Why?

Good question.

JavaScript in the browser doesn't have modules or linking. It just has one big global scope. In practice linking is done by relying on global variables. JSHint forces you to be explicit about what globals your project (see the predef option in build.gradle) each file relies on, so that it can then detect use of undeclared variables elsewhere. 

I added all of the core libraries we use to our build.gradle. So these globals are just leaky values we've exposed ourselves that really should be injected via DI (but that's a much bigger change). 

Adding :false after the global name tells JSHint to throw an error if someone tries to redeclare a global in some local scope, or to use a local variable with the same name. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43218
-----------------------------------------------------------


On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build
> :about
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources
> :classes
> :jar
> :assemble
> :jsHint UP-TO-DATE
> :checkstyleMain
> :compileTestJava
> :processTestResources
> :testClasses
> :checkstyleTest
> :findbugsGenerated
> :findbugsMain
> :findbugsTest
> :licenseGenerated
> :licenseTest UP-TO-DATE
> :license UP-TO-DATE
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
> 
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 19.979 secs
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by David McLaughlin <da...@dmclaughlin.com>.


> On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 17
> > <https://reviews.apache.org/r/21523/diff/1/?file=582876#file582876line17>
> >
> >     Why?
> 
> David McLaughlin wrote:
>     Good question.
>     
>     JavaScript in the browser doesn't have modules or linking. It just has one big global scope. In practice linking is done by relying on global variables. JSHint forces you to be explicit about what globals your project (see the predef option in build.gradle) each file relies on, so that it can then detect use of undeclared variables elsewhere. 
>     
>     I added all of the core libraries we use to our build.gradle. So these globals are just leaky values we've exposed ourselves that really should be injected via DI (but that's a much bigger change). 
>     
>     Adding :false after the global name tells JSHint to throw an error if someone tries to redeclare a global in some local scope, or to use a local variable with the same name.

Sorry, I didn't finish editing that first paragraph. That final sentence should be:

JSHint forces you to be explicit about what globals you use, which can be set for the entire project (see the predef option in build.gradle) or on a per-file basis with a comment. By knowing all expected globals, JSHint can then detect use of undeclared variables.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43218
-----------------------------------------------------------


On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build
> :about
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources
> :classes
> :jar
> :assemble
> :jsHint UP-TO-DATE
> :checkstyleMain
> :compileTestJava
> :processTestResources
> :testClasses
> :checkstyleTest
> :findbugsGenerated
> :findbugsMain
> :findbugsTest
> :licenseGenerated
> :licenseTest UP-TO-DATE
> :license UP-TO-DATE
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
> 
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 19.979 secs
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by Mark Chu-Carroll <mc...@twopensource.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43218
-----------------------------------------------------------

Ship it!


Ship It!


src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/21523/#comment77304>

    Why?


- Mark Chu-Carroll


On May 15, 2014, 9:30 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 9:30 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build
> :about
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources
> :classes
> :jar
> :assemble
> :jsHint UP-TO-DATE
> :checkstyleMain
> :compileTestJava
> :processTestResources
> :testClasses
> :checkstyleTest
> :findbugsGenerated
> :findbugsMain
> :findbugsTest
> :licenseGenerated
> :licenseTest UP-TO-DATE
> :license UP-TO-DATE
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
> 
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 19.979 secs
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by Mark Chu-Carroll <mc...@twopensource.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43264
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Chu-Carroll


On May 15, 2014, 9:30 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 9:30 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build
> :about
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources
> :classes
> :jar
> :assemble
> :jsHint UP-TO-DATE
> :checkstyleMain
> :compileTestJava
> :processTestResources
> :testClasses
> :checkstyleTest
> :findbugsGenerated
> :findbugsMain
> :findbugsTest
> :licenseGenerated
> :licenseTest UP-TO-DATE
> :license UP-TO-DATE
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
> 
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 19.979 secs
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by David McLaughlin <da...@dmclaughlin.com>.


> On May 20, 2014, 6:08 p.m., Suman Karumuri wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 98
> > <https://reviews.apache.org/r/21523/diff/1/?file=582879#file582879line98>
> >
> >     s/if(/if (/
> >     
> >     Can jsHint catch this?

Good catch. Will add:

white: true

To the JSHint options and fix the new errors. 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43507
-----------------------------------------------------------


On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build
> :about
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources
> :classes
> :jar
> :assemble
> :jsHint UP-TO-DATE
> :checkstyleMain
> :compileTestJava
> :processTestResources
> :testClasses
> :checkstyleTest
> :findbugsGenerated
> :findbugsMain
> :findbugsTest
> :licenseGenerated
> :licenseTest UP-TO-DATE
> :license UP-TO-DATE
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
> 
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 19.979 secs
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by Suman Karumuri <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43507
-----------------------------------------------------------

Ship it!



src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
<https://reviews.apache.org/r/21523/#comment77688>

    s/if(/if (/
    
    Can jsHint catch this?


- Suman Karumuri


On May 16, 2014, 1:30 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build
> :about
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources
> :classes
> :jar
> :assemble
> :jsHint UP-TO-DATE
> :checkstyleMain
> :compileTestJava
> :processTestResources
> :testClasses
> :checkstyleTest
> :findbugsGenerated
> :findbugsMain
> :findbugsTest
> :licenseGenerated
> :licenseTest UP-TO-DATE
> :license UP-TO-DATE
> :test
> :jacocoTestReport
> Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
> :check
> :build
> 
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 19.979 secs
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by Suman Karumuri <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43671
-----------------------------------------------------------


Pushed. Please close out this review.

- Suman Karumuri


On May 20, 2014, 11:19 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21523/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 11:19 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-438
>     https://issues.apache.org/jira/browse/AURORA-438
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make JS compliant with JSHint rules
> 
> 
> Diffs
> -----
> 
>   build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 
> 
> Diff: https://reviews.apache.org/r/21523/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew clean build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
-----------------------------------------------------------

(Updated May 20, 2014, 11:19 p.m.)


Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.


Bugs: AURORA-438
    https://issues.apache.org/jira/browse/AURORA-438


Repository: aurora


Description
-------

Make JS compliant with JSHint rules


Diffs
-----

  build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 

Diff: https://reviews.apache.org/r/21523/diff/


Testing (updated)
-------

$ ./gradlew clean build


Thanks,

David McLaughlin

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
-----------------------------------------------------------

(Updated May 20, 2014, 7:24 p.m.)


Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.


Bugs: AURORA-438
    https://issues.apache.org/jira/browse/AURORA-438


Repository: aurora


Description
-------

Make JS compliant with JSHint rules


Diffs (updated)
-----

  build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 

Diff: https://reviews.apache.org/r/21523/diff/


Testing
-------

$ ./gradlew build
:about
:bootstrapThrift UP-TO-DATE
:checkPython
:generateSources UP-TO-DATE
:compileGeneratedJava UP-TO-DATE
:processGeneratedResources UP-TO-DATE
:generatedClasses UP-TO-DATE
:compileJava UP-TO-DATE
:processResources
:classes
:jar
:assemble
:jsHint UP-TO-DATE
:checkstyleMain
:compileTestJava
:processTestResources
:testClasses
:checkstyleTest
:findbugsGenerated
:findbugsMain
:findbugsTest
:licenseGenerated
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:test
:jacocoTestReport
Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
:check
:build

BUILD SUCCESSFUL

Total time: 3 mins 19.979 secs


Thanks,

David McLaughlin

Re: Review Request 21523: Make JS compliant with JSHint rules

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
-----------------------------------------------------------

(Updated May 16, 2014, 1:30 a.m.)


Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.


Bugs: AURORA-438
    https://issues.apache.org/jira/browse/AURORA-438


Repository: aurora


Description (updated)
-------

Make JS compliant with JSHint rules


Diffs
-----

  build.gradle ac54257a0342e1f1a162189191d5f7b27e1651c9 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 1a617129da4747584df1b49c34ffcaa4b505d3dc 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 890cb445aaed29d60d1728c2ad10074912993ad8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js a2aea4d10e4401efebe37eab10d5ce72ceb5c6ca 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js f984956c90e1db38573a56af3427f2f948f13692 

Diff: https://reviews.apache.org/r/21523/diff/


Testing (updated)
-------

$ ./gradlew build
:about
:bootstrapThrift UP-TO-DATE
:checkPython
:generateSources UP-TO-DATE
:compileGeneratedJava UP-TO-DATE
:processGeneratedResources UP-TO-DATE
:generatedClasses UP-TO-DATE
:compileJava UP-TO-DATE
:processResources
:classes
:jar
:assemble
:jsHint UP-TO-DATE
:checkstyleMain
:compileTestJava
:processTestResources
:testClasses
:checkstyleTest
:findbugsGenerated
:findbugsMain
:findbugsTest
:licenseGenerated
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:test
:jacocoTestReport
Coverage report generated: file:////Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html
:check
:build

BUILD SUCCESSFUL

Total time: 3 mins 19.979 secs


Thanks,

David McLaughlin