You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2017/01/22 22:01:44 UTC
Re: wicket git commit: added german markups
Hi Sven,
What is the reason to prefer _de.html than _de.properties (and adding
wicket:message and/or ResourceModel where needed) ?
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
> Repository: wicket
> Updated Branches:
> refs/heads/master 31727f854 -> 7596d9571
>
>
> added german markups
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7596d957
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7596d957
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7596d957
>
> Branch: refs/heads/master
> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
> Parents: 31727f8
> Author: Sven Meier <sv...@apache.org>
> Authored: Sat Jan 21 20:21:49 2017 +0100
> Committer: Sven Meier <sv...@apache.org>
> Committed: Sat Jan 21 20:21:49 2017 +0100
>
> ----------------------------------------------------------------------
> .../authentication/pages/SignInPage_de.html | 12 ++++++++++
> .../authentication/pages/SignOutPage_de.html | 25 ++++++++++++++++++++
> 2 files changed, 37 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
> authentication/pages/SignInPage_de.html
> ----------------------------------------------------------------------
> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> authroles/authentication/pages/SignInPage_de.html
> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> authroles/authentication/pages/SignInPage_de.html
> new file mode 100644
> index 0000000..e4e6fca
> --- /dev/null
> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> authroles/authentication/pages/SignInPage_de.html
> @@ -0,0 +1,12 @@
> +<?xml version="1.0" encoding="UTF-8" ?>
> +<html xmlns:wicket="http://wicket.apache.org">
> +<head>
> + <title>Anmelden</title>
> +</head>
> +<body>
> + <h2>Anmelden</h2>
> + <p>
> + <span wicket:id="signInPanel"/>
>
This would be better to be a <div>, instead of <p><span>.
The default SingInPanel.html doesn't contain block elements but a custom
one might have one.
> + </p>
> +</body>
> +</html>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
> authentication/pages/SignOutPage_de.html
> ----------------------------------------------------------------------
> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> authroles/authentication/pages/SignOutPage_de.html
> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> authroles/authentication/pages/SignOutPage_de.html
> new file mode 100644
> index 0000000..b9d8b2f
> --- /dev/null
> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> authroles/authentication/pages/SignOutPage_de.html
> @@ -0,0 +1,25 @@
> +<?xml version="1.0" encoding="UTF-8" ?>
> +<!--
> + Licensed to the Apache Software Foundation (ASF) under one or more
> + contributor license agreements. See the NOTICE file distributed with
> + this work for additional information regarding copyright ownership.
> + The ASF licenses this file to You under the Apache License, Version 2.0
> + (the "License"); you may not use this file except in compliance with
> + the License. You may obtain a copy of the License at
> +
> + http://www.apache.org/licenses/LICENSE-2.0
> +
> + Unless required by applicable law or agreed to in writing, software
> + distributed under the License is distributed on an "AS IS" BASIS,
> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + See the License for the specific language governing permissions and
> + limitations under the License.
> +-->
> +<html>
> +<head>
> + <title>Abmeldung</title>
> +</head>
> +<body>
> + <h2>Auf Wiedersehen!</h2>
> +</body>
> +</html>
>
>
Re: wicket git commit: added german markups
Posted by Maxim Solodovnik <so...@gmail.com>.
Done :)
On Mon, Jan 23, 2017 at 4:18 PM, Martin Grigorov <mg...@apache.org>
wrote:
> On Mon, Jan 23, 2017 at 10:10 AM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > I'm also using custom page :)
> > I would like to contribute to have both files translated (currently only
> > Login is translated)
> >
>
> Please do!
> The translations could be used for the .properties file if we decide to
> rework this at some point.
>
>
>
> >
> > On Mon, Jan 23, 2017 at 3:50 PM, Martin Grigorov <mg...@apache.org>
> > wrote:
> >
> > > Hi,
> > >
> > > I wonder who even uses those default pages.
> > > In my experience I always needed custom styling and used custom pages.
> > >
> > > Martin Grigorov
> > > Wicket Training and Consulting
> > > https://twitter.com/mtgrigorov
> > >
> > > On Mon, Jan 23, 2017 at 9:20 AM, Maxim Solodovnik <
> solomax666@gmail.com>
> > > wrote:
> > >
> > > > I can contribute missing Russian page
> > > > Or everything will be refactored to use wicket:messages?
> > > >
> > > > On Mon, Jan 23, 2017 at 3:14 PM, Sven Meier <sv...@meiers.net> wrote:
> > > >
> > > > > Hi Martin,
> > > > >
> > > > > I would use _**.html only if I needed different markup for each
> > > language.
> > > > > Clearly this isn't the case here, so wicket:message with language
> > > > specific
> > > > > resource files would be a better solution.
> > > > >
> > > > > But wicket-auth-roles has done it that way apparently, so I didn't
> > want
> > > > to
> > > > > change it.
> > > > >
> > > > > Jacek provided the polish translation and I just added the missing
> > > German
> > > > > file.
> > > > >
> > > > > Have fun
> > > > > Sven
> > > > >
> > > > >
> > > > >
> > > > > On 22.01.2017 23:01, Martin Grigorov wrote:
> > > > >
> > > > >> Hi Sven,
> > > > >>
> > > > >> What is the reason to prefer _de.html than _de.properties (and
> > adding
> > > > >> wicket:message and/or ResourceModel where needed) ?
> > > > >>
> > > > >> Martin Grigorov
> > > > >> Wicket Training and Consulting
> > > > >> https://twitter.com/mtgrigorov
> > > > >>
> > > > >> On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
> > > > >>
> > > > >> Repository: wicket
> > > > >>> Updated Branches:
> > > > >>> refs/heads/master 31727f854 -> 7596d9571
> > > > >>>
> > > > >>>
> > > > >>> added german markups
> > > > >>>
> > > > >>>
> > > > >>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > > > >>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/
> > > 7596d957
> > > > >>> Tree: http://git-wip-us.apache.org/
> repos/asf/wicket/tree/7596d957
> > > > >>> Diff: http://git-wip-us.apache.org/
> repos/asf/wicket/diff/7596d957
> > > > >>>
> > > > >>> Branch: refs/heads/master
> > > > >>> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
> > > > >>> Parents: 31727f8
> > > > >>> Author: Sven Meier <sv...@apache.org>
> > > > >>> Authored: Sat Jan 21 20:21:49 2017 +0100
> > > > >>> Committer: Sven Meier <sv...@apache.org>
> > > > >>> Committed: Sat Jan 21 20:21:49 2017 +0100
> > > > >>>
> > > > >>> ------------------------------------------------------------
> > > ----------
> > > > >>> .../authentication/pages/SignInPage_de.html | 12
> ++++++++++
> > > > >>> .../authentication/pages/SignOutPage_de.html | 25
> > > > >>> ++++++++++++++++++++
> > > > >>> 2 files changed, 37 insertions(+)
> > > > >>> ------------------------------------------------------------
> > > ----------
> > > > >>>
> > > > >>>
> > > > >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/
> > > wicket/authroles/
> > > > >>> authentication/pages/SignInPage_de.html
> > > > >>> ------------------------------------------------------------
> > > ----------
> > > > >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > > >>> authroles/authentication/pages/SignInPage_de.html
> > > > >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > > >>> authroles/authentication/pages/SignInPage_de.html
> > > > >>> new file mode 100644
> > > > >>> index 0000000..e4e6fca
> > > > >>> --- /dev/null
> > > > >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > > >>> authroles/authentication/pages/SignInPage_de.html
> > > > >>> @@ -0,0 +1,12 @@
> > > > >>> +<?xml version="1.0" encoding="UTF-8" ?>
> > > > >>> +<html xmlns:wicket="http://wicket.apache.org">
> > > > >>> +<head>
> > > > >>> + <title>Anmelden</title>
> > > > >>> +</head>
> > > > >>> +<body>
> > > > >>> + <h2>Anmelden</h2>
> > > > >>> + <p>
> > > > >>> + <span wicket:id="signInPanel"/>
> > > > >>>
> > > > >>> This would be better to be a <div>, instead of <p><span>.
> > > > >> The default SingInPanel.html doesn't contain block elements but a
> > > custom
> > > > >> one might have one.
> > > > >>
> > > > >>
> > > > >> + </p>
> > > > >>> +</body>
> > > > >>> +</html>
> > > > >>>
> > > > >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > > >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/
> > > wicket/authroles/
> > > > >>> authentication/pages/SignOutPage_de.html
> > > > >>> ------------------------------------------------------------
> > > ----------
> > > > >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > > >>> authroles/authentication/pages/SignOutPage_de.html
> > > > >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > > >>> authroles/authentication/pages/SignOutPage_de.html
> > > > >>> new file mode 100644
> > > > >>> index 0000000..b9d8b2f
> > > > >>> --- /dev/null
> > > > >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > > >>> authroles/authentication/pages/SignOutPage_de.html
> > > > >>> @@ -0,0 +1,25 @@
> > > > >>> +<?xml version="1.0" encoding="UTF-8" ?>
> > > > >>> +<!--
> > > > >>> + Licensed to the Apache Software Foundation (ASF) under one or
> > > more
> > > > >>> + contributor license agreements. See the NOTICE file
> > distributed
> > > > with
> > > > >>> + this work for additional information regarding copyright
> > > ownership.
> > > > >>> + The ASF licenses this file to You under the Apache License,
> > > Version
> > > > >>> 2.0
> > > > >>> + (the "License"); you may not use this file except in
> compliance
> > > > with
> > > > >>> + the License. You may obtain a copy of the License at
> > > > >>> +
> > > > >>> + http://www.apache.org/licenses/LICENSE-2.0
> > > > >>> +
> > > > >>> + Unless required by applicable law or agreed to in writing,
> > > software
> > > > >>> + distributed under the License is distributed on an "AS IS"
> > BASIS,
> > > > >>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
> or
> > > > >>> implied.
> > > > >>> + See the License for the specific language governing
> permissions
> > > and
> > > > >>> + limitations under the License.
> > > > >>> +-->
> > > > >>> +<html>
> > > > >>> +<head>
> > > > >>> + <title>Abmeldung</title>
> > > > >>> +</head>
> > > > >>> +<body>
> > > > >>> + <h2>Auf Wiedersehen!</h2>
> > > > >>> +</body>
> > > > >>> +</html>
> > > > >>>
> > > > >>>
> > > > >>>
> > > > >
> > > >
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > > >
> > >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
--
WBR
Maxim aka solomax
Re: wicket git commit: added german markups
Posted by Martin Grigorov <mg...@apache.org>.
On Mon, Jan 23, 2017 at 10:10 AM, Maxim Solodovnik <so...@gmail.com>
wrote:
> I'm also using custom page :)
> I would like to contribute to have both files translated (currently only
> Login is translated)
>
Please do!
The translations could be used for the .properties file if we decide to
rework this at some point.
>
> On Mon, Jan 23, 2017 at 3:50 PM, Martin Grigorov <mg...@apache.org>
> wrote:
>
> > Hi,
> >
> > I wonder who even uses those default pages.
> > In my experience I always needed custom styling and used custom pages.
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Mon, Jan 23, 2017 at 9:20 AM, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > I can contribute missing Russian page
> > > Or everything will be refactored to use wicket:messages?
> > >
> > > On Mon, Jan 23, 2017 at 3:14 PM, Sven Meier <sv...@meiers.net> wrote:
> > >
> > > > Hi Martin,
> > > >
> > > > I would use _**.html only if I needed different markup for each
> > language.
> > > > Clearly this isn't the case here, so wicket:message with language
> > > specific
> > > > resource files would be a better solution.
> > > >
> > > > But wicket-auth-roles has done it that way apparently, so I didn't
> want
> > > to
> > > > change it.
> > > >
> > > > Jacek provided the polish translation and I just added the missing
> > German
> > > > file.
> > > >
> > > > Have fun
> > > > Sven
> > > >
> > > >
> > > >
> > > > On 22.01.2017 23:01, Martin Grigorov wrote:
> > > >
> > > >> Hi Sven,
> > > >>
> > > >> What is the reason to prefer _de.html than _de.properties (and
> adding
> > > >> wicket:message and/or ResourceModel where needed) ?
> > > >>
> > > >> Martin Grigorov
> > > >> Wicket Training and Consulting
> > > >> https://twitter.com/mtgrigorov
> > > >>
> > > >> On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
> > > >>
> > > >> Repository: wicket
> > > >>> Updated Branches:
> > > >>> refs/heads/master 31727f854 -> 7596d9571
> > > >>>
> > > >>>
> > > >>> added german markups
> > > >>>
> > > >>>
> > > >>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > > >>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/
> > 7596d957
> > > >>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7596d957
> > > >>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7596d957
> > > >>>
> > > >>> Branch: refs/heads/master
> > > >>> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
> > > >>> Parents: 31727f8
> > > >>> Author: Sven Meier <sv...@apache.org>
> > > >>> Authored: Sat Jan 21 20:21:49 2017 +0100
> > > >>> Committer: Sven Meier <sv...@apache.org>
> > > >>> Committed: Sat Jan 21 20:21:49 2017 +0100
> > > >>>
> > > >>> ------------------------------------------------------------
> > ----------
> > > >>> .../authentication/pages/SignInPage_de.html | 12 ++++++++++
> > > >>> .../authentication/pages/SignOutPage_de.html | 25
> > > >>> ++++++++++++++++++++
> > > >>> 2 files changed, 37 insertions(+)
> > > >>> ------------------------------------------------------------
> > ----------
> > > >>>
> > > >>>
> > > >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/
> > wicket/authroles/
> > > >>> authentication/pages/SignInPage_de.html
> > > >>> ------------------------------------------------------------
> > ----------
> > > >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > >>> authroles/authentication/pages/SignInPage_de.html
> > > >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > >>> authroles/authentication/pages/SignInPage_de.html
> > > >>> new file mode 100644
> > > >>> index 0000000..e4e6fca
> > > >>> --- /dev/null
> > > >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > >>> authroles/authentication/pages/SignInPage_de.html
> > > >>> @@ -0,0 +1,12 @@
> > > >>> +<?xml version="1.0" encoding="UTF-8" ?>
> > > >>> +<html xmlns:wicket="http://wicket.apache.org">
> > > >>> +<head>
> > > >>> + <title>Anmelden</title>
> > > >>> +</head>
> > > >>> +<body>
> > > >>> + <h2>Anmelden</h2>
> > > >>> + <p>
> > > >>> + <span wicket:id="signInPanel"/>
> > > >>>
> > > >>> This would be better to be a <div>, instead of <p><span>.
> > > >> The default SingInPanel.html doesn't contain block elements but a
> > custom
> > > >> one might have one.
> > > >>
> > > >>
> > > >> + </p>
> > > >>> +</body>
> > > >>> +</html>
> > > >>>
> > > >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > > >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/
> > wicket/authroles/
> > > >>> authentication/pages/SignOutPage_de.html
> > > >>> ------------------------------------------------------------
> > ----------
> > > >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > >>> authroles/authentication/pages/SignOutPage_de.html
> > > >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > >>> authroles/authentication/pages/SignOutPage_de.html
> > > >>> new file mode 100644
> > > >>> index 0000000..b9d8b2f
> > > >>> --- /dev/null
> > > >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > > >>> authroles/authentication/pages/SignOutPage_de.html
> > > >>> @@ -0,0 +1,25 @@
> > > >>> +<?xml version="1.0" encoding="UTF-8" ?>
> > > >>> +<!--
> > > >>> + Licensed to the Apache Software Foundation (ASF) under one or
> > more
> > > >>> + contributor license agreements. See the NOTICE file
> distributed
> > > with
> > > >>> + this work for additional information regarding copyright
> > ownership.
> > > >>> + The ASF licenses this file to You under the Apache License,
> > Version
> > > >>> 2.0
> > > >>> + (the "License"); you may not use this file except in compliance
> > > with
> > > >>> + the License. You may obtain a copy of the License at
> > > >>> +
> > > >>> + http://www.apache.org/licenses/LICENSE-2.0
> > > >>> +
> > > >>> + Unless required by applicable law or agreed to in writing,
> > software
> > > >>> + distributed under the License is distributed on an "AS IS"
> BASIS,
> > > >>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > > >>> implied.
> > > >>> + See the License for the specific language governing permissions
> > and
> > > >>> + limitations under the License.
> > > >>> +-->
> > > >>> +<html>
> > > >>> +<head>
> > > >>> + <title>Abmeldung</title>
> > > >>> +</head>
> > > >>> +<body>
> > > >>> + <h2>Auf Wiedersehen!</h2>
> > > >>> +</body>
> > > >>> +</html>
> > > >>>
> > > >>>
> > > >>>
> > > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: wicket git commit: added german markups
Posted by Maxim Solodovnik <so...@gmail.com>.
I'm also using custom page :)
I would like to contribute to have both files translated (currently only
Login is translated)
On Mon, Jan 23, 2017 at 3:50 PM, Martin Grigorov <mg...@apache.org>
wrote:
> Hi,
>
> I wonder who even uses those default pages.
> In my experience I always needed custom styling and used custom pages.
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Mon, Jan 23, 2017 at 9:20 AM, Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > I can contribute missing Russian page
> > Or everything will be refactored to use wicket:messages?
> >
> > On Mon, Jan 23, 2017 at 3:14 PM, Sven Meier <sv...@meiers.net> wrote:
> >
> > > Hi Martin,
> > >
> > > I would use _**.html only if I needed different markup for each
> language.
> > > Clearly this isn't the case here, so wicket:message with language
> > specific
> > > resource files would be a better solution.
> > >
> > > But wicket-auth-roles has done it that way apparently, so I didn't want
> > to
> > > change it.
> > >
> > > Jacek provided the polish translation and I just added the missing
> German
> > > file.
> > >
> > > Have fun
> > > Sven
> > >
> > >
> > >
> > > On 22.01.2017 23:01, Martin Grigorov wrote:
> > >
> > >> Hi Sven,
> > >>
> > >> What is the reason to prefer _de.html than _de.properties (and adding
> > >> wicket:message and/or ResourceModel where needed) ?
> > >>
> > >> Martin Grigorov
> > >> Wicket Training and Consulting
> > >> https://twitter.com/mtgrigorov
> > >>
> > >> On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
> > >>
> > >> Repository: wicket
> > >>> Updated Branches:
> > >>> refs/heads/master 31727f854 -> 7596d9571
> > >>>
> > >>>
> > >>> added german markups
> > >>>
> > >>>
> > >>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> > >>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/
> 7596d957
> > >>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7596d957
> > >>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7596d957
> > >>>
> > >>> Branch: refs/heads/master
> > >>> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
> > >>> Parents: 31727f8
> > >>> Author: Sven Meier <sv...@apache.org>
> > >>> Authored: Sat Jan 21 20:21:49 2017 +0100
> > >>> Committer: Sven Meier <sv...@apache.org>
> > >>> Committed: Sat Jan 21 20:21:49 2017 +0100
> > >>>
> > >>> ------------------------------------------------------------
> ----------
> > >>> .../authentication/pages/SignInPage_de.html | 12 ++++++++++
> > >>> .../authentication/pages/SignOutPage_de.html | 25
> > >>> ++++++++++++++++++++
> > >>> 2 files changed, 37 insertions(+)
> > >>> ------------------------------------------------------------
> ----------
> > >>>
> > >>>
> > >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/
> wicket/authroles/
> > >>> authentication/pages/SignInPage_de.html
> > >>> ------------------------------------------------------------
> ----------
> > >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> > >>> authroles/authentication/pages/SignInPage_de.html
> > >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > >>> authroles/authentication/pages/SignInPage_de.html
> > >>> new file mode 100644
> > >>> index 0000000..e4e6fca
> > >>> --- /dev/null
> > >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > >>> authroles/authentication/pages/SignInPage_de.html
> > >>> @@ -0,0 +1,12 @@
> > >>> +<?xml version="1.0" encoding="UTF-8" ?>
> > >>> +<html xmlns:wicket="http://wicket.apache.org">
> > >>> +<head>
> > >>> + <title>Anmelden</title>
> > >>> +</head>
> > >>> +<body>
> > >>> + <h2>Anmelden</h2>
> > >>> + <p>
> > >>> + <span wicket:id="signInPanel"/>
> > >>>
> > >>> This would be better to be a <div>, instead of <p><span>.
> > >> The default SingInPanel.html doesn't contain block elements but a
> custom
> > >> one might have one.
> > >>
> > >>
> > >> + </p>
> > >>> +</body>
> > >>> +</html>
> > >>>
> > >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> > >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/
> wicket/authroles/
> > >>> authentication/pages/SignOutPage_de.html
> > >>> ------------------------------------------------------------
> ----------
> > >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> > >>> authroles/authentication/pages/SignOutPage_de.html
> > >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > >>> authroles/authentication/pages/SignOutPage_de.html
> > >>> new file mode 100644
> > >>> index 0000000..b9d8b2f
> > >>> --- /dev/null
> > >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> > >>> authroles/authentication/pages/SignOutPage_de.html
> > >>> @@ -0,0 +1,25 @@
> > >>> +<?xml version="1.0" encoding="UTF-8" ?>
> > >>> +<!--
> > >>> + Licensed to the Apache Software Foundation (ASF) under one or
> more
> > >>> + contributor license agreements. See the NOTICE file distributed
> > with
> > >>> + this work for additional information regarding copyright
> ownership.
> > >>> + The ASF licenses this file to You under the Apache License,
> Version
> > >>> 2.0
> > >>> + (the "License"); you may not use this file except in compliance
> > with
> > >>> + the License. You may obtain a copy of the License at
> > >>> +
> > >>> + http://www.apache.org/licenses/LICENSE-2.0
> > >>> +
> > >>> + Unless required by applicable law or agreed to in writing,
> software
> > >>> + distributed under the License is distributed on an "AS IS" BASIS,
> > >>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > >>> implied.
> > >>> + See the License for the specific language governing permissions
> and
> > >>> + limitations under the License.
> > >>> +-->
> > >>> +<html>
> > >>> +<head>
> > >>> + <title>Abmeldung</title>
> > >>> +</head>
> > >>> +<body>
> > >>> + <h2>Auf Wiedersehen!</h2>
> > >>> +</body>
> > >>> +</html>
> > >>>
> > >>>
> > >>>
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
--
WBR
Maxim aka solomax
Re: wicket git commit: added german markups
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
I wonder who even uses those default pages.
In my experience I always needed custom styling and used custom pages.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Jan 23, 2017 at 9:20 AM, Maxim Solodovnik <so...@gmail.com>
wrote:
> I can contribute missing Russian page
> Or everything will be refactored to use wicket:messages?
>
> On Mon, Jan 23, 2017 at 3:14 PM, Sven Meier <sv...@meiers.net> wrote:
>
> > Hi Martin,
> >
> > I would use _**.html only if I needed different markup for each language.
> > Clearly this isn't the case here, so wicket:message with language
> specific
> > resource files would be a better solution.
> >
> > But wicket-auth-roles has done it that way apparently, so I didn't want
> to
> > change it.
> >
> > Jacek provided the polish translation and I just added the missing German
> > file.
> >
> > Have fun
> > Sven
> >
> >
> >
> > On 22.01.2017 23:01, Martin Grigorov wrote:
> >
> >> Hi Sven,
> >>
> >> What is the reason to prefer _de.html than _de.properties (and adding
> >> wicket:message and/or ResourceModel where needed) ?
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >> On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
> >>
> >> Repository: wicket
> >>> Updated Branches:
> >>> refs/heads/master 31727f854 -> 7596d9571
> >>>
> >>>
> >>> added german markups
> >>>
> >>>
> >>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> >>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7596d957
> >>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7596d957
> >>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7596d957
> >>>
> >>> Branch: refs/heads/master
> >>> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
> >>> Parents: 31727f8
> >>> Author: Sven Meier <sv...@apache.org>
> >>> Authored: Sat Jan 21 20:21:49 2017 +0100
> >>> Committer: Sven Meier <sv...@apache.org>
> >>> Committed: Sat Jan 21 20:21:49 2017 +0100
> >>>
> >>> ----------------------------------------------------------------------
> >>> .../authentication/pages/SignInPage_de.html | 12 ++++++++++
> >>> .../authentication/pages/SignOutPage_de.html | 25
> >>> ++++++++++++++++++++
> >>> 2 files changed, 37 insertions(+)
> >>> ----------------------------------------------------------------------
> >>>
> >>>
> >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
> >>> authentication/pages/SignInPage_de.html
> >>> ----------------------------------------------------------------------
> >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> >>> authroles/authentication/pages/SignInPage_de.html
> >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> >>> authroles/authentication/pages/SignInPage_de.html
> >>> new file mode 100644
> >>> index 0000000..e4e6fca
> >>> --- /dev/null
> >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> >>> authroles/authentication/pages/SignInPage_de.html
> >>> @@ -0,0 +1,12 @@
> >>> +<?xml version="1.0" encoding="UTF-8" ?>
> >>> +<html xmlns:wicket="http://wicket.apache.org">
> >>> +<head>
> >>> + <title>Anmelden</title>
> >>> +</head>
> >>> +<body>
> >>> + <h2>Anmelden</h2>
> >>> + <p>
> >>> + <span wicket:id="signInPanel"/>
> >>>
> >>> This would be better to be a <div>, instead of <p><span>.
> >> The default SingInPanel.html doesn't contain block elements but a custom
> >> one might have one.
> >>
> >>
> >> + </p>
> >>> +</body>
> >>> +</html>
> >>>
> >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> >>> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
> >>> authentication/pages/SignOutPage_de.html
> >>> ----------------------------------------------------------------------
> >>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
> >>> authroles/authentication/pages/SignOutPage_de.html
> >>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
> >>> authroles/authentication/pages/SignOutPage_de.html
> >>> new file mode 100644
> >>> index 0000000..b9d8b2f
> >>> --- /dev/null
> >>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
> >>> authroles/authentication/pages/SignOutPage_de.html
> >>> @@ -0,0 +1,25 @@
> >>> +<?xml version="1.0" encoding="UTF-8" ?>
> >>> +<!--
> >>> + Licensed to the Apache Software Foundation (ASF) under one or more
> >>> + contributor license agreements. See the NOTICE file distributed
> with
> >>> + this work for additional information regarding copyright ownership.
> >>> + The ASF licenses this file to You under the Apache License, Version
> >>> 2.0
> >>> + (the "License"); you may not use this file except in compliance
> with
> >>> + the License. You may obtain a copy of the License at
> >>> +
> >>> + http://www.apache.org/licenses/LICENSE-2.0
> >>> +
> >>> + Unless required by applicable law or agreed to in writing, software
> >>> + distributed under the License is distributed on an "AS IS" BASIS,
> >>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >>> implied.
> >>> + See the License for the specific language governing permissions and
> >>> + limitations under the License.
> >>> +-->
> >>> +<html>
> >>> +<head>
> >>> + <title>Abmeldung</title>
> >>> +</head>
> >>> +<body>
> >>> + <h2>Auf Wiedersehen!</h2>
> >>> +</body>
> >>> +</html>
> >>>
> >>>
> >>>
> >
>
>
> --
> WBR
> Maxim aka solomax
>
Re: wicket git commit: added german markups
Posted by Maxim Solodovnik <so...@gmail.com>.
I can contribute missing Russian page
Or everything will be refactored to use wicket:messages?
On Mon, Jan 23, 2017 at 3:14 PM, Sven Meier <sv...@meiers.net> wrote:
> Hi Martin,
>
> I would use _**.html only if I needed different markup for each language.
> Clearly this isn't the case here, so wicket:message with language specific
> resource files would be a better solution.
>
> But wicket-auth-roles has done it that way apparently, so I didn't want to
> change it.
>
> Jacek provided the polish translation and I just added the missing German
> file.
>
> Have fun
> Sven
>
>
>
> On 22.01.2017 23:01, Martin Grigorov wrote:
>
>> Hi Sven,
>>
>> What is the reason to prefer _de.html than _de.properties (and adding
>> wicket:message and/or ResourceModel where needed) ?
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
>>
>> Repository: wicket
>>> Updated Branches:
>>> refs/heads/master 31727f854 -> 7596d9571
>>>
>>>
>>> added german markups
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7596d957
>>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7596d957
>>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7596d957
>>>
>>> Branch: refs/heads/master
>>> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
>>> Parents: 31727f8
>>> Author: Sven Meier <sv...@apache.org>
>>> Authored: Sat Jan 21 20:21:49 2017 +0100
>>> Committer: Sven Meier <sv...@apache.org>
>>> Committed: Sat Jan 21 20:21:49 2017 +0100
>>>
>>> ----------------------------------------------------------------------
>>> .../authentication/pages/SignInPage_de.html | 12 ++++++++++
>>> .../authentication/pages/SignOutPage_de.html | 25
>>> ++++++++++++++++++++
>>> 2 files changed, 37 insertions(+)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
>>> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
>>> authentication/pages/SignInPage_de.html
>>> ----------------------------------------------------------------------
>>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
>>> authroles/authentication/pages/SignInPage_de.html
>>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
>>> authroles/authentication/pages/SignInPage_de.html
>>> new file mode 100644
>>> index 0000000..e4e6fca
>>> --- /dev/null
>>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
>>> authroles/authentication/pages/SignInPage_de.html
>>> @@ -0,0 +1,12 @@
>>> +<?xml version="1.0" encoding="UTF-8" ?>
>>> +<html xmlns:wicket="http://wicket.apache.org">
>>> +<head>
>>> + <title>Anmelden</title>
>>> +</head>
>>> +<body>
>>> + <h2>Anmelden</h2>
>>> + <p>
>>> + <span wicket:id="signInPanel"/>
>>>
>>> This would be better to be a <div>, instead of <p><span>.
>> The default SingInPanel.html doesn't contain block elements but a custom
>> one might have one.
>>
>>
>> + </p>
>>> +</body>
>>> +</html>
>>>
>>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
>>> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
>>> authentication/pages/SignOutPage_de.html
>>> ----------------------------------------------------------------------
>>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
>>> authroles/authentication/pages/SignOutPage_de.html
>>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
>>> authroles/authentication/pages/SignOutPage_de.html
>>> new file mode 100644
>>> index 0000000..b9d8b2f
>>> --- /dev/null
>>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
>>> authroles/authentication/pages/SignOutPage_de.html
>>> @@ -0,0 +1,25 @@
>>> +<?xml version="1.0" encoding="UTF-8" ?>
>>> +<!--
>>> + Licensed to the Apache Software Foundation (ASF) under one or more
>>> + contributor license agreements. See the NOTICE file distributed with
>>> + this work for additional information regarding copyright ownership.
>>> + The ASF licenses this file to You under the Apache License, Version
>>> 2.0
>>> + (the "License"); you may not use this file except in compliance with
>>> + the License. You may obtain a copy of the License at
>>> +
>>> + http://www.apache.org/licenses/LICENSE-2.0
>>> +
>>> + Unless required by applicable law or agreed to in writing, software
>>> + distributed under the License is distributed on an "AS IS" BASIS,
>>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>> implied.
>>> + See the License for the specific language governing permissions and
>>> + limitations under the License.
>>> +-->
>>> +<html>
>>> +<head>
>>> + <title>Abmeldung</title>
>>> +</head>
>>> +<body>
>>> + <h2>Auf Wiedersehen!</h2>
>>> +</body>
>>> +</html>
>>>
>>>
>>>
>
--
WBR
Maxim aka solomax
Re: wicket git commit: added german markups
Posted by Sven Meier <sv...@meiers.net>.
Hi Martin,
I would use _**.html only if I needed different markup for each
language. Clearly this isn't the case here, so wicket:message with
language specific resource files would be a better solution.
But wicket-auth-roles has done it that way apparently, so I didn't want
to change it.
Jacek provided the polish translation and I just added the missing
German file.
Have fun
Sven
On 22.01.2017 23:01, Martin Grigorov wrote:
> Hi Sven,
>
> What is the reason to prefer _de.html than _de.properties (and adding
> wicket:message and/or ResourceModel where needed) ?
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Sat, Jan 21, 2017 at 8:22 PM, <sv...@apache.org> wrote:
>
>> Repository: wicket
>> Updated Branches:
>> refs/heads/master 31727f854 -> 7596d9571
>>
>>
>> added german markups
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/7596d957
>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/7596d957
>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/7596d957
>>
>> Branch: refs/heads/master
>> Commit: 7596d9571e4c1c76768e4a7a7cc8293d63927115
>> Parents: 31727f8
>> Author: Sven Meier <sv...@apache.org>
>> Authored: Sat Jan 21 20:21:49 2017 +0100
>> Committer: Sven Meier <sv...@apache.org>
>> Committed: Sat Jan 21 20:21:49 2017 +0100
>>
>> ----------------------------------------------------------------------
>> .../authentication/pages/SignInPage_de.html | 12 ++++++++++
>> .../authentication/pages/SignOutPage_de.html | 25 ++++++++++++++++++++
>> 2 files changed, 37 insertions(+)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
>> authentication/pages/SignInPage_de.html
>> ----------------------------------------------------------------------
>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
>> authroles/authentication/pages/SignInPage_de.html
>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
>> authroles/authentication/pages/SignInPage_de.html
>> new file mode 100644
>> index 0000000..e4e6fca
>> --- /dev/null
>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
>> authroles/authentication/pages/SignInPage_de.html
>> @@ -0,0 +1,12 @@
>> +<?xml version="1.0" encoding="UTF-8" ?>
>> +<html xmlns:wicket="http://wicket.apache.org">
>> +<head>
>> + <title>Anmelden</title>
>> +</head>
>> +<body>
>> + <h2>Anmelden</h2>
>> + <p>
>> + <span wicket:id="signInPanel"/>
>>
> This would be better to be a <div>, instead of <p><span>.
> The default SingInPanel.html doesn't contain block elements but a custom
> one might have one.
>
>
>> + </p>
>> +</body>
>> +</html>
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/
>> 7596d957/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/
>> authentication/pages/SignOutPage_de.html
>> ----------------------------------------------------------------------
>> diff --git a/wicket-auth-roles/src/main/java/org/apache/wicket/
>> authroles/authentication/pages/SignOutPage_de.html
>> b/wicket-auth-roles/src/main/java/org/apache/wicket/
>> authroles/authentication/pages/SignOutPage_de.html
>> new file mode 100644
>> index 0000000..b9d8b2f
>> --- /dev/null
>> +++ b/wicket-auth-roles/src/main/java/org/apache/wicket/
>> authroles/authentication/pages/SignOutPage_de.html
>> @@ -0,0 +1,25 @@
>> +<?xml version="1.0" encoding="UTF-8" ?>
>> +<!--
>> + Licensed to the Apache Software Foundation (ASF) under one or more
>> + contributor license agreements. See the NOTICE file distributed with
>> + this work for additional information regarding copyright ownership.
>> + The ASF licenses this file to You under the Apache License, Version 2.0
>> + (the "License"); you may not use this file except in compliance with
>> + the License. You may obtain a copy of the License at
>> +
>> + http://www.apache.org/licenses/LICENSE-2.0
>> +
>> + Unless required by applicable law or agreed to in writing, software
>> + distributed under the License is distributed on an "AS IS" BASIS,
>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> + See the License for the specific language governing permissions and
>> + limitations under the License.
>> +-->
>> +<html>
>> +<head>
>> + <title>Abmeldung</title>
>> +</head>
>> +<body>
>> + <h2>Auf Wiedersehen!</h2>
>> +</body>
>> +</html>
>>
>>