You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Alf Høgemark (JIRA)" <ji...@apache.org> on 2012/09/25 18:28:09 UTC
[jira] [Created] (HTTPCLIENT-1235) Add javadoc to Executor to
explain that response must be handled to avoid connection leakage
Alf Høgemark created HTTPCLIENT-1235:
----------------------------------------
Summary: Add javadoc to Executor to explain that response must be handled to avoid connection leakage
Key: HTTPCLIENT-1235
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1235
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: Fluent HC
Reporter: Alf Høgemark
Priority: Minor
Attachments: 1235.txt
Some javadoc should be added to the Fluent HC, so that developers are made aware that they need to handle a reponse from an Executor.
I had a case where I did a logout call, and I did not care to handle the response, because I was not interested if the logout succeeded or not. This then leads to one http connection never being returned to the pool per logout call I made. So I had to change my code so I called discardContent on the Executor.
So some javadoc should be added to the Executor and Response classes in client.fluent package
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Resolved] (HTTPCLIENT-1235) Add javadoc to Executor to
explain that response must be handled to avoid connection leakage
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-1235.
-------------------------------------------
Resolution: Fixed
Fix Version/s: 4.2.2
Patch checked in with some minor changes. Many thanks, Alf, for contributing it.
Oleg
> Add javadoc to Executor to explain that response must be handled to avoid connection leakage
> --------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1235
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1235
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Fluent HC
> Reporter: Alf Høgemark
> Priority: Minor
> Labels: documentation
> Fix For: 4.2.2
>
> Attachments: 1235.txt
>
>
> Some javadoc should be added to the Fluent HC, so that developers are made aware that they need to handle a reponse from an Executor.
> I had a case where I did a logout call, and I did not care to handle the response, because I was not interested if the logout succeeded or not. This then leads to one http connection never being returned to the pool per logout call I made. So I had to change my code so I called discardContent on the Executor.
> So some javadoc should be added to the Executor and Response classes in client.fluent package
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCLIENT-1235) Add javadoc to Executor to
explain that response must be handled to avoid connection leakage
Posted by "Alf Høgemark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alf Høgemark updated HTTPCLIENT-1235:
-------------------------------------
Attachment: 1235.txt
Suggested patch to add javadoc
> Add javadoc to Executor to explain that response must be handled to avoid connection leakage
> --------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1235
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1235
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Fluent HC
> Reporter: Alf Høgemark
> Priority: Minor
> Labels: documentation
> Attachments: 1235.txt
>
>
> Some javadoc should be added to the Fluent HC, so that developers are made aware that they need to handle a reponse from an Executor.
> I had a case where I did a logout call, and I did not care to handle the response, because I was not interested if the logout succeeded or not. This then leads to one http connection never being returned to the pool per logout call I made. So I had to change my code so I called discardContent on the Executor.
> So some javadoc should be added to the Executor and Response classes in client.fluent package
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org