You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Fang Fang Chen <lu...@163.com> on 2012/11/06 13:41:45 UTC

Review Request: some unit test case failed with open JDK

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/
-----------------------------------------------------------

Review request for pig.


Description
-------

For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn


This addresses bug PIG-2405.
    https://issues.apache.org/jira/browse/PIG-2405


Diffs
-----

  trunk/test/org/apache/pig/test/TestDataModel.java 1405688 
  trunk/test/org/apache/pig/test/TestMRCompiler.java 1405688 
  trunk/test/org/apache/pig/test/TestPruneColumn.java 1405688 

Diff: https://reviews.apache.org/r/7898/diff/


Testing
-------

The 3 UTs passed in both sun and opensource JDK.
test-commit passed.
test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 12 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.


Thanks,

Fang Fang Chen

Re: Review Request: PIG-2405: some unit test case failed with open JDK

Posted by Fang Fang Chen <lu...@163.com>.

> On Nov. 7, 2012, 9 p.m., Cheolsoo Park wrote:
> > Looks good. Thanks Fangfang!

Thanks Cheolsoo for review.


- Fang Fang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/#review13222
-----------------------------------------------------------


On Nov. 7, 2012, 10:55 a.m., Fang Fang Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7898/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 10:55 a.m.)
> 
> 
> Review request for pig.
> 
> 
> Description
> -------
> 
> For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn
> 
> 
> This addresses bug PIG-2405.
>     https://issues.apache.org/jira/browse/PIG-2405
> 
> 
> Diffs
> -----
> 
>   trunk/test/org/apache/pig/test/TestDataModel.java 1406517 
>   trunk/test/org/apache/pig/test/TestMRCompiler.java 1406517 
>   trunk/test/org/apache/pig/test/TestPruneColumn.java 1406517 
>   trunk/test/org/apache/pig/test/utils/TestHelper.java 1406517 
> 
> Diff: https://reviews.apache.org/r/7898/diff/
> 
> 
> Testing
> -------
> 
> The 3 UTs passed in both sun and opensource JDK.
> test-commit passed.
> test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
> [exec] -1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 12 new or modified tests.
> [exec]
> [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> 
> 
> Thanks,
> 
> Fang Fang Chen
> 
>

Re: Review Request: PIG-2405: some unit test case failed with open JDK

Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/#review13222
-----------------------------------------------------------

Ship it!


Looks good. Thanks Fangfang!

- Cheolsoo Park


On Nov. 7, 2012, 10:55 a.m., Fang Fang Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7898/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 10:55 a.m.)
> 
> 
> Review request for pig.
> 
> 
> Description
> -------
> 
> For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn
> 
> 
> This addresses bug PIG-2405.
>     https://issues.apache.org/jira/browse/PIG-2405
> 
> 
> Diffs
> -----
> 
>   trunk/test/org/apache/pig/test/TestDataModel.java 1406517 
>   trunk/test/org/apache/pig/test/TestMRCompiler.java 1406517 
>   trunk/test/org/apache/pig/test/TestPruneColumn.java 1406517 
>   trunk/test/org/apache/pig/test/utils/TestHelper.java 1406517 
> 
> Diff: https://reviews.apache.org/r/7898/diff/
> 
> 
> Testing
> -------
> 
> The 3 UTs passed in both sun and opensource JDK.
> test-commit passed.
> test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
> [exec] -1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 12 new or modified tests.
> [exec]
> [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> 
> 
> Thanks,
> 
> Fang Fang Chen
> 
>

Re: Review Request: PIG-2405: some unit test case failed with open JDK

Posted by Fang Fang Chen <lu...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/
-----------------------------------------------------------

(Updated Nov. 8, 2012, 2:46 a.m.)


Review request for pig.


Description
-------

For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn


This addresses bug PIG-2405.
    https://issues.apache.org/jira/browse/PIG-2405


Diffs (updated)
-----

  trunk/test/org/apache/pig/test/TestDataModel.java 1406517 
  trunk/test/org/apache/pig/test/TestMRCompiler.java 1406517 
  trunk/test/org/apache/pig/test/TestPruneColumn.java 1406517 
  trunk/test/org/apache/pig/test/utils/TestHelper.java 1406517 

Diff: https://reviews.apache.org/r/7898/diff/


Testing
-------

The 3 UTs passed in both sun and opensource JDK.
test-commit passed.
test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 12 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.


Thanks,

Fang Fang Chen

Re: Review Request: PIG-2405: some unit test case failed with open JDK

Posted by Fang Fang Chen <lu...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/
-----------------------------------------------------------

(Updated Nov. 7, 2012, 10:55 a.m.)


Review request for pig.


Changes
-------

Update patch file.


Description
-------

For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn


This addresses bug PIG-2405.
    https://issues.apache.org/jira/browse/PIG-2405


Diffs (updated)
-----

  trunk/test/org/apache/pig/test/TestDataModel.java 1406517 
  trunk/test/org/apache/pig/test/TestMRCompiler.java 1406517 
  trunk/test/org/apache/pig/test/TestPruneColumn.java 1406517 
  trunk/test/org/apache/pig/test/utils/TestHelper.java 1406517 

Diff: https://reviews.apache.org/r/7898/diff/


Testing
-------

The 3 UTs passed in both sun and opensource JDK.
test-commit passed.
test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 12 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.


Thanks,

Fang Fang Chen

Re: Review Request: PIG-2405: some unit test case failed with open JDK

Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/#review13183
-----------------------------------------------------------


Hi Fangfang,

Overall looks good. I like how you fixed TestMRCompiler. Thank you very much for taking my comments seriously. :-)

My main comment is can you please re-factor sortUDFs() and sortLogMessages() into a single helper function and add that to test/org/apache/pig/test/utils/TestHelper.java? Two functions are almost identical except two things:

1) Different reg. exp. You can probably parameterize this.
2) sortUDFs() takes a String while sortLogMessages() takes a List<String>. You can probably take "String[] goldenArray = goldenString.split("\n");" out of the function and pass it as a List<String>.

In addition, I have a few minor nits inline. Please let me know if you don't agree with me.

Thanks!


trunk/test/org/apache/pig/test/TestMRCompiler.java
<https://reviews.apache.org/r/7898/#comment28358>

    Please remove the white spaces in the line.



trunk/test/org/apache/pig/test/TestMRCompiler.java
<https://reviews.apache.org/r/7898/#comment28354>

    This can be simplified as follows:
    
    Collections.sort(Arrays.asList(out));



trunk/test/org/apache/pig/test/TestMRCompiler.java
<https://reviews.apache.org/r/7898/#comment28355>

    This can be simplified as follows:
    
    for (int j = 0; j < out.length; j++) {
        replaceString += (j > 0 ? ", " + out[j] : out[j]);
    }



trunk/test/org/apache/pig/test/TestPruneColumn.java
<https://reviews.apache.org/r/7898/#comment28357>

    Please remove the white spaces in the line.



trunk/test/org/apache/pig/test/TestPruneColumn.java
<https://reviews.apache.org/r/7898/#comment28350>

    This can be simplified as follows:
    
    Collections.sort(Arrays.asList(out));



trunk/test/org/apache/pig/test/TestPruneColumn.java
<https://reviews.apache.org/r/7898/#comment28351>

    This can be simplified as follows:
    
    for (int j = 0; j < out.length; j++) {
        replaceString += (j > 0 ? ", " + out[j] : out[j]);
    }



trunk/test/org/apache/pig/test/TestPruneColumn.java
<https://reviews.apache.org/r/7898/#comment28352>

    This can be simplified as follows:
    
    Collections.sort(Arrays.asList(sArray));



trunk/test/org/apache/pig/test/TestPruneColumn.java
<https://reviews.apache.org/r/7898/#comment28353>

    Please remove the trailing white space.


- Cheolsoo Park


On Nov. 6, 2012, 12:57 p.m., Fang Fang Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7898/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 12:57 p.m.)
> 
> 
> Review request for pig.
> 
> 
> Description
> -------
> 
> For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn
> 
> 
> This addresses bug PIG-2405.
>     https://issues.apache.org/jira/browse/PIG-2405
> 
> 
> Diffs
> -----
> 
>   trunk/test/org/apache/pig/test/TestDataModel.java 1405688 
>   trunk/test/org/apache/pig/test/TestMRCompiler.java 1405688 
>   trunk/test/org/apache/pig/test/TestPruneColumn.java 1405688 
> 
> Diff: https://reviews.apache.org/r/7898/diff/
> 
> 
> Testing
> -------
> 
> The 3 UTs passed in both sun and opensource JDK.
> test-commit passed.
> test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
> [exec] -1 overall.
> [exec]
> [exec] +1 @author. The patch does not contain any @author tags.
> [exec]
> [exec] +1 tests included. The patch appears to include 12 new or modified tests.
> [exec]
> [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
> [exec]
> [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> [exec]
> [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
> [exec]
> [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> 
> 
> Thanks,
> 
> Fang Fang Chen
> 
>

Re: Review Request: PIG-2405: some unit test case failed with open JDK

Posted by Fang Fang Chen <lu...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7898/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 12:57 p.m.)


Review request for pig.


Changes
-------

Mark the Jira number in Summary.


Summary (updated)
-----------------

PIG-2405: some unit test case failed with open JDK


Description
-------

For PIG-2405, fix 3 UTs:TestDataModel, TestMRCompiler, and TestPruneColumn


This addresses bug PIG-2405.
    https://issues.apache.org/jira/browse/PIG-2405


Diffs
-----

  trunk/test/org/apache/pig/test/TestDataModel.java 1405688 
  trunk/test/org/apache/pig/test/TestMRCompiler.java 1405688 
  trunk/test/org/apache/pig/test/TestPruneColumn.java 1405688 

Diff: https://reviews.apache.org/r/7898/diff/


Testing
-------

The 3 UTs passed in both sun and opensource JDK.
test-commit passed.
test-patch failed, but the failure isn't introduced by the patch. There are [javadoc] 38 warnings in original trunk branch.[PIG-3033]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 12 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.


Thanks,

Fang Fang Chen