You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/07/03 22:04:58 UTC
[GitHub] [spark] hvanhovell opened a new pull request, #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
hvanhovell opened a new pull request, #41836:
URL: https://github.com/apache/spark/pull/41836
### What changes were proposed in this pull request?
This PR prepares moving DataType parsing to sql/api. Basically it puts all DataType parsing functionality in a super class of regular parsing. We cannot move the parser just yet because that need to happen at the same time as DataType.
### Why are the changes needed?
We want the Spark Connect Scala Client to use a restricted class path. DataType will be one of the shared classes, to move DataType we need to move DataType parsing.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Modified existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
URL: https://github.com/apache/spark/pull/41836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #41836:
URL: https://github.com/apache/spark/pull/41836#issuecomment-1619491849
Per my understanding, this PR creates a new interface for DataType parsing and also extract the parsing code. I guess the ultimate goal is we only move Datatype parsing (so not entire SQL grammar) to sql/api.
The idea LGTM. This is the best we can achieve for the parser relocation.
For the detailed interfaces, I am ok with the splitting so also LGTM. However I may not be the best person to comment the current way of constructing the new interface in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #41836:
URL: https://github.com/apache/spark/pull/41836#issuecomment-1622441951
Merging for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41836:
URL: https://github.com/apache/spark/pull/41836#issuecomment-1622747741
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #41836: [SPARK-44282][CONNECT] Prepare DataType parsing for use in Spark Connect Scala Client
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #41836:
URL: https://github.com/apache/spark/pull/41836#issuecomment-1619198402
cc @amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org