You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/19 15:03:02 UTC

[GitHub] [airflow] edithturn opened a new pull request #20957: [WIP] Re-verify enough resources for Docker

edithturn opened a new pull request #20957:
URL: https://github.com/apache/airflow/pull/20957


   This PR is to fix the one that was merged: https://github.com/apache/airflow/pull/20763
   Point:
   The runners have different filesystems to check the disk available. The one that is mounted should be taken to extract data of the disk available in the runners.
   
   Please keep in mind it is a work in progress this is Work in Progress, and for now, I am printing "df -h" on the runner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #20957: Verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20957:
URL: https://github.com/apache/airflow/pull/20957


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: Verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017762437


   Careful :tada: :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: Verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017792790


   I think it worked! https://github.com/apache/airflow/runs/4886367996?check_suite_focus=true 👀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017758538


   > I am running it in my PR to check if it will also work for committers: [#](https://github.com/apache/airflow/pull/20959)
   ![Screenshot from 2022-01-20 12-40-54](https://user-images.githubusercontent.com/58795858/150392705-95046c06-c6cb-4a04-b665-9389e58aa078.png)
   
   @potiuk this is the result on your runner. I also checked the one I sent, it finished successfully: https://github.com/apache/airflow/actions/runs/1724358952
   
   let me know what are you thoughts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016970558


   @potiuk I fixed it. I am considerign:
   
   `# Disk current available
       partition_usage = psutil.disk_usage('/')
       disk_available = round(get_size(partition_usage.free))`
   
   Also, I am round the value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016623613


   You will be able to see it here: https://github.com/apache/airflow/pull/20959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017668388


   FYI @edithturn : I am running it in my PR to check if it will also work for committers: https://github.com/apache/airflow/pull/20959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn edited a comment on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn edited a comment on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016970558


   @potiuk I fixed it. I am considering, the mount point:
   you can see it here: https://github.com/apache/airflow/runs/4871033753?check_suite_focus=true#step:7:94
   
   `# Disk current available
       partition_usage = psutil.disk_usage('/')
       disk_available = round(get_size(partition_usage.free))`
   
   Also, I rounded the value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017710948


   > Are there things you can see in CI's processes that we can't?
   
   Nope. It's just where the builds are run. There is no  difference in what we see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn edited a comment on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn edited a comment on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016641341


   @potiuk I was wondering how to make it to avoid notifying others, thank you so much! 🙏🏼 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016609755


   I think this is a different change ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016641341


   ohhh, @potiuk I was wondering how to make it to avoid notifying others, thank you so much! 🙏🏼 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017696681


   Thank you so much @potiuk, I also sent the last test, it takes time, especially the one which build the image. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: Verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017763333


   🤞🏼 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016621666


   You won't see it because you are not committer :). I will have to push it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017708669


   > > What defines a "committer"?
   > 
   > This list:
   > 
   > https://github.com/apache/airflow/blob/c13558186c678c15938db5ea3a65f948061af72a/.github/workflows/ci.yml#L96
   
   I see you have elevated privileges for Github events, right?
   Are there things you can see in CI's processes that we can't?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: Verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017762595


   :crossed_fingers: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn edited a comment on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn edited a comment on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016970558


   @potiuk I fixed it. I am considering, the mount point:
   you can see it here: https://github.com/apache/airflow/runs/4871033753?check_suite_focus=true#step:7:90
   
   `# Disk current available
       partition_usage = psutil.disk_usage('/')
       disk_available = round(get_size(partition_usage.free))`
   
   Also, I rounded the value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017703950


   > What defines a "committer"?
   
   This list: https://github.com/apache/airflow/blob/c13558186c678c15938db5ea3a65f948061af72a/.github/workflows/ci.yml#L96


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1017697867


   What defines a "committer"? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] edithturn commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
edithturn commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016611539


   @potiuk I am checking this data in the runner:
   ![Screenshot from 2022-01-19 10-58-14](https://user-images.githubusercontent.com/58795858/150167773-c5531b33-5c47-4e67-8e32-1f669c5f24aa.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #20957: [WIP] Re-verify enough resources for Docker

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20957:
URL: https://github.com/apache/airflow/pull/20957#issuecomment-1016638505


   BTW. @edithturn  When you create a PR you can create it as draft (not very well visible drop-down next to "create Pull Request" button if you want to do something for test - no need to prefix things with [WIP] . You can also convert it to draft and back any time via "convert to draft" link (or "Ready for Review" button). I will convert it to draft now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org