You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/04 04:20:23 UTC
[GitHub] [incubator-seatunnel] simon824 opened a new pull request #1394: [Bug][Transform] Fix Split transfrom register failed
simon824 opened a new pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394
## Purpose of this pull request
closed #1393
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1394: [Bug][Transform] Fix spark&flink split transfrom udf register
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394#discussion_r819528140
##########
File path: seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/batch/FlinkBatchExecution.java
##########
@@ -67,6 +67,7 @@ public void start(List<FlinkBatchSource> sources, List<FlinkBatchTransform> tran
}
input = transform.processBatch(flinkEnvironment, dataSet);
registerResultTable(transform, input);
+ transform.registerFunction(flinkEnvironment);
Review comment:
@simon824 What is the problem that this line of code is added to solve? If it's a bug, it's better to submit a separate PR to fix it, don't you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu merged pull request #1394: [Bug][Transform] Fix spark&flink split transfrom udf register
Posted by GitBox <gi...@apache.org>.
wuchunfu merged pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1394: [Bug][Transform] Fix spark&flink split transfrom udf register
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394#issuecomment-1060672255
Well done, looking forward to your next contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] simon824 commented on a change in pull request #1394: [Bug][Transform] Fix Split transfrom register failed
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394#discussion_r819294080
##########
File path: docs/en/spark/configuration/transform-plugins/Split.md
##########
@@ -4,19 +4,19 @@
## Description
-Split string according to `delimiter`
+Split string according to `separator`
Review comment:
the option `delimiter` in `flink-split-transform` are is named `separator`, so i unify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] simon824 commented on a change in pull request #1394: [Bug][Transform] Fix spark&flink split transfrom udf register
Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394#discussion_r820035516
##########
File path: seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/batch/FlinkBatchExecution.java
##########
@@ -67,6 +67,7 @@ public void start(List<FlinkBatchSource> sources, List<FlinkBatchTransform> tran
}
input = transform.processBatch(flinkEnvironment, dataSet);
registerResultTable(transform, input);
+ transform.registerFunction(flinkEnvironment);
Review comment:
The purpose of this pr is to fix the problem that udf is not registered, and this line is register flink batch udf, IMO we don't need create a new pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1394: [Bug][Transform] Fix Split transfrom register failed
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394#issuecomment-1058834703
@simon824 When modifying the code, you should also update the corresponding documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1394: [Bug][Transform] Fix spark&flink split transfrom udf register
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1394:
URL: https://github.com/apache/incubator-seatunnel/pull/1394#issuecomment-1061804567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org