You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Shockp (via GitHub)" <gi...@apache.org> on 2026/04/23 10:27:51 UTC

[PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Shockp opened a new pull request, #49848:
URL: https://github.com/apache/arrow/pull/49848

   ### Rationale for this change
   
   In Arrow, null bitmaps are optional and represented by `nullptr` when a column contains no nulls. Previously, conjoining two optional bitmaps required downstream code to manually handle the `nullptr` checks and memory allocations. This change centralizes that logic into a single, highly optimized utility function.
   
   ### What changes are included in this PR?
   
   * Added `OptionalBitmapAnd` to `cpp/src/arrow/util/bitmap_ops.h` and `bitmap_ops.cc`.
   * The implementation safely handles the four possible memory permutations with minimal allocations:
     1. Both buffers `nullptr`: Returns `nullptr`.
     2. Left is `nullptr`: Returns a copy of the right buffer.
     3. Right is `nullptr`: Returns a copy of the left buffer.
     4. Both valid: Defers to the low-level `BitmapAnd` function.
   
   ### Are these changes tested?
   
   Yes. I added a new test case (`OptionalBitmapAnd`) to `cpp/src/arrow/util/bitmap_test.cc` that explicitly verifies the correct buffer allocation and bitwise output for all four memory states.
   
   ### Are there any user-facing changes?
   
   No. This simply exposes a new C++ utility for internal development.
   
   Closes #45819


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4354280787

   Gracias! @raulcd . No estoy seguro de si tu puedes responder al comentario de arriba, por saber las etiquetas que tengo que buscar para esos problemas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4353469731

   @github-actions crossbow submit -g cpp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #49848:
URL: https://github.com/apache/arrow/pull/49848#discussion_r3147508483


##########
cpp/src/arrow/util/bitmap_ops.h:
##########
@@ -166,6 +166,29 @@ ARROW_EXPORT
 void BitmapAnd(const uint8_t* left, int64_t left_offset, const uint8_t* right,
                int64_t right_offset, int64_t length, int64_t out_offset, uint8_t* out);
 
+/// \brief Do a "bitmap and" on two buffers, handling null buffers safely.
+///
+/// If both buffers are null, returns nullptr.
+/// If one buffer is null, allocates a new buffer and copies the valid buffer into it.
+/// If both buffers are valid, allocates a new buffer and performs a bitwise AND.
+///
+/// \param[in] pool memory pool to allocate memory from
+/// \param[in] left left source buffer (may be null)
+/// \param[in] left_offset bit offset into the left buffer
+/// \param[in] right right source buffer (may be null)
+/// \param[in] right_offset bit offset into the right buffer
+/// \param[in] length number of bits to compute
+/// \param[in] out_offset bit offset into the output buffer
+///
+/// \return Resulting buffer (may be null)
+ARROW_EXPORT
+Result<std::shared_ptr<Buffer>> OptionalBitmapAnd(MemoryPool* pool,
+                                                  const std::shared_ptr<Buffer>& left,
+                                                  int64_t left_offset,
+                                                  const std::shared_ptr<Buffer>& right,
+                                                  int64_t right_offset, int64_t length,
+                                                  int64_t out_offset);

Review Comment:
   Can probably make `out_offset` optional? In many cases it'll simply be zero.
   
   ```suggestion
                                                     int64_t out_offset = 0);
   ```



##########
cpp/src/arrow/util/bitmap_test.cc:
##########
@@ -1236,6 +1237,45 @@ TEST(BitmapOpTest, PartialLeadingByteSafety) {
   }
 }
 
+TEST(BitmapOpTest, OptionalBitmapAnd) {
+  MemoryPool* pool = default_memory_pool();
+  int64_t length = 16;
+  int64_t phys_bits = length;
+
+  // Create two distinct test buffers
+  ASSERT_OK_AND_ASSIGN(auto buf1, AllocateEmptyBitmap(phys_bits, pool));
+  ASSERT_OK_AND_ASSIGN(auto buf2, AllocateEmptyBitmap(phys_bits, pool));
+
+  // Fill buf1 with 1s (true)
+  std::memset(buf1->mutable_data(), 0xFF, buf1->size());
+  // Fill buf2 with alternating bits 01010101 (0xAA)
+  std::memset(buf2->mutable_data(), 0xAA, buf2->size());
+
+  // State 1: Both nullptr
+  ASSERT_OK_AND_ASSIGN(auto result1,
+                       OptionalBitmapAnd(pool, nullptr, 0, nullptr, 0, length, 0));
+  ASSERT_EQ(result1, nullptr);
+
+  // State 2: Left nullptr, Right valid (Should copy Right)
+  ASSERT_OK_AND_ASSIGN(auto result2,
+                       OptionalBitmapAnd(pool, nullptr, 0, buf2, 0, length, 0));
+  ASSERT_NE(result2, nullptr);
+  EXPECT_TRUE(BitmapEquals(buf2->data(), 0, result2->data(), 0, length));
+
+  // State 3: Left valid, Right nullptr (Should copy Left)
+  ASSERT_OK_AND_ASSIGN(auto result3,
+                       OptionalBitmapAnd(pool, buf1, 0, nullptr, 0, length, 0));
+  ASSERT_NE(result3, nullptr);
+  EXPECT_TRUE(BitmapEquals(buf1->data(), 0, result3->data(), 0, length));
+
+  // State 4: Both valid (Should perform Bitwise AND)
+  ASSERT_OK_AND_ASSIGN(auto result4,
+                       OptionalBitmapAnd(pool, buf1, 0, buf2, 0, length, 0));
+  ASSERT_NE(result4, nullptr);
+  // Since buf1 is all 1s, (buf1 AND buf2) should perfectly equal buf2

Review Comment:
   This is an easy case to test, but can we test with inputs where the output is not trivially equal to one of the inputs?



##########
cpp/src/arrow/util/bitmap_ops.cc:
##########
@@ -329,6 +329,25 @@ bool OptionalBitmapEquals(const std::shared_ptr<Buffer>& left, int64_t left_offs
                               right ? right->data() : nullptr, right_offset, length);
 }
 
+Result<std::shared_ptr<Buffer>> OptionalBitmapAnd(MemoryPool* pool,
+                                                  const std::shared_ptr<Buffer>& left,
+                                                  int64_t left_offset,
+                                                  const std::shared_ptr<Buffer>& right,
+                                                  int64_t right_offset, int64_t length,
+                                                  int64_t out_offset) {
+  if (left == nullptr && right == nullptr) {
+    return nullptr;
+  }
+  if (left == nullptr) {
+    return CopyBitmap(pool, right->data(), right_offset, length, out_offset);
+  }

Review Comment:
   I think we can go one step further: if `(out_offset - right_offset) % 8 == 0`, then we don't need to copy the bitmap at all, we can just do a simple slice of the input.



##########
testing:
##########


Review Comment:
   Hmm, it seems you need to revert the `testing` submodule to its git main state, can you do that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4334578230

   I just updated it to use the new `OptionalBitmapAnd` utility @pitrou. The zero-copy logic is implemented, and it replaces that manual `if/else` block with a single, clean macro:
   
   ```cpp
         ARROW_ASSIGN_OR_RAISE(
             null_bitmap,
             arrow::internal::OptionalBitmapAnd(pool_, null_bitmap, /*left_offset=*/0,
                                                no_nulls, /*right_offset=*/0,
                                                num_groups_));


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4353596471

   Thanks so much for the review and the approval, @pitrou!
   
   I'm already looking forward to my next contribution. I am really focused on building a strong foundation in High-Performance Computing. Are there specific issue tags or components you would recommend I search for if I want to tackle very low-level C++ tasks (like SIMD, memory/buffer management) or dive into CUDA/GPU-related issues? 
   
   Thanks again for all the guidance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #49848:
URL: https://github.com/apache/arrow/pull/49848


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4333280091

   > Quick question on the API: I noticed the other functions in bitmap_ops.h (like BitmapAnd, BitmapOr, etc.) don't currently have out_offset = 0 as a default. Would it be worth unifying those for consistency in a separate, follow-up PR, or is it safer to leave the existing signatures as-is?
   
   Ah, that's a good point. Well, perhaps we can keep them as they are for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4354291945

   After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 9abd6d328598080df628e4892c53daaf090d3d4f.
   
   None of the specified runs were found on the Conbench server.
   
   The [full Conbench report](https://github.com/apache/arrow/runs/73812563759) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4328467592

   Reverted the testing submodule, added the out_offset default, implemented the zero-copy slicing for byte-aligned offsets, and updated the tests to use BitmapFromVector for non-trivial inputs. Let me know how it looks! @pitrou 
   
   Quick question on the API: I noticed the other functions in bitmap_ops.h (like BitmapAnd, BitmapOr, etc.) don't currently have out_offset = 0 as a default. Would it be worth unifying those for consistency in a separate, follow-up PR, or is it safer to leave the existing signatures as-is?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "Shockp (via GitHub)" <gi...@apache.org>.
Shockp commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4328859209

   Sorry, I had some conflicts with my local branch while trying to pass the lint CI. I just squashed all the changes of the PR in a single commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4333337292

   Can we perhaps use this function in https://github.com/apache/arrow/blob/6198adcd3972d1c4a57c88d9f32b5bf9867b8366/cpp/src/arrow/compute/kernels/hash_aggregate.cc#L1342-L1348 ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4353499024

   Revision: 99022c3da08a5ee364e92fde6aae9c122e2898cf
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-4c878a50ea](https://github.com/ursacomputing/crossbow/branches/all?query=actions-4c878a50ea)
   
   |Task|Status|
   |----|------|
   |example-cpp-minimal-build-static|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-example-cpp-minimal-build-static)](https://github.com/ursacomputing/crossbow/actions/runs/25172213658/job/73794478290)|
   |example-cpp-minimal-build-static-system-dependency|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-example-cpp-minimal-build-static-system-dependency)](https://github.com/ursacomputing/crossbow/actions/runs/25172214673/job/73794484399)|
   |example-cpp-tutorial|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-example-cpp-tutorial)](https://github.com/ursacomputing/crossbow/actions/runs/25172211837/job/73794471654)|
   |test-build-cpp-fuzz|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow/actions/runs/25172212102/job/73794472530)|
   |test-conda-cpp|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-conda-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/25172210843/job/73794469516)|
   |test-conda-cpp-valgrind|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-conda-cpp-valgrind)](https://github.com/ursacomputing/crossbow/actions/runs/25172213085/job/73794476767)|
   |test-debian-13-cpp-amd64|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-debian-13-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions/runs/25172210827/job/73794469584)|
   |test-debian-13-cpp-i386|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-debian-13-cpp-i386)](https://github.com/ursacomputing/crossbow/actions/runs/25172212971/job/73794476486)|
   |test-debian-experimental-cpp-gcc-15|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-debian-experimental-cpp-gcc-15)](https://github.com/ursacomputing/crossbow/actions/runs/25172213627/job/73794478313)|
   |test-fedora-42-cpp|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-fedora-42-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/25172213199/job/73794480372)|
   |test-ubuntu-22.04-cpp|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-22.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/25172211958/job/73794471763)|
   |test-ubuntu-22.04-cpp-20|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-22.04-cpp-20)](https://github.com/ursacomputing/crossbow/actions/runs/25172212078/job/73794472293)|
   |test-ubuntu-22.04-cpp-bundled|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-22.04-cpp-bundled)](https://github.com/ursacomputing/crossbow/actions/runs/25172211179/job/73794469512)|
   |test-ubuntu-22.04-cpp-emscripten|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-22.04-cpp-emscripten)](https://github.com/ursacomputing/crossbow/actions/runs/25172212896/job/73794475605)|
   |test-ubuntu-22.04-cpp-no-threading|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-22.04-cpp-no-threading)](https://github.com/ursacomputing/crossbow/actions/runs/25172214148/job/73794479685)|
   |test-ubuntu-24.04-cpp|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-24.04-cpp)](https://github.com/ursacomputing/crossbow/actions/runs/25172210871/job/73794469510)|
   |test-ubuntu-24.04-cpp-bundled-offline|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-24.04-cpp-bundled-offline)](https://github.com/ursacomputing/crossbow/actions/runs/25172211766/job/73794471367)|
   |test-ubuntu-24.04-cpp-gcc-13-bundled|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-24.04-cpp-gcc-13-bundled)](https://github.com/ursacomputing/crossbow/actions/runs/25172211126/job/73794469561)|
   |test-ubuntu-24.04-cpp-gcc-14|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-24.04-cpp-gcc-14)](https://github.com/ursacomputing/crossbow/actions/runs/25172213006/job/73794475969)|
   |test-ubuntu-24.04-cpp-minimal-with-formats|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-24.04-cpp-minimal-with-formats)](https://github.com/ursacomputing/crossbow/actions/runs/25172213820/job/73794478641)|
   |test-ubuntu-24.04-cpp-thread-sanitizer|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-4c878a50ea-github-test-ubuntu-24.04-cpp-thread-sanitizer)](https://github.com/ursacomputing/crossbow/actions/runs/25172212500/job/73794474388)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4353981862

   Felicidades @Shockp ! :partying_face: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45819: [C++] Add OptionalBitmapAnd utility [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49848:
URL: https://github.com/apache/arrow/pull/49848#issuecomment-4450641748

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9abd6d328598080df628e4892c53daaf090d3d4f.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/75986973587) has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org