You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2026/10/01 02:35:24 UTC
[PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
lidavidm opened a new pull request, #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845
- ConnectionGetOption: return NOT_FOUND by default
- ConnectionGetInfo: return the driver version
- ConnectionGetObjects: return not-null info properly
- Allow setting target ingest schema so long as it's empty
- Return ALREADY_EXISTS for ingest operations where possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845#discussion_r4161731330
##########
c/driver/sqlite/sqlite.cc:
##########
@@ -702,11 +704,10 @@ class SqliteConnection : public driver::Connection<SqliteConnection> {
result.emplace_back(code, "ADBC SQLite Driver");
break;
case ADBC_INFO_DRIVER_VERSION:
- // TODO(lidavidm): fill in driver version
- result.emplace_back(code, "(unknown)");
+ result.emplace_back(code, "v" SQLITE_VERSION_STRING);
break;
case ADBC_INFO_DRIVER_ARROW_VERSION:
- result.emplace_back(code, NANOARROW_VERSION);
Review Comment:
I think I'd have to relax the check in the validation suite (and @eitsupi has pointed out before we don't really have any convention, which we should ideally define)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845#discussion_r4156188324
##########
c/driver/sqlite/sqlite.cc:
##########
@@ -702,11 +704,10 @@ class SqliteConnection : public driver::Connection<SqliteConnection> {
result.emplace_back(code, "ADBC SQLite Driver");
break;
case ADBC_INFO_DRIVER_VERSION:
- // TODO(lidavidm): fill in driver version
- result.emplace_back(code, "(unknown)");
+ result.emplace_back(code, "v" SQLITE_VERSION_STRING);
break;
case ADBC_INFO_DRIVER_ARROW_VERSION:
- result.emplace_back(code, NANOARROW_VERSION);
Review Comment:
Should this get prefixed with "nanoarrow"? The Rust ones output "v58.x.x" but the version is sort of unrelated.
##########
c/driver/sqlite/config.h.in:
##########
@@ -0,0 +1,18 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#define SQLITE_VERSION_STRING "@ADBC_VERSION@"
Review Comment:
This probably warrants a comment or a renaming of one of these variables. Is the version the ADBC spec version, the driver version, or the SQLite version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845#discussion_r4161861837
##########
c/driver/sqlite/config.h.in:
##########
@@ -0,0 +1,18 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#define SQLITE_VERSION_STRING "@ADBC_VERSION@"
Review Comment:
changed to SQLITE_DRIVER_VERSION_STRING
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845#discussion_r4156103689
##########
c/driver/sqlite/sqlite_test.cc:
##########
Review Comment:
Does SQLite have a getter for this?
##########
c/driver/sqlite/sqlite_test.cc:
##########
Review Comment:
Does SQLite have a getter for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(c/driver/sqlite): bring driver up to par, enable validation [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on code in PR #4845:
URL: https://github.com/apache/arrow-adbc/pull/4845#discussion_r4161786668
##########
c/driver/sqlite/sqlite.cc:
##########
@@ -702,11 +704,10 @@ class SqliteConnection : public driver::Connection<SqliteConnection> {
result.emplace_back(code, "ADBC SQLite Driver");
break;
case ADBC_INFO_DRIVER_VERSION:
- // TODO(lidavidm): fill in driver version
- result.emplace_back(code, "(unknown)");
+ result.emplace_back(code, "v" SQLITE_VERSION_STRING);
break;
case ADBC_INFO_DRIVER_ARROW_VERSION:
- result.emplace_back(code, NANOARROW_VERSION);
Review Comment:
This one #3851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org