You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/03/08 17:50:05 UTC
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 8, 2016, 5:50 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
**WIP: Do not commit**
Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
proposal.
It still lacks some parts:
- [ ] Doxygen in the interface.
- [ ] Updating `authorizer.md`
Still the basic functionality is there and I don't expect it to change
much. As I mentioned, comments aren't there yet but feel free to point
where they are missed, at this point focusing in the actual content
may not be relevant as the patch may change from its current form.
Diffs
-----
include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4
src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387
src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8
src/tests/mesos.cpp 395b23d32b2d03aef446858e197cb9788644eefa
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 9, 2016, 10:18 a.m., Adam B wrote:
> > src/master/master.cpp, line 2801
> > <https://reviews.apache.org/r/44322/diff/5/?file=1292969#file1292969line2801>
> >
> > Someday we may want to return something besides a bool, so that the client can get back a more meaningful error than "Forbidden", e.g. which of the N roles specified was disallowed?
> > Any ideas how we would do that for the operator endpoints?
I once used an `Error<Nothing>` as return value. We can check how boost implements its `error_code` I found their solution elegant and I use it in all my private projects (not that I have many anymore).
> On March 9, 2016, 10:18 a.m., Adam B wrote:
> > src/master/master.cpp, line 2837
> > <https://reviews.apache.org/r/44322/diff/5/?file=1292969#file1292969line2837>
> >
> > When would this ever be empty? Shouldn't we have validated somewhere prior that the Reserve operation is reserving at least one resource/role? I'd think this could be a CHECK.
Well, this version is consistent with the current semantics. I think having non resource is equivalent to request for all of them.
> On March 9, 2016, 10:18 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.hpp, line 82
> > <https://reviews.apache.org/r/44322/diff/5/?file=1292961#file1292961line82>
> >
> > Can we get a comment?
there will be some… it's in the TODO list in de description.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122699
-----------------------------------------------------------
On March 9, 2016, 6:07 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 6:07 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> **WIP: Do not commit**
>
> Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
> proposal.
>
> It still lacks some parts:
>
> - [ ] Doxygen in the interface.
> - [ ] Updating `authorizer.md`
>
> Still the basic functionality is there and I don't expect it to change
> much. As I mentioned, comments aren't there yet but feel free to point
> where they are missed, at this point focusing in the actual content
> may not be relevant as the patch may change from its current form.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
> src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
> src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387
> src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8
> src/tests/mesos.cpp 395b23d32b2d03aef446858e197cb9788644eefa
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On March 9, 2016, 10:18 a.m., Adam B wrote:
> > src/master/master.cpp, line 2837
> > <https://reviews.apache.org/r/44322/diff/5/?file=1292969#file1292969line2837>
> >
> > When would this ever be empty? Shouldn't we have validated somewhere prior that the Reserve operation is reserving at least one resource/role? I'd think this could be a CHECK.
>
> Alexander Rojas wrote:
> Well, this version is consistent with the current semantics. I think having non resource is equivalent to request for all of them.
Based on our offline talk: We cannot add a check because we cannot guarantee that the request validation was executed before this authorization request. So I added a note stating that and a TODO so that we ensure validation before authorization.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122699
-----------------------------------------------------------
On March 9, 2016, 3:10 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 3:10 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> **WIP: Do not commit**
>
> Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
> proposal.
>
> It still lacks some parts:
>
> - [ ] Doxygen in the interface.
> - [ ] Updating `authorizer.md`
>
> Still the basic functionality is there and I don't expect it to change
> much. As I mentioned, comments aren't there yet but feel free to point
> where they are missed, at this point focusing in the actual content
> may not be relevant as the patch may change from its current form.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122699
-----------------------------------------------------------
A couple of quick thoughts on your WIP so far.
Also, I committed the /weights endpoint, so there'll be 1 more ACL to refactor once you rebase. Sorry.
include/mesos/authorizer/authorizer.hpp (line 82)
<https://reviews.apache.org/r/44322/#comment184804>
Can we get a comment?
include/mesos/authorizer/authorizer.proto (lines 34 - 41)
<https://reviews.apache.org/r/44322/#comment184803>
s/AS/WITH/
s/OF/WITH/
s/FOR/WITH/
src/authorizer/local/authorizer.hpp (line 55)
<https://reviews.apache.org/r/44322/#comment184805>
Update comment, since it no longer applies to a block of `authorize` methods.
src/master/master.cpp (line 2793)
<https://reviews.apache.org/r/44322/#comment184806>
Someday we may want to return something besides a bool, so that the client can get back a more meaningful error than "Forbidden", e.g. which of the N roles specified was disallowed?
Any ideas how we would do that for the operator endpoints?
src/master/master.cpp (line 2826)
<https://reviews.apache.org/r/44322/#comment184807>
When would this ever be empty? Shouldn't we have validated somewhere prior that the Reserve operation is reserving at least one resource/role? I'd think this could be a CHECK.
- Adam B
On March 8, 2016, 9:07 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 9:07 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> **WIP: Do not commit**
>
> Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
> proposal.
>
> It still lacks some parts:
>
> - [ ] Doxygen in the interface.
> - [ ] Updating `authorizer.md`
>
> Still the basic functionality is there and I don't expect it to change
> much. As I mentioned, comments aren't there yet but feel free to point
> where they are missed, at this point focusing in the actual content
> may not be relevant as the patch may change from its current form.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
> src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
> src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387
> src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8
> src/tests/mesos.cpp 395b23d32b2d03aef446858e197cb9788644eefa
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122700
-----------------------------------------------------------
Bad patch!
Reviews applied: [44322, 44320, 44319, 44318]
Failed command: ./support/apply-review.sh -n -r 44319
Error:
2016-03-09 09:12:56 URL:https://reviews.apache.org/r/44319/diff/raw/ [28866/28866] -> "44319.patch" [1]
error: patch failed: src/authorizer/local/authorizer.hpp:71
error: src/authorizer/local/authorizer.hpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/11909/console
- Mesos ReviewBot
On March 9, 2016, 5:07 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 5:07 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> **WIP: Do not commit**
>
> Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
> proposal.
>
> It still lacks some parts:
>
> - [ ] Doxygen in the interface.
> - [ ] Updating `authorizer.md`
>
> Still the basic functionality is there and I don't expect it to change
> much. As I mentioned, comments aren't there yet but feel free to point
> where they are missed, at this point focusing in the actual content
> may not be relevant as the patch may change from its current form.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4
> src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
> src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
> src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387
> src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8
> src/tests/mesos.cpp 395b23d32b2d03aef446858e197cb9788644eefa
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122937
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44318, 44319, 44320, 44322]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 10, 2016, 2:15 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 2:15 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
>
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122991
-----------------------------------------------------------
include/mesos/authorizer/authorizer.hpp (line 43)
<https://reviews.apache.org/r/44322/#comment185106>
s/it does/it does/
include/mesos/authorizer/authorizer.proto (lines 27 - 28)
<https://reviews.apache.org/r/44322/#comment185097>
How about "If `value` is not set the subject is unknown."
include/mesos/authorizer/authorizer.proto (line 37)
<https://reviews.apache.org/r/44322/#comment185098>
s/unix//
You need to also add: "If `value` is not set the object is unknown".
include/mesos/authorizer/authorizer.proto (line 57)
<https://reviews.apache.org/r/44322/#comment185101>
2 blank lines.
include/mesos/authorizer/authorizer.proto (line 58)
<https://reviews.apache.org/r/44322/#comment185105>
<`subject`, `action`, `object`>
include/mesos/authorizer/authorizer.proto (line 59)
<https://reviews.apache.org/r/44322/#comment185102>
s/can/Can/
src/authorizer/local/authorizer.hpp (lines 51 - 55)
<https://reviews.apache.org/r/44322/#comment185109>
this comment should be in the review that introduced this overload.
src/authorizer/local/authorizer.cpp (lines 83 - 88)
<https://reviews.apache.org/r/44322/#comment185225>
This method's signature is not intuitive. For example, what's a selector? and why objects need a selector but not subjects? I know the reason for the latter, but you understand what i'm getting at.
One proposal:
```
struct GenericACL {
required ACL::Entity subjects;
required ACL::Entity objects;
}
Future<bool> authorized(const authorization::Request& request)
{
switch (request.action()) {
case authorization::REGISTER_FRAMEWORK_WITH_ROLE:
// Convert "RegisterFramework" ACL to a generic ACL.
vector<GenericACL> acls;
foreach (const ACL::RegisterFramework& acl, acls.register_frameworks()) {
GenericACL acl_;
acl_.subjects = acl.principals();
acl_.object = acl.roles();
acls.push_back(acl_);
}
return authorized(request, acls);
...
...
...
}
}
Future<bool> authorized(const authorization::Request& request, const vector<GenericACL>& acls)
{
...
}
```
If there is a way to templatize the conversion to GenericACL that would be better. But even without that, the above code is easier to follow IMO.
src/authorizer/local/authorizer.cpp (line 160)
<https://reviews.apache.org/r/44322/#comment185120>
no need for default. the local authorizer should be never called with an action it doesn't understand.
src/master/master.cpp (line 2892)
<https://reviews.apache.org/r/44322/#comment185227>
s/however/However/
src/master/master.cpp (line 2939)
<https://reviews.apache.org/r/44322/#comment185232>
new line.
src/master/master.cpp (line 3041)
<https://reviews.apache.org/r/44322/#comment185231>
new line.
- Vinod Kone
On March 10, 2016, 2:15 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 2:15 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
>
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review123143
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44318, 44319, 44320, 44322]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 11, 2016, 1:54 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 1:54 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
>
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review123214
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 11, 2016, 3:57 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 3:57 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
>
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 11, 2016, 4:57 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Addresses last issue in Vinod's review.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description (updated)
-------
Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd
src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 11, 2016, 2:54 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Addresses most of Vinod's comments.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description (updated)
-------
Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/master/http.cpp 54a2569ff5b10388177a9bd29c6ddc0387e5e8fd
src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 10, 2016, 3:15 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description (updated)
-------
Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.
Diffs
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 10, 2016, 3:10 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Rebase
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description (updated)
-------
Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122905
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44318, 44319, 44320, 44322]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 10, 2016, 7:34 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 7:34 a.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
>
> It effectively separates the language used to define ACLs from the
> language used to query it allowing for arbitrary identity server
> backends.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 10, 2016, 8:34 a.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Adresses Adam's review. Adds comments.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description (updated)
-------
Implements the [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ).
It effectively separates the language used to define ACLs from the
language used to query it allowing for arbitrary identity server
backends.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/#review122729
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44318, 44319, 44320, 44322]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 9, 2016, 2:10 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44322/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 2:10 p.m.)
>
>
> Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-2950
> https://issues.apache.org/jira/browse/MESOS-2950
>
>
> Repository: mesos
>
>
> Description
> -------
>
> **WIP: Do not commit**
>
> Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
> proposal.
>
> It still lacks some parts:
>
> - [ ] Doxygen in the interface.
> - [ ] Updating `authorizer.md`
>
> Still the basic functionality is there and I don't expect it to change
> much. As I mentioned, comments aren't there yet but feel free to point
> where they are missed, at this point focusing in the actual content
> may not be relevant as the patch may change from its current form.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
> include/mesos/authorizer/authorizer.proto PRE-CREATION
> src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
> src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
> src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
> src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
> src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
> src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
> src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
> src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
> src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
> src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
> src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
> src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
> src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
> src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
>
> Diff: https://reviews.apache.org/r/44322/diff/
>
>
> Testing
> -------
>
> make -j4 check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 9, 2016, 3:10 p.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Added support for the `ACL::UpdateWeights` message.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
**WIP: Do not commit**
Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
proposal.
It still lacks some parts:
- [ ] Doxygen in the interface.
- [ ] Updating `authorizer.md`
Still the basic functionality is there and I don't expect it to change
much. As I mentioned, comments aren't there yet but feel free to point
where they are missed, at this point focusing in the actual content
may not be relevant as the patch may change from its current form.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp 705482656788ac12e9d21e355b71fd2ede2be558
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt e9f7c3a447aad79ab19d53879888a413a587408f
src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp c87a9915bae6bae7744bd57abd12e8d857181051
src/authorizer/local/authorizer.cpp 15c857de79cd7dd2c29b6b8cfb81204b919f1b28
src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df
src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/master/weights_handler.cpp 9e4ab19fd760a56f1bbce915d1c7b63a0d1e5ed5
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9409da7ffe81ab4b1fc01213e27f1f639ba36581
src/tests/mesos.cpp 577072136415191334c74b69a1c0b7eed8e77e8b
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas
Re: Review Request 44322: Implemented a generalized interface for the
authorizer.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44322/
-----------------------------------------------------------
(Updated March 9, 2016, 6:07 a.m.)
Review request for mesos, Adam B, Joerg Schad, and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-2950
https://issues.apache.org/jira/browse/MESOS-2950
Repository: mesos
Description
-------
**WIP: Do not commit**
Implements the later [Generic Authorizer Interface v 0.3.1](https://docs.google.com/document/d/1-XARWJFUq0r_TgRHz_472NvLZNjbqE4G8c2JL44OSMQ)
proposal.
It still lacks some parts:
- [ ] Doxygen in the interface.
- [ ] Updating `authorizer.md`
Still the basic functionality is there and I don't expect it to change
much. As I mentioned, comments aren't there yet but feel free to point
where they are missed, at this point focusing in the actual content
may not be relevant as the patch may change from its current form.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp ec6c9928c55c3096c7de634f900419abbdd00886
include/mesos/authorizer/authorizer.proto PRE-CREATION
src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4
src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261
src/authorizer/authorizer.cpp 54278b022118c40d3b976794fd472ce8d8b6a5e2
src/authorizer/local/authorizer.hpp 96baf77709cf721caf46b6c2c096a843c1b5d9c0
src/authorizer/local/authorizer.cpp 4e5c2c2869823ec957735cebfc80dc850d40f9eb
src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387
src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f
src/master/quota_handler.cpp a41c91f10bc0eedc754425b4de1b3e184c4ffb08
src/tests/authorization_tests.cpp 2b2297036550412a955ff479f6ec9d7dad8cb0e3
src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8
src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8
src/tests/mesos.cpp 395b23d32b2d03aef446858e197cb9788644eefa
src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64
Diff: https://reviews.apache.org/r/44322/diff/
Testing
-------
make -j4 check
Thanks,
Alexander Rojas